Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37;
Message-ID: <01ac6657423d6f3a28aca457c5651c8bda12cd68.camel@kernel.org>
Subject: Re: [PATCH v1 0/8] Clean up XDR encoders for pNFS operations
From:   Jeff Layton <jlayton@kernel.org>
To:     Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc:     Chuck Lever <chuck.lever@oracle.com>
Date:   Fri, 29 Sep 2023 12:34:11 -0400
In-Reply-To: <169564827064.6013.5014460767978657478.stgit@klimt.1015granger.net>
References: <169564827064.6013.5014460767978657478.stgit@klimt.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Precedence: bulk

On Mon, 2023-09-25 at 09:27 -0400, Chuck Lever wrote:
> Tidy up the server-side XDR encoders for pNFS-related operations.
> Note that this does not touch the layout driver code; that can be
> done later.
>=20
> Series applies to nfsd-next. See topic branch
> "nfsd4-encoder-overhaul" in this repo:
>=20
> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
>=20
> ---
>=20
> Chuck Lever (8):
>       NFSD: Add nfsd4_encode_count4()
>       NFSD: Clean up nfsd4_encode_stateid()
>       NFSD: Make @lgp parameter of ->encode_layoutget a const pointer
>       NFSD: Clean up nfsd4_encode_layoutget()
>       NFSD: Clean up nfsd4_encode_layoutcommit()
>       NFSD: Clean up nfsd4_encode_layoutreturn()
>       NFSD: Make @gdev parameter of ->encode_getdeviceinfo a const pointe=
r
>       NFSD: Clean up nfsd4_encode_getdeviceinfo()
>=20
>=20
>  fs/nfsd/blocklayoutxdr.c    |   6 +-
>  fs/nfsd/blocklayoutxdr.h    |   4 +-
>  fs/nfsd/flexfilelayoutxdr.c |   6 +-
>  fs/nfsd/flexfilelayoutxdr.h |   4 +-
>  fs/nfsd/nfs4layouts.c       |   6 +-
>  fs/nfsd/nfs4proc.c          |   4 +-
>  fs/nfsd/nfs4xdr.c           | 206 ++++++++++++++++++++----------------
>  fs/nfsd/pnfs.h              |   6 +-
>  fs/nfsd/xdr4.h              |   7 +-
>  9 files changed, 135 insertions(+), 114 deletions(-)
>=20
> --
> Chuck Lever
>=20

Looks good. Nice cleanup.

Reviewed-by: Jeff Layton <jlayton@kernel.org>