Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp1618572rdb; Mon, 2 Oct 2023 15:50:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHClqCGZiCha/pLFLgjdLfWcmGsB3KWRnBOV0MBb2eENcCEEJ3pI7+M0BqSoWnPXpqbKiql X-Received: by 2002:a05:6a00:23c2:b0:692:b4d8:c8b4 with SMTP id g2-20020a056a0023c200b00692b4d8c8b4mr12956364pfc.21.1696287047809; Mon, 02 Oct 2023 15:50:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696287047; cv=none; d=google.com; s=arc-20160816; b=mHwTR8I6ClAy0Q5qRMeqIkVDeWczjfJBIpFIcGDtD2I2d/p3djFQgE2Y4XdqBKvSCm lO6pzQzn1qcdN6C3CJQCnGv2TPFX9O9kE8jinPb9JdqZXcLjQK4eUwAXmSDRSHKecZOt wsEeK2vNeO9bQt68PsRS4ZmSEEDa5K0TfUf3ccQHQqTlGeauYuTFO6fJeKUoLynRSLOD puUfQMS3/VZJMC38FiTefl7uSE7TsZK/3DySwKT6coVsnGKD79x8ZEl2nOus5YjBslN/ YBgxAA4Hop+8fqay9OIgC0h4/uUm+8gPuRV8jLSwU5I3ZEFk/TA4DCCtkbOmLbX3bTUu JlJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=LOIeyzyBBTzDeBQ3c0LeWGcGBvFSKm0ymMOwVybD/5E=; fh=c8TIb97LjensOOkBbBb8gBJn/mm65HR8ad23+ZOJJNY=; b=QBraA+RQkJ44KX197J8JdiVayRTWOK3omor4BmAVLcabkNNtyOCD0V6XG1pux3vAWi zPUlQ1e0p7+6f0DDkRkMzOvQH281L7z0nB6dvufljoJXo+PQ7yNV4LvHkJ+M4JdC4sRO /awLCzdchuNAgTb+EljWcRWvgYFwL7m/qlDK9njgB0pEjXVdgHfuGyiT4v2EvnzBv90V JIF+bX4cPzSmbuM2LcrQ74jJkvuZCvSbKNOJhGl9rcaW/r2MlQz6rNj8jAajdU/yvsaI Z4KAHCkkhuqULcuVdqVnnFAxEDjSLZwfWW/s8v8RG88vlUlONhywTRiRabbOlEPpbcm2 AtQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZyMA3gai; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id fb40-20020a056a002da800b0068ff3927553si24222pfb.35.2023.10.02.15.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 15:50:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=ZyMA3gai; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id EDC0E8029368; Mon, 2 Oct 2023 13:17:56 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229679AbjJBUR6 (ORCPT + 99 others); Mon, 2 Oct 2023 16:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbjJBUR5 (ORCPT ); Mon, 2 Oct 2023 16:17:57 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3ACDBB7 for ; Mon, 2 Oct 2023 13:17:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696277827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LOIeyzyBBTzDeBQ3c0LeWGcGBvFSKm0ymMOwVybD/5E=; b=ZyMA3gaiPV8ORFMRILBteAHba2zSkM15hbB/JAs1bO4JAFrkwUN+SNq7kWnGlXspTqG8x3 hwhPgvIeOU7+o/DzjQ/BWufhrKZdU3k+J+5uRQbVYIlW8opIlnyUT5QXS1emz4ZQgj3Q6o S2nguWDqq/7DsxlZfdL2y47HC5Ggut8= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-357-WXmXWeiROTaovMdZXPD4yg-1; Mon, 02 Oct 2023 16:17:01 -0400 X-MC-Unique: WXmXWeiROTaovMdZXPD4yg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E0623185A79B; Mon, 2 Oct 2023 20:17:00 +0000 (UTC) Received: from [100.85.132.103] (unknown [10.22.48.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 16F862156701; Mon, 2 Oct 2023 20:16:59 +0000 (UTC) From: Benjamin Coddington To: Scott Mayhew Cc: trond.myklebust@hammerspace.com, anna@kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH 1/1] NFS: Fix potential oops in nfs_inode_remove_request() Date: Mon, 02 Oct 2023 16:16:58 -0400 Message-ID: In-Reply-To: <20230725150807.8770-2-smayhew@redhat.com> References: <20230725150807.8770-1-smayhew@redhat.com> <20230725150807.8770-2-smayhew@redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 02 Oct 2023 13:17:57 -0700 (PDT) On 25 Jul 2023, at 11:08, Scott Mayhew wrote: > Once a folio's private data has been cleared, it's possible for another > process to clear the folio->mapping (e.g. via invalidate_complete_folio2 > or evict_mapping_folio), so it wouldn't be safe to call > nfs_page_to_inode() after that. > > Fixes: 0c493b5cf16e ("NFS: Convert buffered writes to use folios") > Signed-off-by: Scott Mayhew Reviewed-by: Benjamin Coddington Tested-by: Benjamin Coddington Ben