Received: by 2002:a05:7412:3784:b0:e2:908c:2ebd with SMTP id jk4csp2124780rdb; Tue, 3 Oct 2023 10:56:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJ4GB8f6oIIeBUHouL7iM9v0VZt/y3vwH7tRz93qS+xrtWCWnpwCoQ2VGm547TtghaXj59 X-Received: by 2002:a17:902:eb4c:b0:1bd:bbc3:c87b with SMTP id i12-20020a170902eb4c00b001bdbbc3c87bmr224698pli.41.1696355775573; Tue, 03 Oct 2023 10:56:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696355775; cv=none; d=google.com; s=arc-20160816; b=HAvXjuduxOVrO78T8/+UkBnhw4NajTKuQ+Zm9fnDhJ5712NrhGwEVQMWThEEwx4hxI VPCkyl/gl4Dl2ZpNFNCAOkbkWnaEJOrGuekInsVIP29FOJHp0QHdNIYgXVN7IEMiIi0K ZJl5RiA8cBDDvUNmPpyCgsc1xCoCT9COaaUEcJo+WS7UhTeGhYH8LGXyArb9taEDVGvW EG9S3ha/w3PCrbsjjodU3o0PefDuIrxFqbGYOHsCfSKmPKUMMFdQGByimnXNyBlKq5WV 4O236XlFe3G9O+QiGKw/g/yYjaNXexupLEKtZOCIBSB+t03r2ZkPjZCJsmZU37aBGWks AZwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=/I307Ux/EcqbBBceIimkR+u7FTMBeZT0KeDinjyBL/s=; fh=VxY+Wmqg85qc13Ygd+I5uloGCvRHoxlqj05aFtiB4ak=; b=JyJA5Yxms1YHOy587e9OXe3BXmX6hfcrEX8DYYZG2Ff8HxkM9fEhl8sUw4JaOm1pTr Y77daufM45roKKnGd5EXtPkWAYeqZZM70ZawlErQ+ih1teYQszhj82+KFEPzNaZrRL2F 5UtE2/7NqVeZEUlsIwqP4e9v06Loh4AJ2vrCYT2ajj0cWeoyktX4hAs9C7ojcFXgv/YT G39GsqA77yKO+W3soEXSyXMPF6G9e54VZhBLvD2X7SPT84gZpyfssEm1mtJwQVuxy9of I+q7dpY+dClvCFR6V24s/hsSSqE+B6zFTb5V9YLSNTRKIjQQF3cgvXRdEMOhSS3iKEAu NMwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jq7COVgR; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id kk3-20020a170903070300b001b8ba81d04dsi1809664plb.395.2023.10.03.10.56.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Oct 2023 10:56:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jq7COVgR; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id DF9A68025811; Tue, 3 Oct 2023 10:55:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240747AbjJCRzu (ORCPT + 99 others); Tue, 3 Oct 2023 13:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240732AbjJCRzq (ORCPT ); Tue, 3 Oct 2023 13:55:46 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D8265CE for ; Tue, 3 Oct 2023 10:55:42 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23721C433C9; Tue, 3 Oct 2023 17:55:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696355742; bh=gcYhbiv6s3HPdYSDDfxpvxQsIE4cXTHj+uXhxeromT0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jq7COVgR1vR7n6LENmxU9AXl21eFb6N6O1Qu/ai9E6q80T8mDYPT6W1xqjYWeOIXr +Ka2yBoLTpYGSjWmTC139YVuXHFkE32ULOBYaQQnSktm1vHHTJNkmV6/aeZL+fwvGj IqJ/x4TXwCh0bfP10r7RD2mC9yZ8ysLm5M4Z9lxcg9mgXWMlxiz7oV70TJGvtiQu9l Iu5w68s8HxuCbaA0TrgfFlbJT+wghD8N8YzkhZnjmTgRyctqJCRS83Lvz1r2bgmsd3 uibAWpQ8lydTM9OZuvFxQwZIkx21R81WElXmWUbYlXPAVUYeBTwhUDQ5ExOQZTTOqu zN5BDUfDQzjEg== Date: Tue, 3 Oct 2023 10:55:40 -0700 From: Jakub Kicinski To: Lorenzo Bianconi Cc: linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, netdev@vger.kernel.org Subject: Re: [PATCH v8 1/3] Documentation: netlink: add a YAML spec for nfsd_server Message-ID: <20231003105540.75a3e652@kernel.org> In-Reply-To: <47c144cfa1859ab089527e67c8540eb920427c64.1694436263.git.lorenzo@kernel.org> References: <47c144cfa1859ab089527e67c8540eb920427c64.1694436263.git.lorenzo@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 03 Oct 2023 10:55:50 -0700 (PDT) On Mon, 11 Sep 2023 14:49:44 +0200 Lorenzo Bianconi wrote: > Introduce nfsd_server.yaml specs to generate uAPI and netlink > code for nfsd server. > Add rpc-status specs to define message reported by the nfsd server > dumping the pending RPC requests. Sorry for the delay, some minor "take it or leave it" nits below. > +doc: > + nfsd server configuration over generic netlink. > + > +attribute-sets: > + - > + name: rpc-status-comp-op-attr > + enum-name: nfsd-rpc-status-comp-attr > + name-prefix: nfsd-attr-rpc-status-comp- > + attributes: > + - > + name: unspec > + type: unused > + value: 0 the unused attrs can usually be skipped, the specs now start with value of 1 by default. Same for the unused command. > + - > + name: dport > + type: u16 > + byte-order: big-endian > + - > + name: compond-op > + type: array-nest Avoid array-nests if you can, they are legacy (does this spec pass JSON schema validation?). There's only one attribute in the nest, can you use - name: op type: u32 multi-attr: true ? > + nested-attributes: rpc-status-comp-op-attr > + - > + name: rpc-status-get > + doc: dump pending nfsd rpc > + attribute-set: rpc-status-attr > + dump: > + pre: nfsd-server-nl-rpc-status-get-start > + post: nfsd-server-nl-rpc-status-get-done No attributes listed? User space C codegen will need those to make sense of the commands.