Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
CC:     Jakub Kicinski <kuba@kernel.org>,
        Lorenzo Bianconi <lorenzo@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH v8 3/3] NFSD: add rpc_status netlink support
Thread-Topic: [PATCH v8 3/3] NFSD: add rpc_status netlink support
Thread-Index: AQHZ5K6VPzxSK7yJLUWv/wHoLPVEXbA4fpgAgAEPLoCAADXKAA==
Date:   Wed, 4 Oct 2023 13:27:15 +0000
Message-ID: <6A47BDC7-FB73-4799-BC6A-9C0C020E424D@oracle.com>
References: <cover.1694436263.git.lorenzo@kernel.org>
 <ac18892ea3f718c63f0a12e39aeaac812c081515.1694436263.git.lorenzo@kernel.org>
 <20231003110358.4a08b826@kernel.org> <ZR07CYtL8GwMQQPV@lore-desk>
In-Reply-To: <ZR07CYtL8GwMQQPV@lore-desk>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ainv+XGspqoc20x/5ewl1Jiw6IElrr8gMihB9fPnyjAWty3BTP8SOvDYRh6e?=
 =?us-ascii?Q?t65ZhJYkm20STnSVxpl0rIDtKw7RTKBpyPP62kxqWiDlIyHDVhNFHBW32Rp1?=
 =?us-ascii?Q?dfrt38ogTyNUvZ7n7qt/70UTvt/tA44NfL9pKws6VeRhAuVjl3JTo47kT2zT?=
 =?us-ascii?Q?4MSamOXLFU9/qlmJVLiun6RIEM3ExJ+Y/LsuY+FxcY7bpdK4O0ZyuO7Yubqr?=
 =?us-ascii?Q?NnegBeZuD1eKeFqUgs6nv0XcVlJhBQsaDAHMDPCfjVtEQ09G+A09EblYXZuJ?=
 =?us-ascii?Q?nrltxoTBrN1EsXqhFSi6SGbwh601tmzMGMhajD6UizrTM/MLdWSuMiqfyyCj?=
 =?us-ascii?Q?ha4S2/Z+SDwTt6GxI/hDkMNT1DZ8xN2CZZmiMN8Bnlx1Fw6mrKYcVAab4+LO?=
 =?us-ascii?Q?W2MyAAVdrrludba/DihDxmlPWuYbBlvzIR8X61DTnfgA34juplELtH4xLxlq?=
 =?us-ascii?Q?Q2Kofca+weTdk5nTruIoOUNNDxsuNeIPJFzEDHL0Rc1l64TbZH31bx7q6l2h?=
 =?us-ascii?Q?jlvaeH8hp40CliAqAVtuiLmcRVcdOMP/fE29FlLSVBJpArvIyQRxhwOTjuAx?=
 =?us-ascii?Q?iDlLQXuS9Rvb4PpoOqU6uiH/FIWgbWvCz9EqF1y9EYyJUjy5nkxD6kbjGQcU?=
 =?us-ascii?Q?h2RC598WmR6h0J4/szH7WbxnPqtlVQre7LoyyOmIvJGr3m1NAS6xMPoNXhtE?=
 =?us-ascii?Q?89CQKfeuh5Jq5Vume8Pzu3Vi/9tm6CUdhJbjpCVLd8kSumTbtzyY5qQPWSxB?=
 =?us-ascii?Q?k6TQLO9tPTEZISelAIx/X0RfvV6COUv35ip4p1b7lTzrUHz3VY/r++PnFqs4?=
 =?us-ascii?Q?6FVjkFK/ACq3O0X3vniaipbquDTFwWB4feGWAUVyoimOCDkjLwsWKvzOkX/c?=
 =?us-ascii?Q?Hlb4iyWQr1Vi9DruDwUYg8+NyHL55FK9ZasB0HAsaXig5mKgqSuj4hFHEILl?=
 =?us-ascii?Q?6Li/ewF38GVeLx55Ze+7jECki8g/62Rt3ChHB5T6jdyRYDkVn+ix5Imq8Vz7?=
 =?us-ascii?Q?/HeEjvjqYedhsFXx88fCHtQf5W/qJnbyg9UKa94JzQtGz7xNC+YD87VVv++D?=
 =?us-ascii?Q?dlXLaY/99QbczNe3F41EdO9XXJ9CjK6kGufeTQvK46gcernRj8FONBSVnHz/?=
 =?us-ascii?Q?gxtVPjc0rrkVm18vOqQEI4KnJjgSzuByqXEeR+M2HcFGqWhfuh/lcJZx/JmN?=
 =?us-ascii?Q?hNWXVfj+bz6KwLrl4FIzSf6++Kzc2E6ShrFoYcApamKF3qBlhpluIQa1PNtd?=
 =?us-ascii?Q?CE0Ie0uEEW8bvTW2LJAe7vNMIKmni4Vd6xKSmlHF8jFbSo7DUULrGyouJs/b?=
 =?us-ascii?Q?2glKtVth4S9juRsv44jJvrnN8FaaVv8+EONEOzufuSgsX06YM1xGMnqTIq1A?=
 =?us-ascii?Q?8zZGGS9mttTkfNTftLRo2WQHVZFp39ivHbA3UvhwzdooE4Zwoz+lKHzufJYg?=
 =?us-ascii?Q?avdHuL4OelwD+O6ZFM6V/Ro5SJLG/gUplrdAsWQEQQ1ybEBMDpcRXS6dhRfj?=
 =?us-ascii?Q?ays/TDZjcp3LSKbtqrPSWeMwu4FdHENMv38uNfNCcbCsq0W+AcrDO8XfBIPv?=
 =?us-ascii?Q?3SJ+BrRCAwWxrdEOh9iXR+9XOrIy57hyFFqAruD7JT/BuMpzDOaHrxFBZePf?=
 =?us-ascii?Q?Nw=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <F01C25557522D64CAEEF782DCFF86EDA@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: Dm0SIf7jjU1f8M60GP6pAd15THIWbaP8d0mT4EDC2dV/MW3dWSLvpY+KReduH5YnqfdcuSgaBy3Op6SEszhqxZCAD4lMRZBh9DjYDAlLMJcz0OXiaQdxHC2S0b1TQWfpI+I+az19eSr8w18rk2bEGYOVS34RVirE8qZHpWJ+0tY0eBqSKbpOdQe5M+nZXMruLMJ836iKZM9L58p6Nex9Fua7dHbeuvghRaL+E1KP9gptqAOnvlptU8DyCsfHwhstOgFqKDndzc7hXdPnAREc7BjhCp3FQLwVXRjvGEILZ0Ihoc37QbC0tKcLJROrCK0Ttk2nJywYadJOHisNVegowwSrmOWHbHMy4cW0tU/lgB8T4IFOGXuNs6scQXcPrrslkLRvNBmp8Id37q1Ap1tLdgalrLKBEW8fDH+eDOA3AX7RPhZRwWFMgZgcdPTVkBRHzL8feeK8bMWtlkfiH4iyBlJcBPL42PdmGSMzsME9mowwzLkKUJBPRpW+4l35f4C+Usz+wI1DivNIoXC0sNBXhJY+O4U3a3ELWhNN1tOsR+G9lZYOTlp4GTwu6FybWDgNcfH422DeQeGlejpHueNzJMjHQO/kI5dZYr5jqszqhgrRYs1sVkr5YI5YXMjK2jA2RWGynnO5No/mNJbgyLwXYZQ9Xcyl5ZuHmJXE6jm1A4N1xPYRr0Fdf7Z+SFqtKl4QPjGIYEunJzcIEsrfliUiKYdmVBMfVEL0REFn78K3cDz9I2WDVuklSkZpI4KAEyjEzM0hIrwWdaSXeHdooiMGvhW8t9NOf4bjmSFUEXqEPTprO/Yk6wVtt2bFIbAgg9r24+Jay+0FJ+9zR+EKherb8w==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 86fa96c8-300a-4117-1308-08dbc4dd9fdc
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Oct 2023 13:27:15.1761
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e19w8CWlNkisrU3GbXMEL/ptvWxHgytA5/2uN8LDjS0Xfk3vxeCiKK2nkTIvfnV3ojadv+qAKbvxEM/V/7swDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5401
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-04_05,2023-10-02_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 malwarescore=0
 adultscore=0 suspectscore=0 mlxlogscore=641 bulkscore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2309180000 definitions=main-2310040097
X-Proofpoint-ORIG-GUID: IDI7jFfAowo4kWshPP-sCYiD07d99IcQ
X-Proofpoint-GUID: IDI7jFfAowo4kWshPP-sCYiD07d99IcQ
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 04 Oct 2023 06:27:39 -0700 (PDT)


> On Oct 4, 2023, at 6:14 AM, Lorenzo Bianconi <lorenzo.bianconi@redhat.com=
> wrote:
>=20
>> On Mon, 11 Sep 2023 14:49:46 +0200 Lorenzo Bianconi wrote:
>>> + hdr =3D genlmsg_put(skb, NETLINK_CB(cb->skb).portid, cb->nlh->nlmsg_s=
eq,
>>> +  &nfsd_server_nl_family, NLM_F_MULTI,
>>> +  NFSD_CMD_RPC_STATUS_GET);
>>> + if (!hdr)
>>> + return -ENOBUFS;
>>=20
>> Why NLM_F_MULTI? AFAIU that means "I'm splitting one object over
>> multiple messages". 99% of the time the right thing to do is change=20
>> what we consider to be "an object" rather than do F_MULTI. In theory
>> user space should re-constitute all the NLM_F_MULTI messages into as
>> single object, which none of YNL does today :(
>>=20
> ack, fine. I think we can get rid of it.
> @chuck: do you want me to send a patch or are you taking care of it?

Send a (tested) patch and I can squash it into this one.


--
Chuck Lever