Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7;
Date:   Thu, 5 Oct 2023 11:03:53 +0200
From:   Lorenzo Bianconi <lorenzo@kernel.org>
To:     Jakub Kicinski <kuba@kernel.org>
Cc:     linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com,
        jlayton@kernel.org, neilb@suse.de, chuck.lever@oracle.com,
        netdev@vger.kernel.org
Subject: Re: [PATCH v3] NFSD: convert write_threads, write_maxblksize and
 write_maxconn to netlink commands
Message-ID: <ZR57+cIx6t/2lURA@lore-desk>
References: <27646a34a3ddac3e0b0ad9b49aaf66b3cee5844f.1695766257.git.lorenzo@kernel.org>
 <20231004100955.32417c33@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="wwNqDGKJgf2QrUnW"
Content-Disposition: inline
In-Reply-To: <20231004100955.32417c33@kernel.org>
Precedence: bulk


--wwNqDGKJgf2QrUnW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> On Wed, 27 Sep 2023 00:13:15 +0200 Lorenzo Bianconi wrote:
> > +int nfsd_nl_threads_set_doit(struct sk_buff *skb, struct genl_info *in=
fo)
> > +{
> > +	u32 nthreads;
> > +	int ret;
> > +
> > +	if (!info->attrs[NFSD_A_CONTROL_PLANE_THREADS])
> > +		return -EINVAL;
>=20
> Consider using GENL_REQ_ATTR_CHECK(), it will auto-add nice error
> message to the reply on error.

ack, I will fix it.

>=20
> > +	nthreads =3D nla_get_u32(info->attrs[NFSD_A_CONTROL_PLANE_THREADS]);
> > +
> > +	ret =3D nfsd_svc(nthreads, genl_info_net(info), get_current_cred());
> > +	return ret =3D=3D nthreads ? 0 : ret;
> > +}
> > +
> > +static int nfsd_nl_get_dump(struct sk_buff *skb, struct netlink_callba=
ck *cb,
> > +			    int cmd, int attr, u32 val)
>=20
> YNL will dutifully return a list for every dump. If you're only getting
> a single reply 'do' will be much better.

ack, I will fix it.

Regards,
Lorenzo

--wwNqDGKJgf2QrUnW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYKAB0WIQTquNwa3Txd3rGGn7Y6cBh0uS2trAUCZR57+QAKCRA6cBh0uS2t
rKI1AP9YnWau62lwbFjDZnsQcxH8VUlxuKPPjUzqvmgU3w9e7QD/Wy7QqL2w2EXT
J+3t8IEkfYq6GO9AVb+bMEolnsU/ZwY=
=3tsm
-----END PGP SIGNATURE-----

--wwNqDGKJgf2QrUnW--