Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp295385rdg; Tue, 10 Oct 2023 10:23:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEqBWwd9Bwv5FfPrwrLnnT88Fd3H09n0+HlchlVmwdV1V75wHG9Hr6INfWvMGQqBZzz3tQJ X-Received: by 2002:a05:6830:204b:b0:6bd:b0c9:a8d with SMTP id f11-20020a056830204b00b006bdb0c90a8dmr19827421otp.25.1696958634783; Tue, 10 Oct 2023 10:23:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696958634; cv=none; d=google.com; s=arc-20160816; b=s1TI+Vg++w2zSkZ3aQ3IslIqazTQ/oUIQ/OSo3zHAQ8zIa7FjWKL1KyoJEGbPGbOrU iDJUpUPooxHoFMDMW/2hxTC2a/YJcfxP7NUQeZdAAYMrF4mHOyKP/26ylWOzWwtu/NWD fPsVUUVY3Af2YcRMEGdF5MQLlWkS6h625SFydB+BJki6iLviMdLPFN2SDH/evR2vcd8a 5v00hPKUtJHmWUi72dTJQNDL64d8b1t+Zfq6RLQctvnyx53xGVedlo7zKRL+9hO14FQ2 p4su1cvZkazOAcyPQxyH1fW8mTwtH7Qo8E7wmz/5tQD1PqAWyagMsMWhp/Jjaw35ziX3 qwXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject:dkim-signature; bh=cv71ZfGpoHb/rtH65BV3cY15uXonJkCJhT4YKGcKmaE=; fh=7/Mo/IGUjRyRs46LyZlTadwUBzL+qBZ2EB3fS4nyimU=; b=GilS4Poz9buPJHr9nTGB8GiCr/UO1tBMYm0jDpwJQlH4FjxjgM2P1WbaY+APjuCcNY lLvJ8UNb15dr/gs+N7XEK8eWqCUOZlLZz8M0+nsqYlfqXZZs7Imoih7a5+RV7+YEGGK9 1gQE+eN2ymyjf6ceIwEOAEvYyfCJW5SXXpOerO8o00noEG3/+xIh/KCyA4BQyt/kKOi3 bg6MULqF0DXYqF3m264bGNw7Vfgpbmehw+2uv9ng2OsdCDBoD6WCDLKJZQBdsbPl3ruX DQYs+Ygkq+y42XUqZ7b6QoKy7Rrh5dMyrTZmWct0ohqeKHJqlqhz7x18G6rEX2cMPSx3 lqqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=svgTujZU; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id f20-20020a63f114000000b00573fc71f6d9si12803208pgi.64.2023.10.10.10.23.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Oct 2023 10:23:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=svgTujZU; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 8A1B1805CDA0; Tue, 10 Oct 2023 10:23:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233934AbjJJRXr (ORCPT + 99 others); Tue, 10 Oct 2023 13:23:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233897AbjJJRXr (ORCPT ); Tue, 10 Oct 2023 13:23:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CD7BCDA; Tue, 10 Oct 2023 10:23:43 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 23293C433C7; Tue, 10 Oct 2023 17:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696958623; bh=9CAHu2Mk7utsjo1uVq4x7O3BUPyqg9XzzYVVLuRXWKI=; h=Subject:From:To:Cc:Date:From; b=svgTujZUqmjlwchBwyEiBzWxzE3mwZwworDwm/zfqHZRBzD4oExXWWm0LlMaTg39o b9Ii4LG0FiaiI9w950IjMMly0vKh6oBB0xZQdkGwXtra2s9saunqK3Fv38LhNAHMlp eu60hj+UsQXfRQrxy0c50AE94EubLQlRzctUYV0plCp0BO6u6j4iu/eQNtUYWlfJAm 6mtZACZk8TN2k3xF1yw2vcrxJSugTT5WWNRN2C3XRGC11j/u1L6iw05H6mY8o+u44x Cg6HYoLyEY/BzD90CCplnRmfvB1X1ABVkq3nbdqQL6sznQ2LCINXLEiwTJLGyGQbyD kk20+ldL2IJPA== Subject: [PATCH v1] svcrdma: Drop connection after an RDMA Read error From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: stable@vger.kernel.org, Chuck Lever Date: Tue, 10 Oct 2023 13:23:41 -0400 Message-ID: <169695862158.5083.6004887085023503434.stgit@oracle-102.nfsv4bat.org> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=2.4 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 10 Oct 2023 10:23:52 -0700 (PDT) X-Spam-Level: ** From: Chuck Lever When an RPC Call message cannot be pulled from the client, that is a message loss, by definition. Close the connection to trigger the client to resend. Cc: Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c index 85c8bcaebb80..3b05f90a3e50 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c @@ -852,7 +852,8 @@ int svc_rdma_recvfrom(struct svc_rqst *rqstp) if (ret == -EINVAL) svc_rdma_send_error(rdma_xprt, ctxt, ret); svc_rdma_recv_ctxt_put(rdma_xprt, ctxt); - return ret; + svc_xprt_deferred_close(xprt); + return -ENOTCONN; out_backchannel: svc_rdma_handle_bc_reply(rqstp, ctxt);