Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp1063557rdg; Fri, 13 Oct 2023 09:08:47 -0700 (PDT) X-Google-Smtp-Source: AGHT+IElBT8ffZnn3MnrHqOWMF+PMRlM6Weyvy0KIfb9TASDU7RXr/eLREPbJTBIOb+cKfNFY17d X-Received: by 2002:a05:6a21:78aa:b0:16b:9886:7eda with SMTP id bf42-20020a056a2178aa00b0016b98867edamr27481370pzc.35.1697213327325; Fri, 13 Oct 2023 09:08:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697213327; cv=none; d=google.com; s=arc-20160816; b=hkFvI4fIxtxd9gfS2Z8rhK6Yb7RQRMZyx+ISeVAqTzHcIiL2Pg7VQgFETq4eJqfcHb W0HKo11wcZ2tXOm8nEVrWJvpu5EWBM2pKuPpayoWL+4Z/ps55cu+lzbgXqRtPG31SjYz qARPRqk59WVwrV7RMjXl8QAyIDqe0Uyv3xEMUZScBmbYtMKYiaBEj3Zp0eIcrTYvuZs6 S8X+BjkU5xmfLVS7Ql+k7TI+2Kd786fF5deznEIEkzTQ7Ssa97ArFBRs2LA4Vk38kLZC thRuOyFkK7KcrMsiZg1iPDPmYYdb9qcmAvvh5ILGClCZPn67HngWOi038yrwuNiJyRMC BydQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=YCXtE3Gqov3oA1rKgjLh+er5qsDXpT3dWhNn5qjdKp8=; fh=QCasRecNkSMoqSQLnZiX89u33dCID3L05AOtURpI2pA=; b=D1gSy3j6BrB11wnXwFIl0pW6yCZpZ5u5Md10PJHpfvZyLD7gaO1/6qFYFWQDP1BFx1 +IjMULCXQ8i931ncIgzGvRyT7QqMuOtcikfyJRX3A75bNgiG/7RSYSkK8JrMtFBhHR7G y1PcVQyR4nq0E9JedPJq/4uMTC065RnutpAICjoOk9k4C12WE66wNhEGB157dCOTckKr tTp6tyY1yfaBuu9Zw+1xnMEKYqMR1qmwJG/aILGA/Pla09YC/R0pBqnfdS4nn3VNrJ7w ZlUrZjkbqMEkno9YpajAt2enrbmVsaE/twHb+CtKp9YoeHpNzfdsLlAFVBAjmi7mA6Fk HPfQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GA5+rYD7; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id q6-20020a635046000000b005898d997f52si4834564pgl.66.2023.10.13.09.08.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 09:08:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GA5+rYD7; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id BA6CE8205FE4; Fri, 13 Oct 2023 09:08:44 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231588AbjJMQIh (ORCPT + 99 others); Fri, 13 Oct 2023 12:08:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230119AbjJMQIg (ORCPT ); Fri, 13 Oct 2023 12:08:36 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58E10198B for ; Fri, 13 Oct 2023 09:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697213168; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YCXtE3Gqov3oA1rKgjLh+er5qsDXpT3dWhNn5qjdKp8=; b=GA5+rYD7VWonDrJOLuS5i505X2YLSYoDuHxIPeCZXCNq+RpxZanjGk6fupKyawwMgP6bYM gV+eQ5otgHR7kH59ENZMs03Szdn64snIEJ7/y41KpoP8BE9t9g9ZxwUjvicdP7mHhzFYdv lr184Vf4EV32QyXHVI1/a7LzDMmXeZE= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-173-TJDkM4R1O72X3owEh91uEg-1; Fri, 13 Oct 2023 12:05:59 -0400 X-MC-Unique: TJDkM4R1O72X3owEh91uEg-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 93274801E62; Fri, 13 Oct 2023 16:05:58 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 11660C15BBC; Fri, 13 Oct 2023 16:05:55 +0000 (UTC) From: David Howells To: Jeff Layton , Steve French Cc: David Howells , Matthew Wilcox , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Ilya Dryomov , Christian Brauner , linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: [RFC PATCH 26/53] netfs: Allocate multipage folios in the writepath Date: Fri, 13 Oct 2023 17:03:55 +0100 Message-ID: <20231013160423.2218093-27-dhowells@redhat.com> In-Reply-To: <20231013160423.2218093-1-dhowells@redhat.com> References: <20231013160423.2218093-1-dhowells@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 13 Oct 2023 09:08:45 -0700 (PDT) Allocate a multipage folio when copying data into the pagecache if possible if there's sufficient data to warrant it. Signed-off-by: David Howells cc: Jeff Layton cc: linux-cachefs@redhat.com cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org --- fs/netfs/buffered_write.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fs/netfs/buffered_write.c b/fs/netfs/buffered_write.c index 406c3f3666fa..4de6a12149e4 100644 --- a/fs/netfs/buffered_write.c +++ b/fs/netfs/buffered_write.c @@ -84,14 +84,19 @@ static enum netfs_how_to_modify netfs_how_to_modify(struct netfs_inode *ctx, } /* - * Grab a folio for writing and lock it. + * Grab a folio for writing and lock it. Attempt to allocate as large a folio + * as possible to hold as much of the remaining length as possible in one go. */ static struct folio *netfs_grab_folio_for_write(struct address_space *mapping, loff_t pos, size_t part) { pgoff_t index = pos / PAGE_SIZE; + fgf_t fgp_flags = FGP_WRITEBEGIN; - return __filemap_get_folio(mapping, index, FGP_WRITEBEGIN, + if (mapping_large_folio_support(mapping)) + fgp_flags |= fgf_set_order(pos % PAGE_SIZE + part); + + return __filemap_get_folio(mapping, index, fgp_flags, mapping_gfp_mask(mapping)); }