Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31;
From:   Benjamin Coddington <bcodding@redhat.com>
To:     Geert Uytterhoeven <geert+renesas@glider.be>
Cc:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>,
        Chuck Lever <chuck.lever@oracle.com>,
        Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
        Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
        linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v3 2/2] sunrpc: Use no_printk() in dfprintk*()
 dummies
Date:   Mon, 16 Oct 2023 17:16:03 -0400
Message-ID: <AF5F4E44-08DE-4F4F-9BA0-3D7FC26554EF@redhat.com>
In-Reply-To: <180fd042261dcd4243fad90660b114b8f0a78dcd.1697460614.git.geert+renesas@glider.be>
References: <cover.1697460614.git.geert+renesas@glider.be>
 <180fd042261dcd4243fad90660b114b8f0a78dcd.1697460614.git.geert+renesas@glider.be>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 16 Oct 2023, at 9:09, Geert Uytterhoeven wrote:

> When building NFS with W=3D1 and CONFIG_WERROR=3Dy, but
> CONFIG_SUNRPC_DEBUG=3Dn:
>
>     fs/nfs/nfs4proc.c: In function =E2=80=98nfs4_proc_create_session=E2=
=80=99:
>     fs/nfs/nfs4proc.c:9276:19: error: variable =E2=80=98ptr=E2=80=99 se=
t but not used [-Werror=3Dunused-but-set-variable]
>      9276 |         unsigned *ptr;
> 	  |                   ^~~
>       CC      fs/nfs/callback.o
>     fs/nfs/callback.c: In function =E2=80=98nfs41_callback_svc=E2=80=99=
:
>     fs/nfs/callback.c:98:13: error: variable =E2=80=98error=E2=80=99 se=
t but not used [-Werror=3Dunused-but-set-variable]
>        98 |         int error;
> 	  |             ^~~~~
>       CC      fs/nfs/flexfilelayout/flexfilelayout.o
>     fs/nfs/flexfilelayout/flexfilelayout.c: In function =E2=80=98ff_lay=
out_io_track_ds_error=E2=80=99:
>     fs/nfs/flexfilelayout/flexfilelayout.c:1230:13: error: variable =E2=
=80=98err=E2=80=99 set but not used [-Werror=3Dunused-but-set-variable]
>      1230 |         int err;
> 	  |             ^~~
>       CC      fs/nfs/flexfilelayout/flexfilelayoutdev.o
>     fs/nfs/flexfilelayout/flexfilelayoutdev.c: In function =E2=80=98nfs=
4_ff_alloc_deviceid_node=E2=80=99:
>     fs/nfs/flexfilelayout/flexfilelayoutdev.c:55:16: error: variable =E2=
=80=98ret=E2=80=99 set but not used [-Werror=3Dunused-but-set-variable]
>        55 |         int i, ret =3D -ENOMEM;
> 	  |                ^~~
>
> All these are due to variables that are set unconditionally, but are
> used only when debugging is enabled.
>
> Fix this by changing the dfprintk*() dummy macros from empty loops to
> calls to the no_printk() helper.  This informs the compiler that the
> passed debug parameters are actually used, and enables format specifier=

> checking as a bonus.
>
> This requires removing the protection by CONFIG_SUNRPC_DEBUG of the
> declaration of nlmdbg_cookie2a() in fs/lockd/svclock.c, as its referenc=
e
> is now visible to the compiler, but optimized away.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> Acked-by: Jeff Layton <jlayton@kernel.org>

Reviewed-by: Benjamin Coddington <bcodding@redhat.com>

Ben