Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2;
Date:   Wed, 18 Oct 2023 11:36:29 -0400
From:   Chuck Lever <chuck.lever@oracle.com>
To:     Amir Goldstein <amir73il@gmail.com>
Cc:     Jan Kara <jack@suse.cz>, Jeff Layton <jlayton@kernel.org>,
        Christian Brauner <brauner@kernel.org>,
        linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
        David Sterba <dsterba@suse.com>,
        Luis de Bethencourt <luisbg@kernel.org>,
        Salah Triki <salah.triki@gmail.com>,
        Gao Xiang <xiang@kernel.org>, Chao Yu <chao@kernel.org>,
        Theodore Ts'o <tytso@mit.edu>,
        Andreas Dilger <adilger.kernel@dilger.ca>,
        Jaegeuk Kim <jaegeuk@kernel.org>,
        OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>,
        Dave Kleikamp <shaggy@kernel.org>,
        David Woodhouse <dwmw2@infradead.org>,
        Richard Weinberger <richard@nod.at>,
        Anton Altaparmakov <anton@tuxera.com>,
        Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
        Steve French <sfrench@samba.org>,
        Phillip Lougher <phillip@squashfs.org.uk>,
        Evgeniy Dushistov <dushistov@mail.ru>
Subject: Re: [PATCH 3/5] exportfs: make ->encode_fh() a mandatory method for
 NFS export
Message-ID: <ZS/7fQWxuwaUIt/O@tissot.1015granger.net>
References: <20231018100000.2453965-1-amir73il@gmail.com>
 <20231018100000.2453965-4-amir73il@gmail.com>
 <ZS/3UfX/+hH6xKMn@tissot.1015granger.net>
 <CAOQ4uxj4CQmVKvmLg0UdNJWZ14Dp6SjJUvwqFdO3u9--M4dH6g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAOQ4uxj4CQmVKvmLg0UdNJWZ14Dp6SjJUvwqFdO3u9--M4dH6g@mail.gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TTFYc1luYmZmb096bEtob3FlRFFud2MycTZGcndFYmdodW5KY1RkSTZVNWF6?=
 =?utf-8?B?dnVyOGRDZTJoblA4eFRlRTVPU0paZkVoa1doYkkwbVFLcGtqMHFkSDJOQjk4?=
 =?utf-8?B?U3F0RW40MG9WbFpBMG9POTBFTjRCZDZ2bkdUTDU2NWJjOGZZVUdOMmtOOHlh?=
 =?utf-8?B?QXoyMW1RSFU1MGozQTBvcmtvcUEyaElkOTE0cGFvTDlnQUhqRUFaMG9oK2lz?=
 =?utf-8?B?OS9xYm9vREZRNEpFbEFPUEFKZWJlaU00MGsrR3UzRzJ1Z1pjclJmOGQ0dXZk?=
 =?utf-8?B?b1JWdmFpdXVkWExEWWU2dkhseENSR0JwRkVZeW94R04rSFpyVEJuRkVDSnIv?=
 =?utf-8?B?TXF4OVQ0K0lTZWxxVng4d0dnbE9VSVhNblphUWN4dXRkdU1hV0Y2emdVRHJ5?=
 =?utf-8?B?bjYzb3d2czBCeUJOZldHSU5EY1hKQVZoc0dSNENIbXExZlZxOXhrczBtbkp5?=
 =?utf-8?B?VGwrZHQ5a2ZYcXhEb0ROSWxiL0pERzZKR1U1UkNIU0IvSGVMQnA5b2FwYmZ1?=
 =?utf-8?B?TWRqQjJ0OG1aUHhoSzVDb21UR2RRQ3FUZW1GMHY5YmdQeHYzaTVYUEJOL1pI?=
 =?utf-8?B?SzQvcmJEbnF5TWpUOENaQW1rODJNclVUSG1GSDRYVVFpandtL3VrRVBXeWI0?=
 =?utf-8?B?UUhOUENoME1GV2JXOUVyZGpwdHZ3SVRTNWQvV1BZVzBOYzI0eFk4dUpTZW13?=
 =?utf-8?B?MVpxYWdtZGZtYnNSdmtDL1BqYkt4NlFESHdtRjF3dnFWTXhoWGtEU3JrRHVL?=
 =?utf-8?B?LzNwMlp6VmFSQ0ZQSEcxRlVpVUpLQ09pUnA1M0RIWHJhcXBKRjNEUk1Wdnpa?=
 =?utf-8?B?ZlhPckNmZlQ0KzEvUGdSNW4rTFJHTGtFUmROZFlFQldPbWJOZ1dMUFFrQlMx?=
 =?utf-8?B?MUtZbjcxLzl2VWZHUkg0QjlKcGVMeHQzWU5adFVMS0RxbjcwOW0rWThBYTdv?=
 =?utf-8?B?bVl1VG1OaDBDNUpRTWhjMmVKWkprUHlHaVZ1UFBhTkZPS3FIREV1WU9ZQ05D?=
 =?utf-8?B?UEVuaFc4NC9VV04vNitzZW9BT3pEL05rZ05UL0tOSTNTblo1ZWxzbFBFY2VW?=
 =?utf-8?B?YVVGUjhrdmlacm9FVjBvZ3V1SFpPbUR5b0FFMWRQSURGcjRENkxURVVwdDhE?=
 =?utf-8?B?LzZ5M1czL3pwK2llcDY1QmRMVS9VWU9TY0NFOUZvQ2dxeVFBN0QwNmVZRXZz?=
 =?utf-8?B?UU5ORGVaMml0UUU5MkNNc2hqdkIrcXR4TE5Dd2ZaM0tpbEZKeEZCbDFsakhl?=
 =?utf-8?B?UmU2WnFpbjQ0eXNvYTJjU3RLM2dkWC9IdzRrT2NEVndBMWo1M3haUlRUOUZu?=
 =?utf-8?B?VS9icW5DK01VVVdUbytSYnljQy9XU0NtTnNrL0p2UENkeUV5cjZCd1JHbzRQ?=
 =?utf-8?B?SDBpeE5ZTlg2YlkrL2FVTWZuTnd1cnhkSGFZQ2xUTmhVb0ZTNUJUY0x0SzNQ?=
 =?utf-8?B?OEpaaTlGMCtvMittN05nUTdWeFdCU0lrSVc3Kzl5S2lUL0x6cnNBVHdmc1FC?=
 =?utf-8?B?MEJuNHl0L0c3V0VWSjNCTEVOdU1FU0RodEIxcGZjVkkwOGlXWEsxVGNmRHA5?=
 =?utf-8?B?L0VOaWNpSGxWclg5NUtFT0lKL2RLR2dmRUlaMEtqVVJzRVNWaCtrQjg0eU1Y?=
 =?utf-8?B?U0EvWGdSM1VIdVNwK1RzTEwwVUlQdTRBMWJzNlhyb2JpQ3lkSk9FTGpPZDVE?=
 =?utf-8?B?bzJNalc0NytCRUVWd0lOeXplenE5WVRObmdrbHY4RVY0T09hZDRBbkV4TWs5?=
 =?utf-8?B?NlZsUkx4VnNyT3o1YVBpaUhWa2hsQmova0d1RkUyMkI5MGpXd2dwaVhkL0hk?=
 =?utf-8?B?blpNaVp4cUtPaUVOODBuaHlaV1BQSGhMTzFPTkNHM1hVenRwZ0wzWXhmNysr?=
 =?utf-8?B?VWhmK2IxN2ptV25NaDdnODVBMWFrdmRNd2NTdlZtY0ZTRHFkS2dOZXV6N0N6?=
 =?utf-8?B?SmR4S21YK3RoTFQzOFY0R0ZtWUozZTF5WC9NM21TN3NNRGsxN1V0Q3hBNExV?=
 =?utf-8?B?R1hrWVhkdERwWWR3YmR2WDFPNkxFc2ZrKzg1d281Rk1pckVGUytVdE9rZ3p1?=
 =?utf-8?B?TS9jRUZXVldPeXlDL21BRXd2WUhXNUpJcjVsRU9ZT05oeWJLYXVXWmV3ZWFB?=
 =?utf-8?B?Q0dNZFppN1ZNalk2RmtoSWhOOHdab0lxSXZJcy9YbEovUjlhMVU4cVlaeEVp?=
 =?utf-8?B?WEE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?utf-8?B?aEg4OEhOY1lycXB0QkJIeGs5eThEU0hQWUowRWF2dFNvQXBUdVJ0Uld5aTFS?=
 =?utf-8?B?NzlmU3B6c1JlMEZTTGJqZml1cFdndEpUdUZ2RjJKOXJDczdlRzlxSzRTN3J6?=
 =?utf-8?B?VWlIaUIyK09zVWIyZGlrbGtZc1JwYk52aE5jdzJ0VUhOVjZaTCs3K25LVUYx?=
 =?utf-8?B?L3JGaGJwVU5nbkRtTTJOcldUcVZxbHJsZHRNbXlvWmJrT01ZYnNtaFNmM1B1?=
 =?utf-8?B?SUg1R2dLbkNJU1NVWWFhL2NSVXp2dDZwL2FWRHZRRW5EVW1KcSt1U2h4K2dB?=
 =?utf-8?B?cDJweVczd3pxQTFFWnBKdjYydlhKQ1VwZlZwTXlXa3h4MkhmYXNzekVqbW10?=
 =?utf-8?B?bkhVODJlMSt0NEZYanQyVUJjaWhqMmplUGVVWmRRZU1kNnlnd2JqVmh5NldF?=
 =?utf-8?B?c3hvWmswbzU0YU9Bb21nZGZjSkIxdDZPY1AvS2V0MTdMbThTV052dUpieE1o?=
 =?utf-8?B?Q3duWllOeEh1YzRzUWo3Ti96V2Fhc0hhSnlRd3kzQ0pLSm5VRHArU3NzcFZE?=
 =?utf-8?B?NHc1ZzJXQ0MrLzdEbFN0LzdtWDQ1KzNzMkoxaWpIUmVMQkxJUGlpd0MvRis2?=
 =?utf-8?B?QXd4YlhueWRGNUJZbXZhSEM1ZWpveFVCMVJFaUJSeW8ydnR3RDFPeENZT3Jt?=
 =?utf-8?B?Rm9FU2ppbTd4b0crSm1KSmhhRlpLL2ZDKzFrYkF5R2JSL3dSTGlBelFDbE1i?=
 =?utf-8?B?dlp1QlJvb1p3M1h3aVptWDdyUnFlemtRbWsvYTljNWhSYnczdUR4OWtxRnJw?=
 =?utf-8?B?TVgwRk4rMHpPUG1GanBCQ2ltMThPYnJsQ0drdEcrOHBFdHB5bWU2ZGxLbzhJ?=
 =?utf-8?B?VXpWMGx2c0VhQUJhNzBya1EwS0RVV2NtSHRqaWFiNGlCbzBHMXBwNHpSM2Vt?=
 =?utf-8?B?Smo4R1N0aVNpeUZPR215TDV6eDdZYitSOFp2elpjeHFoWEV0UW9NV2xPNVNL?=
 =?utf-8?B?ODVDOFhkZm1uWDQyOHpncEpMZWIrZFJlU1k1QjFuVXViR2pmWGd5dXhJNW9U?=
 =?utf-8?B?NEhFS3JaTituNWdOTHpLRlR3bkNVVElNelZZcmNGaUZzNG93b3ZrNm1WVVlK?=
 =?utf-8?B?OGNib2U5MkY4d1lDUVJGOWt3MWVjcjYveVd4VHRmMmxlQVYyMktWVk9xTTRS?=
 =?utf-8?B?MVNVVXhDSS8rYUtjcTJHUXhMMHU3b3NCcHRQWmI1TUNERVpubWU5MTVQV09x?=
 =?utf-8?B?QnN3MlFYYnpzNEt5eVQxYlhjMnpvSUI1MTNFUkJsL3liTlphMWxYQ3BQblBr?=
 =?utf-8?B?cGlENkdBN2J1L0lyWDYwZjRySUhXMmdIZTliR2h6aEVWcjYyMTB4RFJ4NXRD?=
 =?utf-8?B?bi9OLzFHRk81S2dPUk00Ryt5SCtsTmJvK3k0QmFwV2FNZG9xQnVWT0N6eE5B?=
 =?utf-8?B?REg2NENONDFPcFl5dW1XTWVxUTMxZTZXTHVBa0FyRXA4SGl4VldqMDduV2F5?=
 =?utf-8?B?YmxhUzJUWFZMVjBBL3BIRXNyeTh5NVhkWWlGMHFxNGp1Y1ZpMU9rODhhTy96?=
 =?utf-8?B?TUhoc0tmL2t1U29va3RhK1JpN0F0Qmg2MENScmhZcnJIclVETEFlTVdZbFBV?=
 =?utf-8?Q?Zoo8ZSFSQ1UO7sqMLU2vbaoRm+1iaFc4gm9L9yAKJm/eO/?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75c90037-ccc0-4708-1a1b-08dbcff001a5
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2023 15:36:33.1505
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: RCSP1n41hxTc8OaUKuXPz1GRDJSntOouIGBXyilL8y8Ck9jueoCTWK+Peh8uV87ny4dhNLDS8yyhRKxcHxK+FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB7534
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-18_14,2023-10-18_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxscore=0 phishscore=0
 malwarescore=0 suspectscore=0 mlxlogscore=999 spamscore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000
 definitions=main-2310180126
X-Proofpoint-ORIG-GUID: JmjlFgoX4GgM075qca3tVH_Y2lxGo21r
X-Proofpoint-GUID: JmjlFgoX4GgM075qca3tVH_Y2lxGo21r
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 18 Oct 2023 08:37:23 -0700 (PDT)

On Wed, Oct 18, 2023 at 06:26:07PM +0300, Amir Goldstein wrote:
> On Wed, Oct 18, 2023 at 6:18 PM Chuck Lever <chuck.lever@oracle.com> wrote:
> >
> > On Wed, Oct 18, 2023 at 12:59:58PM +0300, Amir Goldstein wrote:
> > > export_operations ->encode_fh() no longer has a default implementation to
> > > encode FILEID_INO32_GEN* file handles.
> > >
> > > Rename the default helper for encoding FILEID_INO32_GEN* file handles to
> > > generic_encode_ino32_fh() and convert the filesystems that used the
> > > default implementation to use the generic helper explicitly.
> > >
> > > This is a step towards allowing filesystems to encode non-decodeable file
> > > handles for fanotify without having to implement any export_operations.
> > >
> > > Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> > > ---
> [...]
> 
> > > diff --git a/include/linux/exportfs.h b/include/linux/exportfs.h
> > > index 5b3c9f30b422..6b6e01321405 100644
> > > --- a/include/linux/exportfs.h
> > > +++ b/include/linux/exportfs.h
> > > @@ -235,7 +235,7 @@ extern int exportfs_encode_fh(struct dentry *dentry, struct fid *fid,
> > >
> > >  static inline bool exportfs_can_encode_fid(const struct export_operations *nop)
> > >  {
> > > -     return nop;
> > > +     return nop && nop->encode_fh;
> >
> > The ->encode_fh() method returns an integer type, not a boolean. It
> > would be more clear if this were written
> >
> >         return nop && (nop->encode_fh != FILEID_ROOT);
> >
> > (I'm just guessing at what you might have intended).
> >
> 
> You must be pre-coffee ;)

More like pre-lunch.


> This checks if the method exists, it doesn't invoke the method.

OK, I was confused because I thought you were filling in all the
spots where the method doesn't already exist. My brain lept to
the conclusion that this is therefore calling the method, but I
failed to notice there are no call arguments.

I might understand it now. :-)

Since you want this series to go through the vfs tree:

Acked-by: Chuck Lever <chuck.lever@oracle.com>


-- 
Chuck Lever