Received: by 2002:a05:7412:d8a:b0:e2:908c:2ebd with SMTP id b10csp4028924rdg; Wed, 18 Oct 2023 12:43:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHg/DQtmj+SXMfgHofjJ2NWZyIRut3Y46yy2SkXBIkn7a6QOHEJN1zMqPGKMvI411l5LhrR X-Received: by 2002:a17:903:41d0:b0:1c9:deb8:bdc5 with SMTP id u16-20020a17090341d000b001c9deb8bdc5mr372266ple.34.1697658193931; Wed, 18 Oct 2023 12:43:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697658193; cv=none; d=google.com; s=arc-20160816; b=oJWstbJafsMOmhyfmuuyLEUvluqLsgD2qLjyR+L4nvq+6n8Y48LJEPo94SgfxIcgzX MhCZMsR9mUYoLHVL0xDFiAS5a3UJ4CjXAdCNXxiy27j1geFzlESOf23DUZaKMwcUsGIF ST0kpOyqruaXjRSVDGGlS/DCKNUvD3Vd/r8i5Kq7NEokHkqNIPNstfaLIEWwMxX90y3I iz00pTOnu6Gb5trecGFwmL5ZfR281icG6EpzDJwHecNYM1F67zn8XXhsXX4L2kiSSw2v Lr/vxoPKH5Oaw6S1dabxvmMX+Jmw65LxBv+kpjU2ihEnK9SJkKoHe9D2fjRn78rYFeDr Hrvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IkXC7VDaoQK3RUozAAkGDOpsoWCmtz0VTHzkQBX3IBg=; fh=7zj0PUbGjAr7mtzGgJPghHABWUHHV5D29XoQYa5zYU0=; b=Qe9wMH3uC56576le1e2FDKWlQuH3NtjIgdAItWw3GTd+ZiXlqEeDC14uIu7wirWKow n6xyfUEOLCmI1P9OCTC7O5DAF7EcUP3MOC6nlC3ujB6g/Ma9LRbkq5rx31+x7C+keqCY quyiqeOuWTv2QINwR2ICqcxjWAOFY20AyRa4052NUgn8k5crO/MRs6iEagk6J+8jldFN C67Jwt+pokd5ENYsW69QpES0XQN19y0UuYKlW/DW5U42nGgOi03+7if5FaO3vEUuNuxu tkg3z8IxxfeigGrewpXUJ2hGSkhKUzwjYEFipSzcCtRq4O+8Lb665aidD3+4mlqmXf6H pS3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=glDlVjy2; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id g24-20020a1709029f9800b001ca33ce21fesi538414plq.58.2023.10.18.12.42.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 12:43:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=glDlVjy2; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 2774581049BC; Wed, 18 Oct 2023 12:42:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231390AbjJRTmo (ORCPT + 99 others); Wed, 18 Oct 2023 15:42:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39548 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231653AbjJRTmn (ORCPT ); Wed, 18 Oct 2023 15:42:43 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3579F114 for ; Wed, 18 Oct 2023 12:41:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697658114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IkXC7VDaoQK3RUozAAkGDOpsoWCmtz0VTHzkQBX3IBg=; b=glDlVjy2E+xv4AP/axZmCILMD60OjknO6Hmn5yE1Q9f1BeqJ2cfbDszYf1Y6xb3paXBHEp ib9Y/OxFbJqyOg3zv0Ah9Bxglcejf8lQiadZXmBxqJR5n8+DDwKaqErQ1iHblo60ihh2pZ 3GswMw/lexk1SbP/mwMKcKRGDk/JeV0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-316-_2QbrvH6N5uQX1yWoB85nA-1; Wed, 18 Oct 2023 15:41:50 -0400 X-MC-Unique: _2QbrvH6N5uQX1yWoB85nA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B54ED10201FE; Wed, 18 Oct 2023 19:41:49 +0000 (UTC) Received: from [192.168.37.1] (unknown [10.22.48.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 18E05492BFA; Wed, 18 Oct 2023 19:41:48 +0000 (UTC) From: Benjamin Coddington To: Anna Schumaker Cc: Cedric Blancher , Linux NFS Mailing List Subject: Re: NFSv4.2: READ_PLUS - when safe to use? Date: Wed, 18 Oct 2023 15:41:47 -0400 Message-ID: In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.10 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Wed, 18 Oct 2023 12:42:49 -0700 (PDT) On 18 Oct 2023, at 15:32, Anna Schumaker wrote: > Hi Ced, > > On Sat, Oct 14, 2023 at 9:08 AM Cedric Blancher > wrote: >> >> Good afternoon! >> >> Since which kernel versions (NFS server, NFS client) is NFSv4.2 >> READ_PLUS safely usable? > > Linux 6.2 for the server side and 6.6 for the client. > >> >> Also, could you make this a mount option, so people can turn this >> on/off per mount, instead of using a kernel build option for this? > > The eventual plan is to remove the kernel build option entirely. We > probably won't do a mount option, and just have it enabled by default > when using NFS v4.2. Anna, I'm still planning on either re-sending the patch you wrote to enable/disable optional features per-mount, or re-work it to make it file-per-feature as the sysfs creators intended. We need the option to toggle client's default per-server or per-mount. Ben