Received: by 2002:a05:7412:251c:b0:e2:908c:2ebd with SMTP id w28csp2528392rda; Wed, 25 Oct 2023 05:36:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEcRErUR0XE2Z30nhjcG2NkeaKiVCOjbyuY7n/lrLdvLEclUWRRWO8jXCtmpKXG7tcOBvuv X-Received: by 2002:a05:690c:d85:b0:5ad:d6b5:822a with SMTP id da5-20020a05690c0d8500b005add6b5822amr3434847ywb.21.1698237404134; Wed, 25 Oct 2023 05:36:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698237404; cv=none; d=google.com; s=arc-20160816; b=SEQ6Dgq2+XzBpQ2PHbPIgsGjXT2/4R9MDSzH8WLVKqh/ubSwOXef0O/fJTLkncZgwJ 5bZ+9DFkXBFRav9JHUekEGzV62bbaQoAwunifljHMhl/eVzlEFEGYCBIuOFj5axtQ8aE NB4BZqQmh/Ij9AECON3KAdFPd6PnPYUWjSs9vgIoVacaKeT7TgfkgeRAqS8il1YuLdqB 1W8qcVvKZtI/ka/ZZgvxXKEK2xE+59O5etWAZum871Zn27YERV0d3PMjOJekvGnqGMxW ZqfDlos+EENCOjO5dX4K5+NDHNM07uMryaBnawwtJsh80tBynUPY76+kkOzuzoHCsWwj 9Wpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=aZpHifrU2s5Zl3Ak7+hsd8JgtA2mkf3sTAvVq9SRCPk=; fh=YB/uXhonq8Qy+beGXYaNmXaHQAOouNCJbi/U8zEtxqI=; b=Gc+Wuc5C3bbMmxXdEi/k4ynoybvC4LMqOyPObOfTSO47/WqQC6yLqMhieOrPRECWy2 OtPlWjPD8msvePUnMLLbHbR7F+htFNXfqfi3keMqbvku/L4zfirjXsYW7VWcBukuTngq PmcYbWarMW4Ym6JK+bhePCFtvD/tFpUpwfN4LtH9ArQkE5Cx84rRlUJEEiIYCkN/hrgl AuR1nsfhHVTXEQXjzkG0ma9PMfLZBJxHIAxGK1OQqjQUdk2kjm6OfHfbN79Ldw6dWINs FwGWVs/xWyNIbk9JPUXHNOLnKjJbVEB943SQv/7qJKStCTlw69VU96OkxIx79EjNrSjc 5KYg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g3kqYUL6; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from pete.vger.email (pete.vger.email. [23.128.96.36]) by mx.google.com with ESMTPS id a9-20020a81bb49000000b005a7f27f8f45si10588244ywl.528.2023.10.25.05.36.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 05:36:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=g3kqYUL6; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id 7CAF78022B20; Wed, 25 Oct 2023 05:36:40 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344102AbjJYMgg (ORCPT + 99 others); Wed, 25 Oct 2023 08:36:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234846AbjJYMge (ORCPT ); Wed, 25 Oct 2023 08:36:34 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7718E13D for ; Wed, 25 Oct 2023 05:35:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698237342; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aZpHifrU2s5Zl3Ak7+hsd8JgtA2mkf3sTAvVq9SRCPk=; b=g3kqYUL6KFUDBSAq5/4H9wCx+GYKyssyAey3k6VF8Q0EdczVm/biISICpVPNH977MLmQnE eQPJEGW7PD6M8HpMySClUT3mmJ8oQQvruhBm7AMLzrcGvVy/pHiePf4SJE52HvdegeU7Lh 2ghijiWNaS+G38qex9HxC7so08J+MxM= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-227-margzujmNWm9iKyqDIlRyQ-1; Wed, 25 Oct 2023 08:35:38 -0400 X-MC-Unique: margzujmNWm9iKyqDIlRyQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86848857CF6; Wed, 25 Oct 2023 12:35:37 +0000 (UTC) Received: from [100.85.132.103] (unknown [10.22.48.7]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 992CF1C060AE; Wed, 25 Oct 2023 12:35:34 +0000 (UTC) From: Benjamin Coddington To: Christophe JAILLET Cc: chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com, trond.myklebust@hammerspace.com, anna@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH net v2] net: sunrpc: Fix an off by one in rpc_sockaddr2uaddr() Date: Wed, 25 Oct 2023 08:35:33 -0400 Message-ID: <3860625A-B435-45A7-BC53-883A50539510@redhat.com> In-Reply-To: <31b27c8e54f131b7eabcbd78573f0b5bfe380d8c.1698184674.git.christophe.jaillet@wanadoo.fr> References: <31b27c8e54f131b7eabcbd78573f0b5bfe380d8c.1698184674.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Wed, 25 Oct 2023 05:36:40 -0700 (PDT) On 24 Oct 2023, at 17:58, Christophe JAILLET wrote: > The intent is to check if the strings' are truncated or not. So, >= should > be used instead of >, because strlcat() and snprintf() return the length of > the output, excluding the trailing NULL. > > Fixes: a02d69261134 ("SUNRPC: Provide functions for managing universal addresses") > Signed-off-by: Christophe JAILLET > --- > v2: Fix cut'n'paste typo in subject > Add net in [PATCH...] > --- Reviewed-by: Benjamin Coddington Ben