Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35;
Message-ID: <tencent_E6816C9AF53E61BA5E0A313BBE5E1D19B00A@qq.com>
From:   Zhuohao Bai <zhuohao_bai@foxmail.com>
To:     steved@redhat.com
Cc:     falcon@tinylab.org, forrestniu@foxmail.com, baizhh21@lzu.edu.cn,
        tanyuan@tinylab.org, linux-nfs@vger.kernel.org,
        libtirpc-devel@lists.sourceforge.net,
        Zhuohao Bai <zhuohao_bai@foxmail.com>
Subject: [RFC PATCH] _rpc_dtablesize: Decrease the value of size.
Date:   Thu, 26 Oct 2023 00:27:16 +0800
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

In the client code, the function _rpc_dtablesize() is used to determine the memory allocation for the __svc_xports array.

However, some operating systems (including the recent Manjaro OS) can have _SC_OPEN_MAX values as high as 1073741816, which can cause the __svc_xports array to become too large. This results in the process being killed.

There is a limit to the maximum number of files. To avoid this problem, a possible solution is to set the size to the lesser of 1024 and this value to ensure that the array space for open files is not too large, thus preventing the process from terminating.

Signed-off-by: Zhuohao Bai <zhuohao_bai@foxmail.com>
---
 src/rpc_dtablesize.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/rpc_dtablesize.c b/src/rpc_dtablesize.c
index bce97e8..2027af4 100644
--- a/src/rpc_dtablesize.c
+++ b/src/rpc_dtablesize.c
@@ -41,7 +41,7 @@ _rpc_dtablesize(void)
 	static int size;
 
 	if (size == 0) {
-		size = sysconf(_SC_OPEN_MAX);
+		size = min(1024, sysconf(_SC_OPEN_MAX));
 	}
 	return (size);
 }
-- 
2.25.1