Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp938342rdh; Thu, 26 Oct 2023 23:03:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFXKRgAt4Usato/jlqnUc9ORwXuRd7mVKwh1w2KJjYhohzZ21btUMN6NIWQK52ACg1gwutX X-Received: by 2002:a81:b101:0:b0:5a8:1d18:a16 with SMTP id p1-20020a81b101000000b005a81d180a16mr1774611ywh.36.1698386621097; Thu, 26 Oct 2023 23:03:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698386621; cv=none; d=google.com; s=arc-20160816; b=SRolWO6fHoWn2/wPEwdj7BXocSxR1L6Lpiby7u2IPIWLkVcDTlP6hjdKfF5kECdX2W JfOqE+I7nLnqP5rHJYz1P6JeAozK5LfYpHuJgdmbzda9m23AyRFwkW1y2HX/KkTQZfOc Y3PfWMkqGzUR/OEKgCQI9tGUZXVoviHYkx6hO8EsLqCXH3uLyggn9M/wwrPoGObsnOmq keospxTPTVpjnMS6PNdrMMKNyfq48xq756UBpIl8Jl8BrPKMCV/lpJotJjgipAxHYBUO +MEap4b2DHN+0Slgd6/IU5f/u7SEFzrhZO4LAmvg4Gs1mnBIj9TQa7Ja5R03LiboY2PH RoxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NLbGPcvkczQ3j5pZtH5UcuT+QHH7Vu/3J6gRRU85itI=; fh=Gry5VYGQ5UExURJMQy0tdZZMKd4bcyCLy5bKtKvnHfo=; b=h9pogCLGY9GpYKofojcqH/pMzH9hrUuQQaP6MVDFPgyCf9V53jxPBD6dx44hsTlOKW U+LOcGe440qcoilY5EMfCK6me5oNWheun5qwl9mzE//0cI/3FqjM9g6MTFlz+Y6nkQU/ zUvI9xqyxaZ77nFRihtfRKgfaTV0n3EVQNx1Nnr1rBsbIEjyKO+9TIKDwE/YIn2fiPGq OhqikHQY5hJwSS3TBqk4tyIMVFrKCukkDplCNuiU/8w1bhMXH60Q9tnuvN/KeL1ym1P8 KHyUjtEFLiu/rRiLHjsXfUuGBynmo6FeoY0Wtsq0qQw4g+ToO6osZfgIZ0uNqBSomkf0 jMpA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hq39YTN1; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id m2-20020a817102000000b0059f7fc7d457si1293879ywc.507.2023.10.26.23.03.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 23:03:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hq39YTN1; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id ED21B82662DD; Thu, 26 Oct 2023 23:03:36 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230164AbjJ0GDg (ORCPT + 99 others); Fri, 27 Oct 2023 02:03:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229590AbjJ0GDf (ORCPT ); Fri, 27 Oct 2023 02:03:35 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 870F41A7; Thu, 26 Oct 2023 23:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NLbGPcvkczQ3j5pZtH5UcuT+QHH7Vu/3J6gRRU85itI=; b=hq39YTN1A2iFBaVtfbiotTW1Tx 65uV8op85xWcd5AJj/UI16k6KidLDMjRqy8hmm5noz0LZS0JB2Wm58T6QVmau38L33X2csTuSeUlR 4j4CBybj0SeMClgw2JAdcRCFke40Dz86NXDGoRhCaayjhwXHqWNlCrcGAFWRCpiSZnR5muIHAVUl8 Hdbl+xVXc5Xcbvr5HegoGGx7e820Rl42wqH/BCL6xODX+VmQ1ge5jyGBriUNbdUnNAxM4HbeLUCP6 JsT4ER1Pni8ieL1hFZdSJjFLIrE+X0SwRNe1ht8sWmhClvsgmARMxMIlOXIpose9qNJziCtvEtlrA F3NlR93g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qwFwL-00FeFr-0O; Fri, 27 Oct 2023 06:03:25 +0000 Date: Thu, 26 Oct 2023 23:03:25 -0700 From: Christoph Hellwig To: Amir Goldstein Cc: Christian Brauner , Al Viro , Jan Kara , Jeff Layton , Chuck Lever , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, David Sterba , Luis de Bethencourt , Salah Triki , Gao Xiang , Chao Yu , Theodore Ts'o , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Dave Kleikamp , David Woodhouse , Richard Weinberger , Anton Altaparmakov , Konstantin Komarov , Steve French , Phillip Lougher , Evgeniy Dushistov Subject: Re: [PATCH v2 2/4] exportfs: make ->encode_fh() a mandatory method for NFS export Message-ID: References: <20231023180801.2953446-1-amir73il@gmail.com> <20231023180801.2953446-3-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023180801.2953446-3-amir73il@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 26 Oct 2023 23:03:37 -0700 (PDT) On Mon, Oct 23, 2023 at 09:07:59PM +0300, Amir Goldstein wrote: > export_operations ->encode_fh() no longer has a default implementation to > encode FILEID_INO32_GEN* file handles. This statement reads like a factual statement about the current tree. I'd suggest rewording it to make clear that you are changing the behavior so that the defaul goes away, and I'd also suggest to move it after the next paragraph.