Received: by 2002:a05:7412:a9a2:b0:e2:908c:2ebd with SMTP id o34csp939237rdh; Thu, 26 Oct 2023 23:05:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFK4cIpEr2Al+pWkFvp7zmJlBMSx1cDSf1kjV9BASNX2tNqw8Qr5eRdqCZXLQR6w3MJC7dR X-Received: by 2002:a0d:e684:0:b0:59b:533a:485f with SMTP id p126-20020a0de684000000b0059b533a485fmr1539856ywe.52.1698386723240; Thu, 26 Oct 2023 23:05:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698386723; cv=none; d=google.com; s=arc-20160816; b=J++IU4RiB/fJPuETS/fzHTckkWzvQ49xo8eZ9ZjV6TD7aIrfWqfBKaHSYHGlQFrZ2y uTINAgkEjyBxCnMYpbDhoq71FfG9Y/oPEihmpTUORpCWVh68hX6ILblJwyYEbtlA7coM l9PRHAkn1WEEPNjxkE52KWltngbVouh83+uipRfRjmiGTeqO66BYHLur5MD8oT7y5KYK veDaaVxauNUw3kJa4cKnNRFk2xIW2YlsCZUKwwHEb6d0niBCxeQRscO03XKfAHhZTlRx r8JaeeRmncfEYF3OmKmp0vrRsiFUI1IXi86P9MBRD+o///YYwuWVlNHXViZ2UJStu/JD ghsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oVbebL76c6pNB/fIpdsjTZraPC/lGT/ZH6e5WyTTbGc=; fh=6W5roiIoAxkkb7MFg5ReIe84/G4m2J+JmA4siFXxb6w=; b=Ue6qewd67jpzqJaQ2Ig0xlBoZptavOdg015xlXHRz9RTuEqWydqvOUTW78BDqnd89k gHEM45z51lufomyKM+0auEbTNaLWr2J5v+amMPjzu8WtLy/Fd81o0GOJrvCFoUO2rnAi rZuoivvsuoFzf/NdCB6yACvtMJqtDQPr0tyxJ6lLFavUOgn+PVobx3kjgmZ49uUzEJKI HAKF92BzHUWBpM43i4/sBUItdsYGO1c8tRNCxfIPXWTiBJW19JHzez+wgTXidPKP+haA Yi/Ao9wKlkwxEdc62Wle5GmuxgAm9I6ANdGzIHFRpvff3USNupCl5t7x0mIg4koxWqb6 o5mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=izdrcBPX; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id a13-20020a81bb4d000000b005929236946asi1453352ywl.181.2023.10.26.23.05.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 23:05:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=izdrcBPX; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 21300827FF8E; Thu, 26 Oct 2023 23:05:22 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229633AbjJ0GFM (ORCPT + 99 others); Fri, 27 Oct 2023 02:05:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbjJ0GFL (ORCPT ); Fri, 27 Oct 2023 02:05:11 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB8691A7; Thu, 26 Oct 2023 23:05:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oVbebL76c6pNB/fIpdsjTZraPC/lGT/ZH6e5WyTTbGc=; b=izdrcBPXER4dUIv+toGALj1awf G186Q6nv2yxki9Pa2jPQlfjIIQUqxFRMuaAkS64VBslZ+UXS3wUKNn4ik2WbLAIG9y94yfYB1G8mo GcygmEgelrnkuNmiw7sZiXpQ6KXpheSVT1AhU3SIh+ERI4AiPxg+2rZ4VgWxi3iEW/8Cbpxl8XVNY lREVOK8bhhcq5ZUqLrVBo9MSK0+vfVqgu1MJJ0cVUIrogbgpSz9P7v5qQPn2NUOvyC2kNm8DGPxWT GnjBW4rZPFZMcUSnpdRdOzhzr3fMjtIwXj0oCq0HTqTSioTqQ/Njzul+VT6etT11PyZtJ+S5WRm8H lijxp++Q==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1qwFxz-00FeMg-08; Fri, 27 Oct 2023 06:05:07 +0000 Date: Thu, 26 Oct 2023 23:05:07 -0700 From: Christoph Hellwig To: Amir Goldstein Cc: Christian Brauner , Al Viro , Jan Kara , Jeff Layton , Chuck Lever , linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: [PATCH v2 3/4] exportfs: define FILEID_INO64_GEN* file handle types Message-ID: References: <20231023180801.2953446-1-amir73il@gmail.com> <20231023180801.2953446-4-amir73il@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231023180801.2953446-4-amir73il@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 26 Oct 2023 23:05:22 -0700 (PDT) On Mon, Oct 23, 2023 at 09:08:00PM +0300, Amir Goldstein wrote: > Similar to the common FILEID_INO32* file handle types, define common > FILEID_INO64* file handle types. > > The type values of FILEID_INO64_GEN and FILEID_INO64_GEN_PARENT are the > values returned by fuse and xfs for 64bit ino encoded file handle types. Please actually switch xfs to fully use the helpers instead of duplicating the logic. Presumable the same for fuse, but for that I'd need to look at how it works for fuse right now and if there's not some subtle differences.