Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.9.0-alpha0-1048-g9229b632c5-fm-20231019.001-g9229b632
MIME-Version: 1.0
Message-Id: <4bef4861-d3eb-4d48-bd8f-b31a000c6904@app.fastmail.com>
In-Reply-To: <20231026204540.143217-1-amir73il@gmail.com>
References: <20231026204540.143217-1-amir73il@gmail.com>
Date:   Fri, 27 Oct 2023 08:59:13 +0200
From:   "Arnd Bergmann" <arnd@arndb.de>
To:     "Amir Goldstein" <amir73il@gmail.com>,
        "Christian Brauner" <brauner@kernel.org>
Cc:     "Jeff Layton" <jlayton@kernel.org>,
        "Chuck Lever" <chuck.lever@oracle.com>,
        linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org,
        "kernel test robot" <lkp@intel.com>
Subject: Re: [PATCH] fs: fix build error with CONFIG_EXPORTFS=m or not defined
Content-Type: text/plain
Precedence: bulk

On Thu, Oct 26, 2023, at 22:45, Amir Goldstein wrote:
> Many of the filesystems that call the generic exportfs helpers do not
> select the EXPORTFS config.
>
> Move generic_encode_ino32_fh() to libfs.c, same as generic_fh_to_*()
> to avoid having to fix all those config dependencies.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: 
> https://lore.kernel.org/oe-kbuild-all/202310262151.renqMvme-lkp@intel.com/
> Fixes: dfaf653dc415 ("exportfs: make ->encode_fh() a mandatory method 
> for NFS export")
> Suggested-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Amir Goldstein <amir73il@gmail.com>
> ---
>
> Christian,
>
> Soaking f_fsid in linux-next started to bring goodies.
> Please feel free to apply the fix as is or squash it.

I just confirmed that this fixes all the build regressions I
see with your series, as expected, thanks for the fix

Tested-by: Arnd Bergmann <arnd@arndb.de>