Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4;
Message-ID: <tencent_096F0EE6FFE508B3DA2BF89110DBC7E65506@qq.com>
From:   Zhuohao Bai <zhuohao_bai@foxmail.com>
To:     bcodding@redhat.com
Cc:     baizhh21@lzu.edu.cn, falcon@tinylab.org, forrestniu@foxmail.com,
        libtirpc-devel@lists.sourceforge.net, linux-nfs@vger.kernel.org,
        steved@redhat.com, tanyuan@tinylab.org, zhuohao_bai@foxmail.com
Subject: Re: [RFC PATCH] _rpc_dtablesize: Decrease the value of size.
Date:   Fri, 27 Oct 2023 17:46:38 +0800
In-Reply-To: <EAA0AA43-7CAA-4D74-9DD0-4CC738D71D47@redhat.com>
References: <EAA0AA43-7CAA-4D74-9DD0-4CC738D71D47@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 26 Oct 2023, at 09:08, Benjamin Coddington wrote:

> This issue has already been addressed by several users of rpc_dtablesize(), and they typically follow this pattern:
>
>     setsize = _rpc_dtablesize();
>     if (setsize > FD_SETSIZE)
>         setsize = FD_SETSIZE;
>
> Does it make sense to attempt a universal fix, and should we consider streamlining this approach for all users?

I apologize for not initially recognizing that some users have already dealt with this issue. Nevertheless, I believe it's essential to modify the _rpc_dtablesize() function as follows:

        if (size == 0) {
                size = sysconf(_SC_OPEN_MAX);
                if (size > FD_SETSIZE)
                        size = FD_SETSIZE;
        }

I will work on cleaning up the existing code in the next version.