Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Neil Brown <neilb@suse.de>
CC:     Jeff Layton <jlayton@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Olga Kornievskaia <kolga@netapp.com>,
        Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 6/6] nfsd: allow delegation state ids to be revoked and
 then freed
Thread-Topic: [PATCH 6/6] nfsd: allow delegation state ids to be revoked and
 then freed
Thread-Index: AQHaDF75bEKrShy72kWA52GSBv2SfLBkuEKA
Date:   Wed, 1 Nov 2023 02:10:03 +0000
Message-ID: <4C3DBAFF-4C83-4DB4-A6C6-D9C4387BF1F4@oracle.com>
References: <20231101010049.27315-1-neilb@suse.de>
 <20231101010049.27315-7-neilb@suse.de>
In-Reply-To: <20231101010049.27315-7-neilb@suse.de>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?RUYEhMCnEJr8ATZ2swXMWJCe7F/ODgI2APk6vw9OPxJs7b1lRrLmMnJX4yLN?=
 =?us-ascii?Q?yBxr5S9jKT3Tj6Vbnob3Y+I1Eg9LOh9G+pD0E2iwVw9/5Z1wzQ4ONJHNSPVV?=
 =?us-ascii?Q?LmBqe1WQ+PYxDIT35eRYOr2LZZMaTSVgYClN2byhs6PYs46+eu758NQCcCPv?=
 =?us-ascii?Q?xpBnOV2uj0p/EH1DTc110CuIcaRqtf6HXFKP0Jhm6IlrbWZx3P1xy3PxeYL9?=
 =?us-ascii?Q?BTkQSt8t7wFsHEpLlkV3vsO1170NwAfQ+4bdniV91Ebb/XpxOb1XEdOYKcHE?=
 =?us-ascii?Q?DrMshxsPs/w+KmEvB4x77535zDCKvI6RNKLc32l9tq1reUh9TCSJeLtuBJ0T?=
 =?us-ascii?Q?tE5S8/sXcwz9Wugoi9o4+keWZMjDRfTViRvXcKuSw48u+bf2uZxM1qqMpdiw?=
 =?us-ascii?Q?+ixTwSDMLLFuw1qdLJFt5J0AWCf3aF+KAQrH2+0pyibX/P2N0UjbnOwJVOfO?=
 =?us-ascii?Q?DfrMQkIERdnfZEIzq12ImAYtlR6Bg8r/8NhJmOI0HnJLUUruizVkGEx7tafg?=
 =?us-ascii?Q?JqM+jGlJ1zGXRRey/BIXb1SETbB6+MALZIURFKkuaY9KqEhmZla1Oc+ducqQ?=
 =?us-ascii?Q?2fOVklOHeScUykSGPaLpGsGK475llZKKuq5goH1epcdeOH5zwQd3HPwQrEvH?=
 =?us-ascii?Q?0qKpu9xphg2HgkkzlabpffIYTI79AXYwOkpgzrd4KY77noNoYgF+xl4TtK9b?=
 =?us-ascii?Q?7BbZjAGAIpLP3A/GxbKvuqN0kUA2wlm90z/Olyu0Wj+g5p0rzukCULGsRLhk?=
 =?us-ascii?Q?UePPYh4eLgvhXzN4nZ6sw5Myd31pULOpdwmgIbpoq+yNjxUGuHw+4/SwUbvL?=
 =?us-ascii?Q?w/xxeFMkgGKH3AZJktHSUnfNCtOKzYK6LmCD9nO8XeGNKbPlVDcYBrKvWnvG?=
 =?us-ascii?Q?oQA4caP9t0fq7ih/xe3DdZ9ZcjWwWkOt3QIWirkMP9NkrgCfELvabEMbsl+d?=
 =?us-ascii?Q?6HUWrz5GNk+nuYas8NNL23HhZ96F4li6PEzqjZKZzRkiY/7A/zsGsXXOhMle?=
 =?us-ascii?Q?wOjjSprlTOJi4Ikkg6eTln2BqXkYxK5vkmaKvPNkJWln7KKyZF7A1RYMqMIW?=
 =?us-ascii?Q?xEOrinqu2R6wptsMgp0r/qqlWjv8D3Uvq9yldzuGg6BKFR9OR8np+dPejE0O?=
 =?us-ascii?Q?HADvRRobhkdqNB0tK4zyHIpHdwH49H4iGU4r21edTk7BodZpH1hu7R3yfH1Y?=
 =?us-ascii?Q?O/5EJDUPobuW5wbCDyJLJ03g9JvTlwfdwVG69p6K4zsA5CsyGQTE5cLcMHD3?=
 =?us-ascii?Q?FUGn0xQUu7JleZ1QlI7KiuhngrMrkncJ6rRiJ33J6TalYsgC11eYWd9BfpXi?=
 =?us-ascii?Q?LxMvFAIjALDzDYdn2+Gzfcgtl16hUziRV9a8ylsVdVEWU1io/11EuI5N2w+q?=
 =?us-ascii?Q?a6C3UDaOBX1X/eZrxUUdDhXBVuQ+XesAAzhrRJqeS9dj0FYltTD2/u5q0gjp?=
 =?us-ascii?Q?3N6PsSx+mBtUk9BwNg7SzL/c8gEZxUOJi9i/IXWWQEU1o85N/oB9ghI39w/J?=
 =?us-ascii?Q?Qnf7BH30T5a9QFM45f1OqaF2tNFoDzQLt45HR47wAFXJWCJgqSmGBPrPoASY?=
 =?us-ascii?Q?QDujp39KICdkI0R4q/z2vi2CoBtTEgtRSgNMfFEy+HfqisdltcWFcVX0HREg?=
 =?us-ascii?Q?hg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C7BB84DB196EE54B8666747D32C88856@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: J2/7Ko6V2xFZ1wdeKbNGg0nQ9n0z4LF1FHnm7yF24T+gddYRbplpDr6be6GIYzUrI0EkH02NXHbfRdV1RGTZDbZhAwbYyoQL/nIpnHuerRjS4RzhcJacWJzPq8YTZgeEISd34fYyUDPfc09uF2GbUkJEiCy883UAHtGnf7ZOJR72D8NWOO0Q/r6BoZe412/upft/TfoD7djNRrdNLULdF3uDFPqY7N/TnZfVFeDePrOZQnLmLhq4mSwHhbekLmOrCEsKdyGQ16L9td+NQN5sf3olqBBYX8qkdW7Dnju4BbxG7pHBpEBvMpMOoBwR+t/laA6NEbbsyFjTMh8rv3duCEJsSRTfiCec3aVlYhnFa2ssF+H4ijFOea0mkJPIUOOnV2hw8W92tGbQPOsypflshbmzcQr2KdkqC2Hl/NqPa6YIK49FJGwDp6Q8Q7bx/gl44HaZfGrIqQ0EkbWnJTNURQUCiBNuz6+7hBHezenz6mjBAPrRJMMcn1+hJMisFuwztjAiwqg7U7zrlc+L6NDzStEKOrY9BFiQ7D4TPrxjsuLSCfNWNV+7OmyAZyRoKTaQxzDyxacgHW/fqd1OymIeL1920z+Ia7B3NxXuQzquryaa85d/w5/g/KbI01UmTWZcrDDBnIBLIu7J486dyGVXfkX7P435ggDxA9sa2Y6ekIzoD3oHXy/Ke4u4vD3cAIJsnsaNq6Ly5f3zuSY985xe9MBgjdIQCz0iDnhuA5yMfRwMOg6Y8bQndYO/U/xv7uHPjkpXPmnr4o/vMdVPUDRK2TJ9TUWtkQVxp3jk1+C6Y3+bAzdxl2Tsx76SqvHVfkOjpwP5ck7GESuTVtIoh2pc289sC91cyOdAz5APlZeHqaLJUGn6D1UC82YPrzw0Zul8
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 7fc1b1e3-76e1-400e-7107-08dbda7fa943
X-MS-Exchange-CrossTenant-originalarrivaltime: 01 Nov 2023 02:10:03.8422
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: nHcsH60nJiDaN1en7Ep/WpmKA8BA+P3wubc2R2qdpS7OOk7HE3wtLctx3aaCSf0KKk6/lTverPyDsRraB84EmQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB6561
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-10-31_10,2023-10-31_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 phishscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2310240000 definitions=main-2311010016
X-Proofpoint-ORIG-GUID: 5dNar8N767HslOWwTtXnYvxN7jBHzbyv
X-Proofpoint-GUID: 5dNar8N767HslOWwTtXnYvxN7jBHzbyv
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 31 Oct 2023 19:10:22 -0700 (PDT)

Howdy Neil-

> On Oct 31, 2023, at 5:57 PM, NeilBrown <neilb@suse.de> wrote:
>=20
> Revoking state through 'unlock_filesystem' now revokes any delegation
> states found.  When the stateids are then freed by the client, the
> revoked stateids will be cleaned up correctly.

Here's my derpy question of the day.

"When the stateids are then freed by the client" seems to be
a repeating trope, and it concerns me a bit (probably because
I haven't yet learned how this mechanism /currently/ works)...

In the case when the client has actually vanished (eg, was
destroyed by an orchestrator), it's not going to be around
to actively free revoked state. Doesn't that situation result
in pinned state on the server? I would expect that's a primary
use case for "unlock_filesystem."

Maybe I've misunderstood something fundamental.


--
Chuck Lever