Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/3] nfs: clean up some tracepoints in the lookup /
 revalidate codepaths
Thread-Topic: [PATCH 0/3] nfs: clean up some tracepoints in the lookup /
 revalidate codepaths
Thread-Index: AQHaDj4kMvimT2TVzkSiRtxKP0K+l7BopJeA
Date:   Fri, 3 Nov 2023 14:18:06 +0000
Message-ID: <8EB59F3B-D902-4934-879F-8994C947CB89@oracle.com>
References: <20231103-nfs-6-8-v1-0-a2aa9021dc1d@kernel.org>
In-Reply-To: <20231103-nfs-6-8-v1-0-a2aa9021dc1d@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?507BByOY1z6C7GBLEVZAxGbT75WwbVM/UmEUawV17Nx2WWCatSO4qWn4IzqV?=
 =?us-ascii?Q?SL6KmdoE7BumTRZtcrg45GHyiuVlZ1hETg0PCDyIdV9QDtNwIqMsahAJN2og?=
 =?us-ascii?Q?Wa6n2h6XwZrgxRkzNwOH+A3pyFHPhAN/ra5OjmKIIJ5vYgbJJplkvw6xtiYx?=
 =?us-ascii?Q?u9KnNk4dGzDUoQW0U9rSUdVBAZck+qGjvEDEi5l4IMjAI9PXJe7RYHVdWEGR?=
 =?us-ascii?Q?CjkIjY7JIV9QIayVMDMR+I4NYvX+vWsoUqZQx1WDBLAkg21xUEP9rBRUv455?=
 =?us-ascii?Q?VJbRrxHKIq13L7dEYWaxE82U9D3uCGhy0sByuND/UEo3AcDZEA0WquFP1MYA?=
 =?us-ascii?Q?ZLiyV+ZWYmkIMmt62A6d/vfGBEM/ypgTUjvFkvxlhAuAcYYf4BP8BBB0iDMU?=
 =?us-ascii?Q?MhJE45xe/gaMaumVb9703ceOdFRcFDeqrOvDhYDxTfWYE6zkaAfm/B8F3jIB?=
 =?us-ascii?Q?70sZCpP6Xpw1YTBNHSPcoCLNnVD2SRJvl5OmJVQPTygLeUIi8FxW6oObZsAC?=
 =?us-ascii?Q?Bs4DErnuYTaMou5Qox3rDgpbfkxghJDq1b1UgShegj+KWvBcydYlETNGgUIi?=
 =?us-ascii?Q?uJK2Y4VfDROheRnuPbiTqAJ6OIiyknL0SRCVnNItkIhsCLdcxVzSNGD6L39c?=
 =?us-ascii?Q?0W6xBVp56tI2IFhbm366Y9GUWqpzmtrxayt3HLwmWcfiy06u4Q58NNSwL4Lx?=
 =?us-ascii?Q?qBLHHzpeRvE6SnxVVepCMLbpLmPx94yCHEi+Rp892IXDwqOY106voEjfZXfE?=
 =?us-ascii?Q?s4Tk9Emf3mNxsvNDC7vB/W7Oohr06dpHScl/B1brU1F1xmz4y0zYr+BiMRPR?=
 =?us-ascii?Q?TcMfV2APCVhr414feST6hzM3hYwYFN1DdVHV3JtXu7TCsist0Obe6W+E2Yfj?=
 =?us-ascii?Q?WG/ADT5Wf4Kb3rA6KO7CHgOZ/aPky+Pxf2d8ByNHWFCm4YsRKQHJS6ZE+8hZ?=
 =?us-ascii?Q?PVELhrQtk/LH4NmcJ3B/6ivTdFtx2+hfkWrLx2BL3zLERyMv9uK6wQrCbcKD?=
 =?us-ascii?Q?/FwyLXUqvWD32nM6wH4+OH8UDAiaqEOEQV1m7peOkeCXmj8UyA26PmXhcXQI?=
 =?us-ascii?Q?+J9Rskrp90QwMgxeWgZ8qKCSQGLwxbek6i2rq+SsJ5Oxh217mFZkedZItC1p?=
 =?us-ascii?Q?JtnJK0v3H5eyK0htWH9y3kP5ljTLcQlVSHP2NpmH1KynmMirBPvsLYcNqcEx?=
 =?us-ascii?Q?v304v70AeaGqRKcrhcPVStswbqy0Q+slLh+Oo7miKRgV0R8vXdebepzY1hdV?=
 =?us-ascii?Q?ca6SeSfEK1M2q1esYVJ7YCGRMHpVqjoAv/JMsD3ypN1KpxTsytcmkBmo3WS/?=
 =?us-ascii?Q?jNPzfyJZkNkUBV4+QslscxNgWgna0oYYVZj0UxKgwiedhN0Hql1cwDbvfhNS?=
 =?us-ascii?Q?IEt5S0ZxqFXI8xC6rLyIH7cgVQ0bMtPVuGcIt9SEegaK7udQs41oiISxIt5e?=
 =?us-ascii?Q?srA5NpxX+RrrMdMRG/krBz4E+qIDfV6W5yvpCrl8vqzclgj2dW9BxQHPWeO1?=
 =?us-ascii?Q?KYtUnZ+01NYbgjadMWFdN9vyOUtTDOg5gg0pYgJPIJEJYqrrSNzFX/s4QSlK?=
 =?us-ascii?Q?H0T1arb9+uYaAl6Lq2fE8pp7UinRoc627R4NF3C0hoV1+djFUX8fca3YHS85?=
 =?us-ascii?Q?Yg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AA5A24467F8A2C4B9004E5AFA12A65AE@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: hnqXknya62md9hs0VY1QE18zGEPqTUhCRVBP18OkxvBXQS04QAF54PltoO3tVawxxzOP65p1sAR+l73TGAYBjnA2ULZ/LYZ9wZW3xP6Y6AhObpLoUAmz8sEoVoAZeQuhXlKaYLRJ85Oo69JoGh8PyJWqfLpLPjOeY7NI6ear6h6Szfm8WQmOKeRgYzEKi3AGAuim/Ow1051P6Nl3tZbGDiXS2YUEFFWl5FzqsW8kbjOJxIuCWpDCaQiTE0um4WryG1YlZvPFaA/uhjUqvae0BjJXYdkZ9zW7LyM7LmQiQK6HcY2kuDL4lgEoqAGFcu30P0/rO21GViHYZiiw8H4/3klCSP8hU/fvAauoT4QIhJ6fIsaTcm0vbzgl+fxLCFasunJLnuS1x41smoDCsjx9WR6XsVFLQc6/IpzPnqoNXt22UwySGcm3MRiHbi3DatWW3hf6tO43/nS5++/GLGz5Dibl4NQxHg8ZiFe496GTSJ6OX+szuC/tgm7EevfTsJttQyOuqFKugIW/nPoaZVd3yA94Yd8SpJRhsE3KsFEtPML5YXMxQh+SxL74uReCUpfaZg5v/c04yD5lgDmZhAT6zY0ECUD8NKYV3FoUpP5+t/UygGKGmTv1T/mxaqWx2vJVEwEw6jatx0pyGSXBXoZYP5MouDLGLHIwSqznRKEm0mFPG74tOtpfS9hkh6I4+CZQhHDz3zx59dTrMsT9Z8NhCgJaiYq4FsIKK9MwDYIG9+9F8o0dSEu0jUY95R3X1iQeiIylI7ORde4jiIrvtKS+lqQcoWkBq6c9f2QVmyP0dz7QlMXLPvCWBIcHtD5hzjn3EG64e7X2ogVtwAdZ6sKt4g==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b3ea9f7c-83ce-4675-e29c-08dbdc77b328
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2023 14:18:06.7933
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 2e0B3BvcqxGAG1Qj5aedogKjNyJM/tyE+G6JPG2Q3TjONd7aWvSYGpaju8gvWOEJF3fx6JbYAPUNbyKFEskD8A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB7840
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-03_13,2023-11-02_03,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 bulkscore=0
 mlxscore=0 adultscore=0 mlxlogscore=887 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000
 definitions=main-2311030121
X-Proofpoint-ORIG-GUID: zwy4_IJ4b5jHzBsHc2WlrCXBHpBspPcz
X-Proofpoint-GUID: zwy4_IJ4b5jHzBsHc2WlrCXBHpBspPcz
X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
	DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
	SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org
X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Fri, 03 Nov 2023 07:18:39 -0700 (PDT)


> On Nov 3, 2023, at 3:10 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> I was looking at a lookupcache issue the other day that turned out to be
> a false alarm. While looking I needed to turn up some tracepoints, and
> found some of the info to be lacking. These patches just do a little
> cleanup to the nfs tracepoints, and flesh them out a bit.
>=20
> Signed-off-by: Jeff Layton <jlayton@kernel.org>

Reviewed-by: Chuck Lever <chuck.lever@oracle.com <mailto:chuck.lever@oracle=
.com>>


> ---
> Jeff Layton (3):
>      nfs: add new tracepoint at nfs4 revalidate entry point
>      nfs: rename the nfs_async_rename_done tracepoint
>      nfs: print fileid in lookup tracepoints
>=20
> fs/nfs/dir.c      |  2 ++
> fs/nfs/nfstrace.h | 16 +++++++++++-----
> fs/nfs/unlink.c   |  2 +-
> 3 files changed, 14 insertions(+), 6 deletions(-)
> ---
> base-commit: 21e80f3841c01aeaf32d7aee7bbc87b3db1aa0c6
> change-id: 20231102-nfs-6-8-7a98e3e480d2
>=20
> Best regards,
> --=20
> Jeff Layton <jlayton@kernel.org>
>=20

--
Chuck Lever