Received: by 2002:a05:7412:8521:b0:e2:908c:2ebd with SMTP id t33csp2246994rdf; Mon, 6 Nov 2023 08:34:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGlgnbtLUqhpnnTsQR4kW42Hm08oueJ9roX4zL5GSD+6spHTBNHjbC88qFQ6yMzK7Y8Bwr X-Received: by 2002:a05:6a20:914a:b0:17d:b971:ebf0 with SMTP id x10-20020a056a20914a00b0017db971ebf0mr27338679pzc.53.1699288488975; Mon, 06 Nov 2023 08:34:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1699288488; cv=none; d=google.com; s=arc-20160816; b=AErLOhg+1p30F0Nwy7aiJl1vq+2sFUzS8Zc7PIpijdlj5hNarorZocybQtfJeicW3L tAzEUjUk360hv50bkzsnO/vPPAmVC065lINm+ZVHzobPfyH/W+5lLVprobX1Xv0QEGrJ xaEdxC2gvfwLJOKwL2TaQXn79LtaiipgBjkpgGp247/xRTFyt8r2Qq0nM1FE5+OpglqB B1tln6aTIEv+HdUN4KhBqwSy5YTBwP7pe0jmbtIaiy0z5N/1HSa4AkZcpLy9IiWMOZrA jxsbwAa5o+uNb68f6gXGDt1jhqtM8QKEFBGuT2Hfp3EpTY/azGxuxLA+3czFydiwfadh LSsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:date:cc:to:from:subject:message-id :dkim-signature; bh=pZJyqFbl59bkZ161bZWrxQkthrJNgakp9QGEaCBeqX8=; fh=3YUPjEu2LkNf2IdC0rOlCcpW+EOh/RCOvRjXS8vyqwc=; b=Jv3ZR/inNNkv/JT7Agvh5SgIoZyyw0h829E99vnhrZfwaXHNjqQXQfkmXimZFnoRyu 8o4LNZB8ce3k1Icp7LYBsnBPns/Q8K3ub2jtZly9Ghlye3pgxloYsz2aVLIGzSdbyOpA X+/nI1AJomu6oPxBYlEmTAiZn1uvvISDZD/CLEuLkji3QAxnBG9aa4Ax0SChTj5JQYd1 RRnj9M42f4ZH66r91xVzj4/EOWZ79CAKJ4gK+93XXBdWthCugqDaLDfvFzvQNJ1mnwpO Sr3AYIoYgsLMg73OjwQUojYdv3f0h68BCFSFa+/xZIqUcJSVfCNtqU4tqkWZy2P6NvTu bIyA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Sz7FUgtc; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id n17-20020a170903111100b001bc2fd76db1si9034313plh.65.2023.11.06.08.34.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Nov 2023 08:34:48 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=Sz7FUgtc; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=ibm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 0482280BB3C6; Mon, 6 Nov 2023 08:34:44 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231792AbjKFQeo (ORCPT + 99 others); Mon, 6 Nov 2023 11:34:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229974AbjKFQen (ORCPT ); Mon, 6 Nov 2023 11:34:43 -0500 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B6282F3; Mon, 6 Nov 2023 08:34:40 -0800 (PST) Received: from pps.filterd (m0360072.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3A6GFXWL031665; Mon, 6 Nov 2023 16:33:51 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=pZJyqFbl59bkZ161bZWrxQkthrJNgakp9QGEaCBeqX8=; b=Sz7FUgtcN3kRvlUygKYVDJIrYSgBaFBt7wvpkzv85Vy0w1N+rNLhS74XySDfmtIf0ckb u/XNhPJGRszF4wjqpeDjCRJms84NqR8qYaKIeIwm5TRB+yJYzCRIDiB7nDl8WTOlSuOU jD4R36YGZLZLz6K2gMYCYAC48a6TAIRZHtgKbBDYgvKS6gwhp+AdEUavH9lFwyRJVuID 83CgnEf8Gb436E8r7NhEdCxvduVM3ECKpyawJp1dxj9PbAWqRUp59MHdTcgCPgXQ9DAp hkwI+tAtcLmYD/Ow1mdrD57NGxlQ6etTu/WjWKD7MqqCdZHWA7xjbkmC3NhJaffjmHmH NA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u73gh8nbh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Nov 2023 16:33:51 +0000 Received: from m0360072.ppops.net (m0360072.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3A6GI1Ta009967; Mon, 6 Nov 2023 16:33:50 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3u73gh8nb2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Nov 2023 16:33:50 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3A6Fw4Jj007918; Mon, 6 Nov 2023 16:33:49 GMT Received: from smtprelay03.wdc07v.mail.ibm.com ([172.16.1.70]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3u60nyark9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 06 Nov 2023 16:33:49 +0000 Received: from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com [10.39.53.230]) by smtprelay03.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3A6GXn5e9831006 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 Nov 2023 16:33:49 GMT Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 646B15805A; Mon, 6 Nov 2023 16:33:49 +0000 (GMT) Received: from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 87C2C5805F; Mon, 6 Nov 2023 16:33:46 +0000 (GMT) Received: from li-f45666cc-3089-11b2-a85c-c57d1a57929f.ibm.com (unknown [9.61.58.168]) by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP; Mon, 6 Nov 2023 16:33:46 +0000 (GMT) Message-ID: Subject: Re: [PATCH v4 20/23] ima: Move IMA-Appraisal to LSM infrastructure From: Mimi Zohar To: Roberto Sassu , viro@zeniv.linux.org.uk, brauner@kernel.org, chuck.lever@oracle.com, jlayton@kernel.org, neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com, tom@talpey.com, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, dmitry.kasatkin@gmail.com, dhowells@redhat.com, jarkko@kernel.org, stephen.smalley.work@gmail.com, eparis@parisplace.org, casey@schaufler-ca.com, mic@digikod.net Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-integrity@vger.kernel.org, keyrings@vger.kernel.org, selinux@vger.kernel.org, Roberto Sassu , Stefan Berger Date: Mon, 06 Nov 2023 11:33:45 -0500 In-Reply-To: <20231027084234.485243-1-roberto.sassu@huaweicloud.com> References: <20231027083558.484911-1-roberto.sassu@huaweicloud.com> <20231027084234.485243-1-roberto.sassu@huaweicloud.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.28.5 (3.28.5-22.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: 07Is1uPsVwvO7ug3J8NGrMQbHoFfeH5y X-Proofpoint-GUID: Oa1kOHQLNNefYUsVOYHe4V_BcB24nS7w X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-06_12,2023-11-02_03,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 impostorscore=0 malwarescore=0 mlxlogscore=999 bulkscore=0 adultscore=0 clxscore=1011 lowpriorityscore=0 phishscore=0 mlxscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2310240000 definitions=main-2311060133 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 06 Nov 2023 08:34:44 -0800 (PST) On Fri, 2023-10-27 at 10:42 +0200, Roberto Sassu wrote: > Do the registration of IMA-Appraisal functions separately from the rest of > IMA functions, as appraisal is a separate feature not necessarily enabled > in the kernel configuration. Add "only" -> of IMA-Apparaisal only functions ... > Reuse the same approach as for other IMA functions, move hardcoded calls > from various places in the kernel to the LSM infrastructure. Declare the > functions as static and register them as hook implementations in > init_ima_appraise_lsm(), called by init_ima_lsm(). > > Signed-off-by: Roberto Sassu > Reviewed-by: Stefan Berger Reviewed-by: Mimi Zohar