Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32;
MIME-Version: 1.0
References: <21a1f2a6155398965f79ed64f0bd23bf38a50367.1700083991.git.bcodding@redhat.com>
 <952eea7e97246870f83e7a4592e9338007dfe625.1700083991.git.bcodding@redhat.com>
 <CAFX2Jfkc7p+22aK0KvN4yUerS1HuKDC+Njo_AJV1=5pWW0sUYQ@mail.gmail.com> <CCFAA747-7BC9-40AB-8E37-A18B33A01511@redhat.com>
In-Reply-To: <CCFAA747-7BC9-40AB-8E37-A18B33A01511@redhat.com>
From:   Anna Schumaker <anna@kernel.org>
Date:   Thu, 16 Nov 2023 17:11:44 -0500
Message-ID: <CAFX2Jf=bDFEx2cfzXtHhaMu0pF5dV1-sheANmAXMf0m-arr61w@mail.gmail.com>
Subject: Re: [PATCH 2/2] NFS: drop unused nfs_direct_req bytes_left
To:     Benjamin Coddington <bcodding@redhat.com>
Cc:     trond.myklebust@hammerspace.com, linux-nfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Thu, Nov 16, 2023 at 5:03=E2=80=AFPM Benjamin Coddington <bcodding@redha=
t.com> wrote:
>
> On 16 Nov 2023, at 16:44, Anna Schumaker wrote:
>
> > Hi Ben,
> >
> > On Wed, Nov 15, 2023 at 4:34=E2=80=AFPM Benjamin Coddington <bcodding@r=
edhat.com> wrote:
> >>
> >> Now that we're calculating how large a remaining IO should be based
> >> on the current request's offset, we no longer need to track bytes_left=
 on
> >> each struct nfs_direct_req.  Drop the field, and clean up the direct
> >> request tracepoints.
> >
> > I've been having problems with xfstests generic/465 on all NFS
> > versions after applying this patch. Looking at wireshark, the client
> > appears to be resending the same reads over and over again. Have you
> > seen anything like this in your testing?
>
> I have generic/465 failing before and after these two patches on pNFS SCS=
I..
> but at least it completes.  If I run it without pNFS I can see the same
> thing.. it just sends the same reads over and over.  I'll figure out why.

Thanks! I have it failing normally as well, so that's expected. It's
the hanging forever that's not :)

Anna

>
> Ben
>