Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp831654rdb; Fri, 17 Nov 2023 14:14:27 -0800 (PST) X-Google-Smtp-Source: AGHT+IERkX6ZGiYuAGWZn9/DcMrcyWXlpTMiEK5cO1rhbMNPkRHcOYepXhD5dRyySK1E4pnIztzi X-Received: by 2002:a05:6a21:7742:b0:187:995c:1d6e with SMTP id bc2-20020a056a21774200b00187995c1d6emr747722pzc.16.1700259267234; Fri, 17 Nov 2023 14:14:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700259267; cv=none; d=google.com; s=arc-20160816; b=qsIxP8Sfw3oylsHHogwe6EdF/RYOFDM2DAdkZwmj7rE3XgSr3e7KeKfzDxUMXfLIPg CfyTGJLjCnxPnkgTY6hELkeHGn5npeI187Z92crJ3+zyCa7zp/uRt/3MfX7YoUxExVNK /sQYR7J5AsAg5qLKsBEK1nYNsc6lZpAcbH1HS+T74cI8xMJ3vuJkB3370DMixQ1ZC4xW HCaAFnNb3zNBaaYJGQCfnoxuQc6hR/5ucBsNLZVPN65J0GxhRpyJu4Egum+5hppVdeF0 h+gT7l2sBcGi83YKIstRMofBArNlBORKPeXS+G/ZsfuT29U+/oNl9TMj1AuoXvYH7JVF JjAA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:to:from:subject:dkim-signature; bh=kMFgoTNYDWoROvIKmgj5JFmOuN3lPJFU0gp/Og9M8Tc=; fh=Mys3y4MwsHRytUQMpdfGBn3oGRYLcLloxNwkFYMYMmg=; b=k3Pl4Fz/P7PzcuaflkSUPclTVCPN0MMyqtTOgAj0k6jYD/JwXOUDQwOk4m5Emf208b 3WRh7j7QFJaaHswojrt6Y/usEOxTHddn21WkQZTvTKBsYQPs3lPmJ+4455iAHzRqenuK 15DLQYUzwsNVvwvhZXHDNqtYJPOnBbIlIJjILZqbLjX3tes4DGwt6NHqEQfCfa/HSX/7 GRmb3bAuuu2zY5P/eJwi1SOEuGcF2EXoLh3O1wV1py59DJMsuhprgRw9m4eG/2e/U5QU xk0jzIRjSPtSJAEzghmIDyauJBaAZnKSrrlyIcbJo00pznolBKdnP4SdSUZu8A7U0vCz i0hg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SxuqE50A; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id u24-20020a63df18000000b005aee0914b6csi2950024pgg.8.2023.11.17.14.14.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Nov 2023 14:14:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SxuqE50A; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3B36C82B4850; Fri, 17 Nov 2023 14:14:26 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231533AbjKQWO0 (ORCPT + 99 others); Fri, 17 Nov 2023 17:14:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbjKQWO0 (ORCPT ); Fri, 17 Nov 2023 17:14:26 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06E2BB8 for ; Fri, 17 Nov 2023 14:14:23 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 11A29C433C8 for ; Fri, 17 Nov 2023 22:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700259262; bh=ckH7unM9RJpm+yub2h4VG+eGwAFRSDMAoKA3hDR6X9E=; h=Subject:From:To:Date:From; b=SxuqE50ASoikusqvQQk+dJ9ouoV5zcbqYOiBsQmww6kaPTsQki3frKylDqgNl0SV2 UckEIplBfcNuGierAZGmY0LFnkE3tANKvIhktcosos/siIzC2s9CgyvzEyLatrPlE0 o8Qd1P/59XXpHwTRtyukp9ydIYoMf+PFtBf5v59blVIIvDoGGSEwhHH5kGGQp01gVN b8ECv3YQjFQCBbmw0GlfSXzMNX7BVBaq70KCBsKaIAi9DT6DzOJ1yBxM4u4KCBsnK0 Qp1bLaqBzsOmszAbpJ16+DV8ro3uTxTh6m/fYY6ptiqlGWNBzlP1JJkpwRpl1lL0xR UbNhhGVq5QuFg== Subject: [PATCH v2 0/4] Eliminate the RQ_SPLICE_OK flag From: Chuck Lever To: linux-nfs@vger.kernel.org Date: Fri, 17 Nov 2023 17:14:21 -0500 Message-ID: <170025895725.4577.18051288602708688381.stgit@bazille.1015granger.net> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 17 Nov 2023 14:14:26 -0800 (PST) The server's splice read path is used by the majority of exported filesystems. At last month's bake-a-thon, we tossed around some ideas about how to improve benchmarking and test coverage of the NFS server's vectored-read path, which is a fallback. One way to do this would be to expose a switch that can be set by test harnesses to disable splice reads. As an initial step, hoist RQ_SPLICE_OK out of the RPC layer. Later, I'll add a netlink command to as a switch between "use splice if possible" and "always use vectored reads". (I don't want to collide with the work Lorenzo is doing). Changes since v1: - Address "undefined reference to `svcauth_gss_flavor'" --- Chuck Lever (4): SUNRPC: Add a server-side API for retrieving an RPC's pseudoflavor NFSD: Replace RQ_SPLICE_OK in nfsd_read() NFSD: Modify NFSv4 to use nfsd_read_splice_ok() SUNRPC: Remove RQ_SPLICE_OK fs/nfsd/nfs4proc.c | 7 +++++-- fs/nfsd/nfs4xdr.c | 13 ++++++++----- fs/nfsd/vfs.c | 26 +++++++++++++++++++++++++- fs/nfsd/vfs.h | 1 + fs/nfsd/xdr4.h | 1 + include/linux/sunrpc/svc.h | 2 -- include/linux/sunrpc/svcauth.h | 7 ++++++- include/trace/events/sunrpc.h | 1 - net/sunrpc/auth_gss/svcauth_gss.c | 16 ++++++---------- net/sunrpc/svc.c | 2 -- net/sunrpc/svcauth.c | 16 ++++++++++++++++ 11 files changed, 68 insertions(+), 24 deletions(-) -- Chuck Lever