Received: by 2002:a05:7412:b130:b0:e2:908c:2ebd with SMTP id az48csp2444013rdb; Mon, 20 Nov 2023 10:53:53 -0800 (PST) X-Google-Smtp-Source: AGHT+IFlyYHCk1vwv0AKlhiptJZod4RtDh0EpcRs9m9/SB4ayz4kJM52GkO6BN2cuY62Bsa4bL4V X-Received: by 2002:a17:902:d2c7:b0:1cf:59b7:b035 with SMTP id n7-20020a170902d2c700b001cf59b7b035mr6553462plc.21.1700506432815; Mon, 20 Nov 2023 10:53:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1700506432; cv=none; d=google.com; s=arc-20160816; b=aCv4ezUnmmJEJXdN0xMoANz3nM9N1O0aelc0HYozWDFKVTXHznjoLeOPa3iGpG/wHr NdE6dhwMVS+GQOpr9c2q13oA2VDJ/w8IpgcigCN9DNSZaWD0pDSEFmSNJRJteWAtj1ye f+bkvBShHCkIY9sQ5WFrdUGUePMh0Z/sF6uC8CnOSBgC6pr6cz7fceFsLOq+F223IkgS nFhsLSKqXf2zlE4oQ55+chOwqmmuikfHkGtY0Z3sqPiy8c/TJ/ILvWlO110wO+XoW/PJ 5Xs6xvx+z+rNiV15PS/mOwI+sK6DxXGz0XgmEuh6OlcFjvF0h4R/euhiotw1YlLou0iV Eozg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject:dkim-signature; bh=KvxfsloYp3dFIBXgM5dh5/WZlbQ+ekHu2FtP+9k+7rY=; fh=v8a13lpFSZWlL4AptTEJnmXnlqoWXhGCGCgvrcnCT9I=; b=clgPtrU0JiFZA9qHDA9zkQiYzFXOp9q2ki7BeR4cVfowePFnf8RSN6XcM++Wd8An5a 0RWLb8h/bcfAWFa8tHwRWKBBctSEtN6codyGuhfsve7PQfbj1Qb6hwhAMvWQzG5tv//s N+7OB0c721OKc1OaTTw+tydnG+JmlwEPoXMg3OOJXTs28kv+mqELOjAMurgc6SwKAZu6 kbEKLDLjnsRspL1tsLcYhvPaOSgbBG5UAf0D6D6JqD2kCDa/NjaYUtYojErpjAOjoVwH AhA1X3RhMS3zLUij/HMSYEfCJscquraA9NrVYPXKg/JNfIqxnD1m15kd9gL1k7gH5wge Y4mA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VNk3X4rU; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id jc18-20020a17090325d200b001c72325d6f4si8170076plb.605.2023.11.20.10.53.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Nov 2023 10:53:52 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VNk3X4rU; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 1F6B080A97DA; Mon, 20 Nov 2023 10:53:50 -0800 (PST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.11 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230229AbjKTSxv (ORCPT + 99 others); Mon, 20 Nov 2023 13:53:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbjKTSxu (ORCPT ); Mon, 20 Nov 2023 13:53:50 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C37BC8 for ; Mon, 20 Nov 2023 10:53:47 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EBE5C433C8; Mon, 20 Nov 2023 18:53:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700506427; bh=My3stO6oFd/9rUFAB5HQqsIZaehpceYJCE0n7ue6+Z0=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=VNk3X4rUaTsIE4vtFNDaYxx5AB+OLre6frEn3k7K5pUBQDP7+4IHBzAPSg9xNXQy2 f3XREFMuWJc25k85clbwApX1pDwUAUpY6MZTSr/Cc9W3pEfed8on3OMKT6BWGaRxFh w94gXMUXbsttLFpDRpL9z7kw6rHRNjkqW0WKQGszztxv9NUEl1od3z2Vz7vG6BlZwW NhGHLs2avpcv8B3d7fmxhj/JaPOE1In4DW4FHRo1n6+9ZdQBadOfUI88YDntOuqYto 10r+2etsTY2SWElN1b0sczFcD4GNRZUUXQCz5aAYlpqqB8S6Re5BdpgCU3Y9eNCJ+d +PQjpR8/2n78w== Subject: [PATCH RFC 2/5] junction: Remove xmlIndentTreeOutput From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: Chuck Lever Date: Mon, 20 Nov 2023 13:53:46 -0500 Message-ID: <170050642602.123525.1034811730816028179.stgit@manet.1015granger.net> In-Reply-To: <170050610386.123525.8429348635736141592.stgit@manet.1015granger.net> References: <170050610386.123525.8429348635736141592.stgit@manet.1015granger.net> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Mon, 20 Nov 2023 10:53:50 -0800 (PST) From: Chuck Lever Though it doesn't seem to be marked deprecated, xmlIndentTreeOutput does not appear in recent versions of libxml2. Since xmlIndentTreeOutput = 1; should be the default behavior now, we can remove this statement without a behavior change. Signed-off-by: Chuck Lever --- support/junction/xml.c | 1 - 1 file changed, 1 deletion(-) diff --git a/support/junction/xml.c b/support/junction/xml.c index ec9586528cc9..aef1cbbd74d3 100644 --- a/support/junction/xml.c +++ b/support/junction/xml.c @@ -387,7 +387,6 @@ junction_xml_write(const char *pathname, const char *name, xmlDocPtr doc) return retval; retval = FEDFS_ERR_SVRFAULT; - xmlIndentTreeOutput = 1; xmlDocDumpFormatMemoryEnc(doc, &buf, &len, "UTF-8", 1); if (len < 0) goto out;