Received-SPF: pass (google.com: domain of linux-nfs+bounces-18-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Chuck Lever III <chuck.lever@oracle.com>
To: Olga Kornievskaia <kolga@netapp.com>
CC: Steve Dickson <SteveD@redhat.com>,
        Linux NFS Mailing List
	<linux-nfs@vger.kernel.org>
Subject: changes to struct rpc_gss_sec
Thread-Topic: changes to struct rpc_gss_sec
Thread-Index: AQHaHJwgTh02jJAHvU6pH+6SDi4DSw==
Date: Tue, 21 Nov 2023 16:59:44 +0000
Message-ID: <97AE695C-8F9F-4E9C-9460-427C284FBD32@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 
 =?us-ascii?Q?80+PUb+m/hsxCiV1YyMw/kqwks8dLAP00wSbp5Qz8XkQmXCWewVZkjM3hd7d?=
 =?us-ascii?Q?a3IWBhS5PgHliMANNx2fNCN+FnUfQ2+RwGKdmCKgzmo+ZiAX1oUmI1ygvDza?=
 =?us-ascii?Q?VoAxv7ZPTpfwj/MM5mVs/6Gwl7tQjdZfS6rO0vBbLOQBUoyNKfFava9rkoN6?=
 =?us-ascii?Q?kLc/6QWCNe2vQsTDBiHnY2DQ2KLq377ml/7XJOIpEYPDOZ50g2R6K+Mj5GJh?=
 =?us-ascii?Q?+FR8EsrqmGyyepGcqUJ7pePISOMMo0jsUUBsGo1Xc1ZPLQMesExEBVDj7yNO?=
 =?us-ascii?Q?9wa480kNCBYLTzIk4T8JIQwwJAFW8va+9mZz0aMznk/XKTNWDvebwX6StqYP?=
 =?us-ascii?Q?0D/U7JEJT0r1R2pwFhDvA4HcmgO25fDUTX+4nw1gZFYiZZvtdgmJUcy/4uQ3?=
 =?us-ascii?Q?gDnK7pyEI0qsX03dX/YrnzlhSVAhqIngaJDxhrK9pGCFHVW09a3TDawAJCE8?=
 =?us-ascii?Q?9xt1hTi0i2cSzMQ563dbW5qmDz7VHe1MhIJEHJ2SCZue4zNlA+XcNAQy6HFk?=
 =?us-ascii?Q?ehLrBKvUZQKQjolkzS5TiV7mT5Lb/ozDnMPx0Fx23IyyCv09IyP2eZ+52toQ?=
 =?us-ascii?Q?zzDTOYS9mFZ385zDhEFTXKtMvEwZZvp+a2nd1XKtWTh42bTKb2h3j0kXrV3z?=
 =?us-ascii?Q?doHvQtK/RFEcMNSQyEB4VRRoMR7wNiIgYJOf/amlWa4W3b0j33Gu5LXCj7ld?=
 =?us-ascii?Q?2juDPjC678l7+uLQnB4NklObcj5k0kvGtoCzBY4NL4XIhtoWO4IhrQhaE938?=
 =?us-ascii?Q?wuKbeCwjTEqS0ngzLm1hkKelLY9TVGvyfL26KJ6P/Uon7rHX1zX5SMHl1uOa?=
 =?us-ascii?Q?P4u4A1tnBmFkHWB6L2SZWYjR7C41sErfqsDj8FeZ9tmW5yWi9hlmgBH0flgO?=
 =?us-ascii?Q?Y8COsRsYare8X+iF6m4+Bt0CJJjYt1mA0G6gTNkIY++v4fNaU3UXd4yXYxhr?=
 =?us-ascii?Q?YqJCE2B733ONuv8wwZQLq/IRtDWjGP0SFpubjjiIGozfwD1cATZKo7QYd8hb?=
 =?us-ascii?Q?we0c8Gg8UnCHnUC9qkZZlmQdll9fescpn1GbSWppNm1kPrXSjhEHx6NQbjBt?=
 =?us-ascii?Q?CdesAhTlKDJC4/XlTIBpGQ6OGTkpWj90j7674STip/w+6PzgkNxiBa9ouHL7?=
 =?us-ascii?Q?P8p8WfXtGAJ8GeoaTba84aAa4g+y93WU5oh2oAJ6s4cOKgQQB7Rg91vH7leB?=
 =?us-ascii?Q?aBV4QyUmb8MkaDvSWk5z3miGCfN896uYgrtYkvyXSKDT3lZ0iWVm9BUEZR+I?=
 =?us-ascii?Q?mPzE8UwoBXcVBeOByPJA1L9wsKjbhOtDufacos0/SVKytFpQgs56PIX7xlnK?=
 =?us-ascii?Q?8bCmz8/p5hIh9ggZLy7Cfg/YHXMyM6IjPStMAZL/I46youZlaxSiICsxln01?=
 =?us-ascii?Q?17zVj4J4hxrJDkPxiqxgHWTcQXndmgMXtnrmCi+1BB5e6BFsiIm0wV5B4nPv?=
 =?us-ascii?Q?wIwgPqENzi+AKiEnfEok7J36OD/qZPr3DLx1P1VzPxp2KMQHfODI0zW9FmVL?=
 =?us-ascii?Q?WocXHHf2ia0FsCdsN3dH8p/NnKJbtOZ6iyJXL6Ev/SuUcIkK+XwBYKj1CUW2?=
 =?us-ascii?Q?B6Jp8A/qMmilJ4HAHbWCqfpibMmeMa5bMcqxkBj3bXhhXV5btuCwqiBVWF7W?=
 =?us-ascii?Q?LQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3243292FE27AC94BB5EA7BF4A02C8240@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-nfs@vger.kernel.org
List-Id: <linux-nfs.vger.kernel.org>
List-Subscribe: <mailto:linux-nfs+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-nfs+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	pY9IpaSclUCw9YJ4VvcMUewOYtt01brbWzVXXPweV6zbkKGafPBKnAiVVo7/iJexnz9/sRHORMUdi2T4HxpxucVlVas0ECSuplBF9sFHhix79YxW0vyOQ9Z9kLaG4BrK3uID/LSDXlSZvX9vQpvq1U96RL6xAwVF+bhiK4l12zoT8keNUyg/909ENlcAqznugaPgghA9hLMe8AQJdemrXjIRq2BI1P7kHbXfg+L8LK62jVWxYdW7488rrUvRaDgp5DWZmV1sLfoc1K24kQBy90rZDQ6gdIjuosU4BM7q5DCUGyqKjwpgEbVxEvkR6SRG/9GgFxsKsg5f4lVkrdUef0zLK2CcUQNTw3Ko3nv9v5YErrEBMANN1hi8ooTHZ+UxHGswQKWeCsI/Prv4dHoL7pwKEMaYeHHMUZSRkLZ/FElhP8y4nH24wVhmH+hVZtbFohoWpRUUw7zHGVj4ax6Rf9uEIrDdTLj2++j1I0tvyAXVElztdp1PI6ybYxAE0ZIsYNLLBUkjO4U6VB/IfD5+gEsXUgt7xdU1qX78Vhl+RmLUqRIlXP2+adql2F76eakRYEsdVQxtT/ukXryr6rTTxt5x/b3ndZibIjV5dwPblteqX5iB2HlsdnGyFv78JRPyZaRpJShONIcqUSB19UT33zqaXhJ7zyudxDe1aGDlBKkJlq2JP2MWWVxhQShreOCRIBDxo+x96plnrgKmLCsbUfSbR/vo0wb3ZK5gA1SN53E2hYUxiKIgPTosnuxv7mwqPAdFkYSFjMHL8bI/u+3i3wwzzbIwhyyB0qMbOQEIafDnzjpNB460BNdyx5lzqXS9
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a767303d-3aea-4893-08ee-08dbeab34302
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2023 16:59:44.7276
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: zBAR9NiQfqSHxOOk91wBHjE42B2CGOV3/ATy+dvUruf4CVRn0y6SLHWPzuuxgypiDZTXH6JOa6dAls/bkn/Pkw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4945
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-11-21_10,2023-11-21_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 phishscore=0
 mlxlogscore=999 adultscore=0 bulkscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000
 definitions=main-2311210134
X-Proofpoint-GUID: xcRRkxLdAfJ48oBCg1PDOT8zWqUnu91P
X-Proofpoint-ORIG-GUID: xcRRkxLdAfJ48oBCg1PDOT8zWqUnu91P

Hey Olga-

I see that f5b6e6fdb1e6 ("gss-api: expose gss major/minor error in
authgss_refresh()") added a couple of fields in structure rpc_gss_sec.
Later, there are some nfs-utils changes that start using those fields.

That breaks building the latest upstream nfs-utils on Fedora 38, whose
current libtirpc doesn't have those new fields.

IMO struct rpc_gss_sec is part of the libtirpc API/ABI, thus we really
shouldn't change it.

Instead, if gssd needs GSS status codes, can't it call
rpc_gss_seccreate(3), which explicitly takes a struct
rpc_gss_options_ret_t * argument?

ie, just replace the authgss_create_default() call with a call to
rpc_gss_seccreate(3) ....


--
Chuck Lever