Received-SPF: pass (google.com: domain of linux-nfs+bounces-26-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
From: "NeilBrown" <neilb@suse.de>
To: Ahelenia =?utf-8?q?Ziemia=C5=84ska?= <nabijaczleweli@nabijaczleweli.xyz>
Cc: linux-nfs@vger.kernel.org, "Steve Dickson" <steved@redhat.com>
Subject:
 Re: [PATCH nfs-utils v2 2/2] testlk: format off_t as llong instead of ssize_t
In-reply-to: =?utf-8?q?=3C9d2b8bdc146a1fb48b391ae1adda0b6249ba9c5b=2E1700601?=
 =?utf-8?q?199=2Egit=2Enabijaczleweli=40nabijaczleweli=2Exyz=3E?=
References: =?utf-8?q?=3Cb38ecca96762d939d377c381bf34521ee5945129=2E17006011?=
 =?utf-8?q?99=2Egit=2Enabijaczleweli=40nabijaczleweli=2Exyz=3E=2C_=3C9d2b8bd?=
 =?utf-8?q?c146a1fb48b391ae1adda0b6249ba9c5b=2E1700601199=2Egit=2Enabijaczle?=
 =?utf-8?q?weli=40nabijaczleweli=2Exyz=3E?=
Date: Wed, 22 Nov 2023 08:19:29 +1100
Message-id: <170060156974.7109.13325935820432597117@noble.neil.brown.name>

On Wed, 22 Nov 2023, Ahelenia Ziemia=C5=84ska wrote:
> This, naturally, produces a warning on x32 (and other ILP32 platforms
> with 64-bit off_t, presumably, but you need to ask for it explicitly
> there usually):
> gcc -DHAVE_CONFIG_H -I. -I../../support/include  -D_GNU_SOURCE -Wdate-time =
-D_FORTIFY_SOURCE=3D2 -D_GNU_SOURCE -g -O2 -ffile-prefix-map=3D/tmp/nfs-utils=
-2.6.3=3D. -specs=3D/usr/share/dpkg/pie-compile.specs -fstack-protector-stron=
g -Wformat -Werror=3Dformat-security -g -O2 -ffile-prefix-map=3D/tmp/nfs-util=
s-2.6.3=3D. -specs=3D/usr/share/dpkg/pie-compile.specs -fstack-protector-stro=
ng -Wformat -Werror=3Dformat-security -c -o testlk-testlk.o `test -f 'testlk.=
c' || echo './'`testlk.c
> testlk.c: In function =E2=80=98main=E2=80=99:
> testlk.c:84:66: warning: format =E2=80=98%zd=E2=80=99 expects argument of t=
ype =E2=80=98signed size_t=E2=80=99, but argument 4 has type =E2=80=98__off_t=
=E2=80=99 {aka =E2=80=98long long int=E2=80=99} [-Wformat=3D]
>    84 |                         printf("%s: conflicting lock by %d on (%zd;=
%zd)\n",
>       |                                                                ~~^
>       |                                                                  |
>       |                                                                  int
>       |                                                                %lld
>    85 |                                 fname, fl.l_pid, fl.l_start, fl.l_l=
en);
>       |                                                  ~~~~~~~~~~
>       |                                                    |
>       |                                                    __off_t {aka lon=
g long int}
> testlk.c:84:70: warning: format =E2=80=98%zd=E2=80=99 expects argument of t=
ype =E2=80=98signed size_t=E2=80=99, but argument 5 has type =E2=80=98__off_t=
=E2=80=99 {aka =E2=80=98long long int=E2=80=99} [-Wformat=3D]
>    84 |                         printf("%s: conflicting lock by %d on (%zd;=
%zd)\n",
>       |                                                                    =
~~^
>       |                                                                    =
  |
>       |                                                                    =
  int
>       |                                                                    =
%lld
>    85 |                                 fname, fl.l_pid, fl.l_start, fl.l_l=
en);
>       |                                                              ~~~~~~=
~~
>       |                                                                |
>       |                                                                __of=
f_t {aka long long int}
>=20
> Upcast to long long, doesn't really matter.
>=20
> It does, of course, raise the question of whether other bits of
> nfs-utils do something equally broken that just isn't caught by the
> format validator.
>=20
> Signed-off-by: Ahelenia Ziemia=C5=84ska <nabijaczleweli@nabijaczleweli.xyz>
> ---
> Same as v1: <44adec629186e220ee5d8fd936980ac4a33dc510.1693754442.git.nabija=
czleweli@nabijaczleweli.xyz>
>=20
>  tools/locktest/testlk.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/tools/locktest/testlk.c b/tools/locktest/testlk.c
> index ea51f788..c9bd6bac 100644
> --- a/tools/locktest/testlk.c
> +++ b/tools/locktest/testlk.c
> @@ -81,8 +81,8 @@ main(int argc, char **argv)
>  		if (fl.l_type =3D=3D F_UNLCK) {
>  			printf("%s: no conflicting lock\n", fname);
>  		} else {
> -			printf("%s: conflicting lock by %d on (%zd;%zd)\n",
> -				fname, fl.l_pid, fl.l_start, fl.l_len);
> +			printf("%s: conflicting lock by %d on (%lld;%lld)\n",
> +				fname, fl.l_pid, (long long)fl.l_start, (long long)fl.l_len);
>  		}
>  		return 0;
>  	}
> --=20
> 2.39.2
>=20

Reviewed-by: NeilBrown <neilb@suse.de>

Thanks,
NeilBrown