Received-SPF: pass (google.com: domain of linux-nfs+bounces-157-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
From: "NeilBrown" <neilb@suse.de>
To: "Oleg Nesterov" <oleg@redhat.com>
Cc: "Christian Brauner" <brauner@kernel.org>,
 "Al Viro" <viro@zeniv.linux.org.uk>, "Jens Axboe" <axboe@kernel.dk>,
 "Chuck Lever" <chuck.lever@oracle.com>, "Jeff Layton" <jlayton@kernel.org>,
 "Ingo Molnar" <mingo@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>,
 "Juri Lelli" <juri.lelli@redhat.com>,
 "Vincent Guittot" <vincent.guittot@linaro.org>, linux-fsdevel@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH/RFC] core/nfsd: allow kernel threads to use task_work.
In-reply-to: <20231128172959.GA27265@redhat.com>
References: <170112272125.7109.6245462722883333440@noble.neil.brown.name>,
 <20231128-arsch-halbieren-b2a95645de53@brauner>,
 <20231128135258.GB22743@redhat.com>,
 <20231128-elastisch-freuden-f9de91041218@brauner>,
 <20231128165945.GD22743@redhat.com>, <20231128172959.GA27265@redhat.com>
Date: Wed, 29 Nov 2023 10:40:51 +1100
Message-id: <170121485154.7109.13588704687316181624@noble.neil.brown.name>

On Wed, 29 Nov 2023, Oleg Nesterov wrote:
> Forgot to menstion,
> 
> On 11/28, Oleg Nesterov wrote:
> >
> > but please
> > note irq_thread()->task_work_add(on_exit_work).
> 
> and this means that Neil's and your more patch were wrong ;)

Yes it does - thanks for that!
I guess we need a setting that is focused particularly on fput().
Probably a PF flag is best for that.

Thanks,
NeilBrown


> 
> Oleg.
> 
>