Received: by 2002:a05:7412:419a:b0:f3:1519:9f41 with SMTP id i26csp4962178rdh; Wed, 29 Nov 2023 16:32:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IGON9cCF3BlyhYH2MKmOyNvdy2OplOHWjFZ6ylZ5GVXllxMUsygzv6ZH2wqSD+BNy7/H7Yp X-Received: by 2002:a05:622a:354:b0:421:b909:de9e with SMTP id r20-20020a05622a035400b00421b909de9emr24588215qtw.2.1701304323973; Wed, 29 Nov 2023 16:32:03 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701304323; cv=none; d=google.com; s=arc-20160816; b=bK2A2UvlhuZF9jySR2xgKwNUzrQIjM/sIqtZwv/rE/t/J82P73PZPqJoUp3cvBEJ4k oZ3VzknXjzXaNy7KPxiAGhyK24/Wjzmf85XtYZLrqpc7kbGH2pk4umoC1BY1rIsPsjJS BebjRGp8V8bN6cEl26RGME0w142z9QtSwjZ6yIWHUFZSQKS5rzkjFnXVJ7ZeHr8yuAC2 UQmJgboUkIPVEE+9yB2TJaJP07/7n36KdVv1pRDfW+AYk8wtKovlBCOHEuhYZ7qSWRcW Aoaj5MYRODeglEMLdXxtubatjtCDHJiYs3Sbduj+ZtkFEcPyRlyFi2rezSZNyI+d7hlj m7PQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=TolSuksUmy70PAxyUR3VC0RS2UTzcZi0sMUNnCF3mII=; fh=cZZk3usFw42dbM8K+0+fm0y64uKe+AeZ6DRAsGLbELI=; b=qHbBobaFw3FvfpbAX6fMWnRHhjCdg+JXsdqgTizjyvZSAP0CwQ+FQr8tL8z+7OOXbO gsXby0mxYaqxMZC5J6whn6B5VywSjtUB0GAn69l90OiR1weUEz+UVX0C4Xs6DtoWXmpI IGfTpufSJZEXVKLAcnIAWTtssSD8OUCnWRO/5NKftHyDSdcLl9bwav5LOWtIviWzHgte 3WMwwyzF1pevIXZMd8Ygxoutzin3osOLz6Z+fpM1uYenMQ3wAN3CjOP/7+JWKIcqOuYC +LpFxrQpSyhc8sOsRbF1cQewKZT+YyfTB0PYJk+jiKJM7XSdcxr9bYN4GfKuauULMtgv B5bA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XsjndXiy; spf=pass (google.com: domain of linux-nfs+bounces-182-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-182-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id gc9-20020a05622a59c900b00423c1150980si7968371qtb.35.2023.11.29.16.32.03 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 16:32:03 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-182-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=XsjndXiy; spf=pass (google.com: domain of linux-nfs+bounces-182-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-182-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id A11F11C20382 for ; Thu, 30 Nov 2023 00:32:03 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E43CF386; Thu, 30 Nov 2023 00:32:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XsjndXiy" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3F0A79C7; Thu, 30 Nov 2023 00:32:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6824C433C9; Thu, 30 Nov 2023 00:32:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701304322; bh=TolSuksUmy70PAxyUR3VC0RS2UTzcZi0sMUNnCF3mII=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XsjndXiyNAFfpcLkGuJZAWYqIziV5wfajNU2wXHmYNlRdeq1xnzu6vODR1cu9RsUL 4iTMYqEI1y9RMGfC+pO1cZ+lHnJ9JMFeOIoP0KUjuhAZF5rIa3uNL4exGFzVlW8Sts XVmsDqbi4KJFh8ZMDAFFDHGbFxtGHrL/SAQN8kH2+A5x165gFTjFtLe0JBoNzhARsb 7/cjIEe29B4HgugJ7S3CAdqJzGpWFH8suZ5ul7aEb7ZuiOWtgdwskUveNjAqm8E0yD /qM7J+Ziz5eV92ENOr4ScJxkRaNKBeB4U0D6en7SWSTA8YyGaCsxwajqB4FNumbkCj t9RfN8iM/MjMA== Date: Wed, 29 Nov 2023 16:32:00 -0800 From: Jakub Kicinski To: Chuck Lever Cc: Jeff Layton , Lorenzo Bianconi , linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com, neilb@suse.de, netdev@vger.kernel.org Subject: Re: [PATCH v5 1/3] NFSD: convert write_threads to netlink command Message-ID: <20231129163200.77c7e788@kernel.org> In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 29 Nov 2023 13:31:17 -0500 Chuck Lever wrote: > Before applying these, I'd like an Acked-by from Jakub for the > tools/net/ynl modifications, and at least a fresh sanity check from > Jakub on the changes to the nfsd netlink protocol (though I don't > anything problematic so far). I left a couple of suggestions, looks good overall.