Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp852997rdb; Thu, 30 Nov 2023 23:28:26 -0800 (PST) X-Google-Smtp-Source: AGHT+IEx851m+tuqaYusb0v2iml70Dsdy17WOqIgWCaXV6Zh+YTMy+BhKCZJZjm3sNjHYO9mPPN3 X-Received: by 2002:a25:ac46:0:b0:db5:4f82:c915 with SMTP id r6-20020a25ac46000000b00db54f82c915mr734800ybd.13.1701415706477; Thu, 30 Nov 2023 23:28:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701415706; cv=none; d=google.com; s=arc-20160816; b=C0NPRQnNPgt5VtHRZ1MNJlbN8EfSh1b/P8aADXG2AzWyHZ1yG/DbSNd3Gm6mO6JfDq cFCGZhoCE81z/5oRIPggtjg06xvbxA4UGwETmzFB82nz9SM4GgT1Wbgi4knmIxBk6qam FogHr8I/+BIivaN5kkQqpgY9lOEr3gHKtmUbb7Pqiww4BXDoCjCdqokiJAuBfXOKRsj9 FC3gcQMiQb4OxkUivvRO6TRR+Tq8u+A488nOXff0ndInVa5hyh+kqO8oSSzeMNicY0fR Xu5axy9SPlpFL1Qijnnb85gUXlwo50GHIEEhUj925RtmSvfTAZS6qRwdeQYpD5LL8qqS aWFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=jLKdw6R9VytObYM4oF8Cheep+7uXqokXXX5yUmyUj14=; fh=tv7lyJZ/AToP3nPck4FJL05xmwCglEkAtFAjmW3q62A=; b=rCuA9J03UxhAjriWUE9i6JrL1IM6ThL9GBixQho6jAlru86ESyDl5KT3GMWJtdZ48w 9fdzpyrCZ7i0yDkD55acrPrvmNYiWQkZYwEqvLq0yzcKYjcv8sJsmxjZI0RnrLBIIb4Y 6Eh+wHkeeDMqx/B0Q39Cu0DOX9z7/ibUzNFIhiQ5m1IoI8Tgrs3ZgmctTbRLob7zVEVK BBk/q+OdLIc0o8vkwZOEZ9gTM7dFU4jMF9sc/SSXnq7hSXWTBgVBG0Rt6fFp8bdgEIpf cMRf29VsK0l1ODg8PAtB7QlPTY7H85JSSy0fK2wz8sB67EXA0nd4NA+HvU269AAv1KDT 2V5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=chnlz0FU; spf=pass (google.com: domain of linux-nfs+bounces-244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-244-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id bw21-20020a05622a099500b00423990dd28fsi386868qtb.135.2023.11.30.23.28.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Nov 2023 23:28:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=chnlz0FU; spf=pass (google.com: domain of linux-nfs+bounces-244-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-244-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 2BC771C20957 for ; Fri, 1 Dec 2023 07:28:26 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 1686314AAA; Fri, 1 Dec 2023 07:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="chnlz0FU" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E649C5953A; Fri, 1 Dec 2023 07:28:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6BD78C433C8; Fri, 1 Dec 2023 07:28:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701415703; bh=/NE/moAh3fdf/+5E8j12TTLl01THg8y5hZenqpkVy+w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=chnlz0FUPAbKWmxlXhM0448J00ZCRI+MsdKXiXz7hHMr9PVKSfs2OMTYI1pLAhhLR LUdwbXuRl84pb8zb/rq35oJZBJM9qQzBtqc8P6hFQDReZKzRKHQ4XqYSJXvPckjqIn ck2fo83SqEECXBmX+JL2N6SwT9vw1RYbqq5mStSYV8JwZ6enIaQjL1Ci/CoMeB0t0N +EYyAAxKZbtp7VjtispSEI1obQruvv6YWNObRzV8DvyCFxIOZitrRVjvsVFLYc8p0Y K2AobjAcoC0CYzDjdHpZPBRJ1pHw711zWLt46l7VC/RPeEHVerdKO7GmmMzvnsTMv+ Pk1KaAlab5PIQ== Date: Thu, 30 Nov 2023 23:28:22 -0800 From: Jakub Kicinski To: Lorenzo Bianconi Cc: linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com, neilb@suse.de, netdev@vger.kernel.org, jlayton@kernel.org Subject: Re: [PATCH v5 2/3] NFSD: convert write_version to netlink command Message-ID: <20231130232822.1dee5243@kernel.org> In-Reply-To: References: <8b47d2e3f704066204149653fd1bd86a64188f61.1701277475.git.lorenzo@kernel.org> <20231129162832.4b36f96b@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 30 Nov 2023 11:32:17 +0100 Lorenzo Bianconi wrote: > > u8? I guess... > > here we need just 0 or 1 I would say. Do you suggest create something like an > enum? Ah, sorry, thought I must have already complained to you about this in the past - netlink aligns everything to 4B. So u8 or u16 or u32 it's all the same size at the message level. For the