Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp1283048rdb; Fri, 1 Dec 2023 11:42:22 -0800 (PST) X-Google-Smtp-Source: AGHT+IGUWSJF2t7EtayVMNEzknJqIIE2Wr9hw8bU927susPSB+pewBf7UF86ZJ6O2duRz6f9XyRj X-Received: by 2002:a05:6a20:5492:b0:18f:97c:975f with SMTP id i18-20020a056a20549200b0018f097c975fmr9760pzk.71.1701459733886; Fri, 01 Dec 2023 11:42:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701459733; cv=none; d=google.com; s=arc-20160816; b=eblkML9fWYJiDr9A8Dt9blB/0gw2IGwEJQf35UJYcr2WlDoQKG3TGw9gD6pRyUUzq4 VzUr1eRd1dEFxSuFRR5aNXdOYM2IsFQ1IvhpXICYucrAkn//GaV/4eyr0Izx0wrn8vmd QGmqN+04chVozRFk0I+N+J9vckm93jLLtDvQa40OjEaXI9dGAwVDa+wkQWRe6rCWbQ0T XrQIbY5WlP0FmklMCCELz3+fqYwiYeVG/DUBYvRAsr8qy6/Qf8YC943s3aYx+BCV1A5C 27sYaKkEhiojQQmcq4bl+Th1dMRpEenITEvs+Qi8FDyplg0+ku7yTtzVL+WQ3ZXpJAHI EbwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=ErTBYvi7SZGb4GfuMjTtkAdp5NyG4fmuiIlOwg3jEyQ=; fh=2G8vV/twklXuIDat4PvoYTuAifAwKWy0lXEyRgIEHLQ=; b=U687iTDIwU7Sb03oypg4cvEPuPfJ8fEF3LnuNjjF154NdN3cOjMfV+k6OhTL7/cYJa yx22ctEKriEN4+jfELkRyPUHySb7tFA28/ko7v10wyB5HhnC7hYEU6MnvEvpj8hPYwor R2OtiWTSJvJdrxal49rUQhD8XirfrtT4ZyPqctt6rm3LPrr0juDF8VL/i/iKTNetTw9h hxDUWSpG/jbGykm9omKFoioXikD+L1TD7gw3kKSKg5Gsuy2UEMM2A/bK2mq7ewFgYwX+ yV7zw1JAn9CL63i8rUE8NYR3Z/s2MmS8nPtCYxz/MHaodab0S43DrMWicwV50pTcWdpd jmvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=JQnP2VPq; spf=pass (google.com: domain of linux-nfs+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-nfs+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id a9-20020a656049000000b005b95fbb1750si3966463pgp.113.2023.12.01.11.42.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 11:42:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=JQnP2VPq; spf=pass (google.com: domain of linux-nfs+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-nfs+bounces-246-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id C8137B20D8E for ; Fri, 1 Dec 2023 19:42:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 59CE04F8B6; Fri, 1 Dec 2023 19:42:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JQnP2VPq" X-Original-To: linux-nfs@vger.kernel.org Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C6239A for ; Fri, 1 Dec 2023 11:42:05 -0800 (PST) Received: by mail-il1-x12c.google.com with SMTP id e9e14a558f8ab-35d374bebe3so1861985ab.1 for ; Fri, 01 Dec 2023 11:42:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1701459725; x=1702064525; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ErTBYvi7SZGb4GfuMjTtkAdp5NyG4fmuiIlOwg3jEyQ=; b=JQnP2VPqhFR7rSRmsKQLd5n0thfxcGGeLHu//ZNG9RRysupC+O+ioZ8993+RYOwdaR Kom1IHV0OoPqIUiiPcRjGzRDkKvZ7xSsYgjQTH8yjXbH8pQVOYS78783xS+Yel60ujUW qtlyq+HloU0vbF9qJPnwtpPjoUhcefVMLSugrjaVjz3wh69VBxoN1ZKx5B0rh2ClXgJa ABkX95Z0fcfk7rJYGXHKRK2pf1z+tcD2UmITgfwkk1XrG7M57pCgPcf1MUrbMA2hnesl CWl2e1nKZFbO0uL3uoTKYna1CPLg7Rvmp2ymXah+FUKmnsW4OSEaInuFIH6Hesc0F45H rG9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701459725; x=1702064525; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ErTBYvi7SZGb4GfuMjTtkAdp5NyG4fmuiIlOwg3jEyQ=; b=WzkfaCT1Q0Qyrpc06kOu8IiCawWtJEYdS3iOk5ITszEqDGMQRIL8Oq1v/JZg2bPLd1 HJ2bwEnhNfPCsfOaRfk2a7Uhmpru+ANwe0+37SL4o09HYTLRaChRHjGyrgKwphkUR5et 1TVM5GpNhouGJlK34VuEPPMwhBifQYe0i5y2VuxGEWdP0kEbJmpWJq8l7cLnnBFFW+dS xJvZxHGIl+7+GRCzv3UD8zVuvBoDN7EMk1J0hUfBh1ITfOCrW+1NNF+vN//tyMzRE37E btHNAF3WTuElIh+BbxAtf966ky3mUJ5X50i4fUZZayB0QXnwxuxHPnKcO0EXlUICTViS FAjA== X-Gm-Message-State: AOJu0YxvphtuyLMbnvelk+lmmG1k//NgtYrSpXpHyqjzhsz4UeblZmXt nj2UQHeYlfqqGQS0gk50vzBhy0dUswU= X-Received: by 2002:a05:6e02:1907:b0:35d:5779:4a5 with SMTP id w7-20020a056e02190700b0035d577904a5mr1160095ilu.0.1701459724709; Fri, 01 Dec 2023 11:42:04 -0800 (PST) Received: from kolga-mac-1.attlocal.net ([2600:1700:6a10:2e90:d571:8cad:241d:7d80]) by smtp.gmail.com with ESMTPSA id h3-20020a056e021d8300b0034fd4562accsm1262917ila.28.2023.12.01.11.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 Dec 2023 11:42:04 -0800 (PST) From: Olga Kornievskaia To: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com Cc: linux-nfs@vger.kernel.org Subject: [PATCH 1/1] SUNRPC: fix _xprt_switch_find_current_entry logic Date: Fri, 1 Dec 2023 14:42:03 -0500 Message-Id: <20231201194203.20444-1-olga.kornievskaia@gmail.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Olga Kornievskaia Fix the logic for picking current transport entry. Fixes: 95d0d30c66b8 ("SUNRPC create an iterator to list only OFFLINE xprts") Signed-off-by: Olga Kornievskaia --- net/sunrpc/xprtmultipath.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/xprtmultipath.c b/net/sunrpc/xprtmultipath.c index 701250b305db..74ee2271251e 100644 --- a/net/sunrpc/xprtmultipath.c +++ b/net/sunrpc/xprtmultipath.c @@ -284,7 +284,7 @@ struct rpc_xprt *_xprt_switch_find_current_entry(struct list_head *head, if (cur == pos) found = true; if (found && ((find_active && xprt_is_active(pos)) || - (!find_active && xprt_is_active(pos)))) + (!find_active && !xprt_is_active(pos)))) return pos; } return NULL; -- 2.39.1