Received-SPF: pass (google.com: domain of linux-nfs+bounces-274-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Mon, 4 Dec 2023 09:33:35 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Jeff Layton <jlayton@kernel.org>, Neil Brown <neilb@suse.de>,
        Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>,
        Tom Talpey <tom@talpey.com>, linux-nfs@vger.kernel.org,
        linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] nfsd: remove unnecessary NULL check
Message-ID: <ZW3jP7Z1OpLn+45Q@tissot.1015granger.net>
References: <0cce4257-6c22-4c0a-b769-b946990413fe@moroto.mountain>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <0cce4257-6c22-4c0a-b769-b946990413fe@moroto.mountain>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?UR7brwLrw2h3pDgsx5oYHS8NAMFdI/So+rewvEKyRZcxXzvMS29JKNcAFlyo?=
 =?us-ascii?Q?C9SEags48AijspEM55WgJ2JRvdo1XP+UfYCE8qj/ETAyq3QdnwGw16Ar/mkh?=
 =?us-ascii?Q?O7+4P0VKmCoj6El1x0fPAGPASZg90Ww7NX0KtvemDiF7SaGG9MTeadm9zqbT?=
 =?us-ascii?Q?ifrgZSS9/dxP5pY7iLBXYT3Co1deULuF9eZnltBH8HsULZ+RXyoiomUGEk2q?=
 =?us-ascii?Q?CxhkIRCK7rzfhZoFyRIcr7Opy+ooVSZVA3LJO1bzwhrvW1sUICCZeEKJnqSB?=
 =?us-ascii?Q?YT+RgjtO9/rTvHyYdoCJ6nfrOWzVO1UX60TH9PUHAtEn6JlVrS6fcrOI5hDH?=
 =?us-ascii?Q?4SLv9+H8UBm8Ykoo3rtDPQ/jdxyioEQSuO54KsBx99mPtZv2QrLpd5T7xR9t?=
 =?us-ascii?Q?0Bb2lksgTDVQMiyCaGt+7k1p3xN++k9NECmHDo72+PoncleBWxZd3OeHOUVO?=
 =?us-ascii?Q?llojilXENW+pUJl5hCxnB7Oi4P/6zseeGPcL5HaWZNjm7UuXC+nxcpOEoDfp?=
 =?us-ascii?Q?gNe9Xfjx4cgQnEUG2nJyk6mkA8pG9jtrwE3kQjrWK6bFFWcN3pTDNSW8wm4J?=
 =?us-ascii?Q?xVRI0VlAZFrqvZvvYd/POXi8Ukxbs7avpIx3VTBRoSqZ1ZDmvkfnvw2X/8Aa?=
 =?us-ascii?Q?6ZxM4QLAQxv7CI5nLgDkIMXr+EzRGtzHEU+Fb3isM8he5CUKDaET7d2XpS8U?=
 =?us-ascii?Q?yPNySISpMNpv3jxmGNaHQ1WCls7h2P544Bv9Exnov/aJDlmgRFeZQLenJC5V?=
 =?us-ascii?Q?gajctLIX7nSHaGJc8QgZfhB0kz76J5Q0MS9EhTGcItdHJVF6bZIZOdyVW1n9?=
 =?us-ascii?Q?6SmJvE8SesIw9kr9rweGKP21ZItA7ySyl/xAw+139Y/++taJmVufVbApssOy?=
 =?us-ascii?Q?wuWgm2LUe0Ul8ucLRjLMpta/wNDEuKRgNvdWDO2EPqrXBTpXBycxZoOWa8cq?=
 =?us-ascii?Q?oYDrxyTMOx1cWjegKvJO8BpduVEFaNpzKO7UPmjQCGZG4t0ta74x4M0yUgkM?=
 =?us-ascii?Q?pz0yN2/brT8TLD0qGaPAbuhQ7j1zJrCE+y0zmiGRDFJqoO+qcNG058PPZ5pP?=
 =?us-ascii?Q?LNwVY/sPcE6qpo80d/tkpFOMbNuJfbsETK0eVwsPOAQMoAwiPg+EiTtXwHfz?=
 =?us-ascii?Q?DDxFIRFmRzcGL4ZfkPfZwWfOPXtJynHt5azGYNL6hNsGr7BNwOVh+5QIM7Do?=
 =?us-ascii?Q?1kRpGcQiZ1qlmuKPVqhwGvh0jg9d9yshsxUjkc6DW6De9XvTmYl4NYYUVfVf?=
 =?us-ascii?Q?8laQz4SCMgnmAU0OPWXTzFVPuYypM3GtP/VS/kUh5Kfpmturn3m4LDqrctOb?=
 =?us-ascii?Q?OcCyc04ab0QYD3IcG8JV3RQfAFXMixC7KDp9GEyDxyOGunGpfyOAt+zdz6h+?=
 =?us-ascii?Q?w8OA0FFdxpOmGOAv5LBQWNiPAsbOT8BpwwSgaTT0EtAhPiY07TqgmFvHoIu/?=
 =?us-ascii?Q?R/MoCuVNhWpP7hNwNwSMvCyvkGDIWLj4crX/cl0xhAae5ZuDMxiHHUZrto3+?=
 =?us-ascii?Q?LG9LhhFvmUqcI85SfLSogfco8XzjoH2APnsgzdWMpsA99Yt+XV3rCnw4JmC0?=
 =?us-ascii?Q?ocGgZME3XH33cg8aWfUK2Re8Qn7Cqbt5+RqpKrYRVS9h7HdYhrdFGQVyc0VA?=
 =?us-ascii?Q?rw=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Q7lNK5u08Oo29+nwR9+VoMtU50Wm0vYvmLOgBsi+n3EmSi4QNVlkw9iA1IcBkyXwsWJrFtYq96WYyDJLbLCMYtc7FA1aBgu0gFCEZgAfrKoPDRKrk5Gln3s9xy1s+NSvNvYaAB0QVWIgzMF50rIa5CYjUnVXyK/mQc9cBqPw5NdxLGzqku6hkSdutlV+q17Qk/dXyuegIud5mB7ODTy4Nm/DXAfVnr4CNL/yuJytjQGoBUZsy4UXTDOzin1KwiadPmH0IAvS4XduepUd+9yqQnLjRL5Wla/alEldJ4uydl6Dpqv4MpOjIzfR2S82FTV/0vm0tT7xDwvybyJh2P5qM+AZ7nW04C+3EsigrWa8xWc6fyZuV631CpItdtZJO213sy2jQ2+2G3wGm2ET5mjh2EBSWjmDGh3+TJD6Ureo/ak6609iSDmDcNwbR7/Xh3sNkImttQJQKS655UpXIhO/M+XDOkgHJC7FuZT/3UcCAZSvB0tTUMsD5/25sWsepkfDY1ZrOJQPR4QK9LNF3dRKfRsgLYyPgfGKUjtpZ21tu/kmaVsdqt3U5IC+HFozx5Di7hl5o/rJ8ktjRbIR+qOgpr6xXT/5MFut8RKVAE6URJOWrbf53+DQmUu50sbUwoGPeuXe19Nmg8UV+wvJzDQIkM1iWBFNNuseEKoErOxmWbCXPss4Dr8WK8+43LzqvMsMXzoY/P9hH4iJGgMUAhcn/i4zWw22RXPFeok+jj66bKXyzXXJQ9EDS7261sk9NWtOJAcp9SzStBa7ejwpDLnHHAOEcNGt0YOCfpUH9A6j/Okuwd407NMSGMDof555SzqLqTxYVPdlcilDLjkDfFHbCB+cTJEVx1pkNpOXV5bsbbYTo7QLLpsCRimfvRhJfMyLdmZc6SazF/VoPeMkZqaiUw==
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ed57592a-59cb-4ed2-dea1-08dbf4d60112
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 14:33:38.2507
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pbBpg6EtcdFd7ruDygJForxFdZsPeLXNE1SjnZ70UoaLBzSqWqBd1vMLak6T1zw0kgQDn5SD+agBvPTP2+K1ew==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB7482
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-04_13,2023-12-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=949
 adultscore=0 suspectscore=0 phishscore=0 spamscore=0 mlxscore=0
 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2312040109
X-Proofpoint-GUID: 23FpZlZ9e7vbhmwxTgug8eE_bOWiLL1q
X-Proofpoint-ORIG-GUID: 23FpZlZ9e7vbhmwxTgug8eE_bOWiLL1q

On Mon, Dec 04, 2023 at 03:30:06PM +0300, Dan Carpenter wrote:
> We check "state" for NULL on the previous line so it can't be NULL here.
> No need to check again.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202312031425.LffZTarR-lkp@intel.com/
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>

LGTM. Applied to nfsd-next for v6.8.


> ---
>  fs/nfsd/nfs4state.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 40415929e2ae..fb551a3db1dc 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -6639,7 +6639,7 @@ __be32 manage_cpntf_state(struct nfsd_net *nn, stateid_t *st,
>  	spin_unlock(&nn->s2s_cp_lock);
>  	if (!state)
>  		return nfserr_bad_stateid;
> -	if (!clp && state)
> +	if (!clp)
>  		*cps = state;
>  	return 0;
>  }
> -- 
> 2.42.0
> 

-- 
Chuck Lever