Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2760786rdb; Mon, 4 Dec 2023 06:58:04 -0800 (PST) X-Google-Smtp-Source: AGHT+IFfUwiXAxypFMcY/I6HorAmREfBZ195oi0WNedjaKalb1Opo51KJNSbWOCpV57SvXMJZlhP X-Received: by 2002:a05:620a:490d:b0:77e:fba3:3e7f with SMTP id vy13-20020a05620a490d00b0077efba33e7fmr5704526qkn.72.1701701884542; Mon, 04 Dec 2023 06:58:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701701884; cv=none; d=google.com; s=arc-20160816; b=fKWIhGQS+riltkdF6QuabKHtkH4yF3gjo6XwZ5yLZIlYWFv/d4tvzjMwkHQfJqf6Ti zIIQeKWl7dJlyZBCUK+jVnVjEiH7jWf0PIenm/tKDNcyW6j5VhxtHYzmd9qhEowHtWOS f0c0Tdj79pPFffQgymYmJKtiGtbkaQzM4yAC/jb4WHHF1bwlsMP3WaffEaT6dABS74CZ OOXBfcSsJTlEXrGQ06nX2bky16xdrNIxdFfRlxRomJcWbHytNWmMR9HdBfm39zHIsGm6 rRPrtT+S8KZtXqHHo3ratZUZYRmNiZR2YiTScDWh07LVfwUSObXvevVZ585F9olYiFIT JATA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:references:in-reply-to :message-id:date:cc:to:from:subject:dkim-signature; bh=Qnig9DYJPSJZjcIygr/E9Vl3N8x7kf5cI4Nx9qc8QQA=; fh=WfGVbliYpqgzl5GprTVUBQR8rnRPHqjfX8LKlqDYYGk=; b=kp7BrygTm9419imrnGKgfp3oVCz5C2BK2xFu/JJvyxOQ7SpfojNga3QITYEJ+Ylg0M y2JQsZ/8gLzY230Inz43oDtW8Q8UJ5NZdsDnT0YV3snuvXex7rc5q8uWmUUr1oje5nVw KvUddyq0W+0TXQr2L6ddjYlSS84vxuR16m8VyHV7kri9axCf9Wx2rRWYvQj7iY+5sVTV lcUk+pIiFYgQlw53DFWCZbokKXgqcFGWDQ9tKjjODQkVGQepdOI1Re5SQMDuI483bZWH mHEErxBD8TP+/yXXXlQhLJ3tJTSwEnFaQVcOrDyepuUnhlP8rENzXe4kEnUJRdvU0e+A 1bfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MQWUTDZl; spf=pass (google.com: domain of linux-nfs+bounces-290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-290-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id o1-20020a05620a2a0100b0077efdc96f7esi5522177qkp.66.2023.12.04.06.58.04 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 06:58:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MQWUTDZl; spf=pass (google.com: domain of linux-nfs+bounces-290-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-nfs+bounces-290-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 475351C20C2B for ; Mon, 4 Dec 2023 14:58:04 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8669428E16; Mon, 4 Dec 2023 14:57:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="MQWUTDZl" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6103D28E07; Mon, 4 Dec 2023 14:57:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AA133C433C8; Mon, 4 Dec 2023 14:57:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701701875; bh=S//QebyXq63Q3wfSqLgsO86x/iD4dK/oGX7kMMCPE3w=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=MQWUTDZlREulJDq4LCEvJ1PtphjsaimrAGOcrsCd95QaCLTa3IdUq7fSncs9q8RfA nnnj8xx1Wh6fy9Ucn3sW0a8jyobWzH8pYuQ9PYWSFYNzIhMv7DZjR8vDkUleW1iXk1 EAkHsAabD/LSGhZ+MIW6ugY8ufQMrRwiUptkYg9cZrIB2pX+rx+Lq6Zc4uk1fJQ9nB FBmq7+X2WtZpL2u6R1i++PnxT2xnkO0UQrcB89HHDCa7JUZ1pErWZsEASsvotbT/1w u5a5iEuLsh0l4hYaU/60dTEoh4Lk0/VS50CPgffZU1N/vGjl6pBVxks1jFY6VytUxw GERnAhWbK9+RA== Subject: [PATCH v1 15/21] svcrdma: Update the synopsis of svc_rdma_read_data_item() From: Chuck Lever To: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org Cc: tom@talpey.com Date: Mon, 04 Dec 2023 09:57:54 -0500 Message-ID: <170170187471.54779.6812868392919776920.stgit@bazille.1015granger.net> In-Reply-To: <170170144201.54779.9877683240030806819.stgit@bazille.1015granger.net> References: <170170144201.54779.9877683240030806819.stgit@bazille.1015granger.net> User-Agent: StGit/1.5 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit From: Chuck Lever Since the RDMA Read I/O state is now contained in the recv_ctxt, svc_rdma_build_read_data_item() can use that recv_ctxt to derive that information rather than the other way around. This removes another usage of the ri_readctxt field, enabling its removal in a subsequent patch. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_rw.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_rw.c b/net/sunrpc/xprtrdma/svc_rdma_rw.c index 63546e495cb3..1953f3983695 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_rw.c +++ b/net/sunrpc/xprtrdma/svc_rdma_rw.c @@ -892,8 +892,8 @@ static noinline int svc_rdma_read_multiple_chunks(struct svcxprt_rdma *rdma, /** * svc_rdma_read_data_item - Construct RDMA Reads to pull data item Read chunks - * @rdma: controlling transport - * @info: context for RDMA Reads + * @rqstp: RPC transaction context + * @head: context for ongoing I/O * * The chunk data lands in the page list of rqstp->rq_arg.pages. * @@ -908,17 +908,16 @@ static noinline int svc_rdma_read_multiple_chunks(struct svcxprt_rdma *rdma, * %-ENOTCONN: posting failed (connection is lost), * %-EIO: rdma_rw initialization failed (DMA mapping, etc). */ -static int svc_rdma_read_data_item(struct svcxprt_rdma *rdma, - struct svc_rdma_read_info *info) +static int svc_rdma_read_data_item(struct svc_rqst *rqstp, + struct svc_rdma_recv_ctxt *head) { - struct svc_rdma_recv_ctxt *head = info->ri_readctxt; - struct xdr_buf *buf = &info->ri_rqst->rq_arg; + struct xdr_buf *buf = &rqstp->rq_arg; struct svc_rdma_chunk *chunk; unsigned int length; int ret; chunk = pcl_first_chunk(&head->rc_read_pcl); - ret = svc_rdma_build_read_chunk(info->ri_rqst, head, chunk); + ret = svc_rdma_build_read_chunk(rqstp, head, chunk); if (ret < 0) goto out; @@ -940,7 +939,7 @@ static int svc_rdma_read_data_item(struct svcxprt_rdma *rdma, * Currently these chunks always start at page offset 0, * thus the rounded-up length never crosses a page boundary. */ - buf->pages = &info->ri_rqst->rq_pages[0]; + buf->pages = &rqstp->rq_pages[0]; length = xdr_align_size(chunk->ch_length); buf->page_len = length; buf->len += length; @@ -1141,7 +1140,7 @@ int svc_rdma_process_read_list(struct svcxprt_rdma *rdma, if (pcl_is_empty(&head->rc_call_pcl)) { if (head->rc_read_pcl.cl_count == 1) - ret = svc_rdma_read_data_item(rdma, info); + ret = svc_rdma_read_data_item(rqstp, head); else ret = svc_rdma_read_multiple_chunks(rdma, info); } else