Received-SPF: pass (google.com: domain of linux-nfs+bounces-298-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Mon, 4 Dec 2023 10:00:39 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Chuck Lever <cel@kernel.org>
Cc: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org, tom@talpey.com
Subject: Re: [PATCH v1 00/21] svc_rdma_read_info clean ups
Message-ID: <ZW3plwcQjBYowR0d@tissot.1015granger.net>
References: <170170144201.54779.9877683240030806819.stgit@bazille.1015granger.net>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <170170144201.54779.9877683240030806819.stgit@bazille.1015granger.net>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?eE/qIqA7HMeflE3uQgYvKnabs3mAXrn46oiWvVA01+2U6lM70T4ESk6Zbxmb?=
 =?us-ascii?Q?TWd3p/1zK2EPXve0aLvYqDLAKSfytQFfM0do/VzCURPWA8Oz6VLr/2PymHb6?=
 =?us-ascii?Q?5U1LK7RypBk8SfwlZXeNMzeDFHBcZfQyU28JXOZBZhd7h1NXP/r+9V5nF2KD?=
 =?us-ascii?Q?fTyDcYN9UlFT1qCf9u8erqxAXT8zywMLpTA/PHw++AwA4n8gH03Vf+QsobzC?=
 =?us-ascii?Q?JZ+gbtlLgccNVfrfMIFWDfIUsVDqj603z0JC9yIhhGYNKuCc6SPnRFEaj6gc?=
 =?us-ascii?Q?0aTSM7b+cKBwNsE2/E7avJ3+ZGkrK4fn8TxOhnbAGKUNZPrmAT65NRXNn1d8?=
 =?us-ascii?Q?whiFYgqeZBHms+5DTL/DxQOJAAQhQG5sHZBE5w8u6tKN27SFIrswMzrbaL61?=
 =?us-ascii?Q?NiTS8LDqdgscFupO5DDuEz5jBl/jLAujwjtKHBJTQuLtH4DMorucOuzJ7ipO?=
 =?us-ascii?Q?kS6URKz9zOYeC02yPMj/BsY9FpEYyJxrgWPOpv5ND7Bgi81TSd7wW2rNoyX0?=
 =?us-ascii?Q?IUjm5JX9vgCNxMDKZYlIOw0dZgueDPvKbsEplzracJpYaUG2+oXQ/QVnzm/Z?=
 =?us-ascii?Q?ewq+jMiISiMUPRUBlmWH3ubfKmr7ik6mxWO1L2EIZe3DDGx/IJ2lyiXolbZp?=
 =?us-ascii?Q?8oK/T1BUEkjMygc6dHPoteSA1XSB9EEhXnXI8z6sUUZsfHgLGuv8Cjbbt7Df?=
 =?us-ascii?Q?pY+974bs+7zmLzsaAeAkt4IwrW+Cd5g224t8LquC7vSjcItSZHLkEVQxcFmh?=
 =?us-ascii?Q?tzrUbtMsKKeG3CJnSFVdaQ0QyyfxxCYVH6UvoFTYGsvTJnF9eLMfehZo6RWW?=
 =?us-ascii?Q?FG8sTB5mq3wN8WWwhOY4xFcdkVSI9zY1/UFrnKEyN4cBaKzLWrPrEw/Gjrg1?=
 =?us-ascii?Q?hb+XlkcDqT7WhEG0fFotfJAro+Nn4JW+dmns5NVQVTH457m7t3X3UuZTg+iH?=
 =?us-ascii?Q?7dUHLQDXOURPTkLjkw2AOJEJUWwQgSSLzIc28X9N3hI+IuAFsY+yLC0kd2ir?=
 =?us-ascii?Q?oKrskaJ8ZLTM+iZ8YlWIXj4E3uMCSvhkFDz5Bgtj7ATgD8hhTQGCJEbmlFOs?=
 =?us-ascii?Q?fBTYdqa/NO8WlZI1bddGobZtANKkTkHHOhSYlbdnJiYBMwQpH8gNCpXcKYzM?=
 =?us-ascii?Q?PjBbOjBNBJCfCb8XY2gFKHlyeHEksCgEsg3juYAUusXYuVk5p2FZi9B7Ct3W?=
 =?us-ascii?Q?w03LfEYWLB53nBiPlz0el+RU5bUPwDEJqNNhmClJw42ZpOwUXaeXROIZ0lYY?=
 =?us-ascii?Q?vIceVITA3H4b8voL723DwXC04lcsfrw3/Bt6R3m9kf3WAbNnpdqW1f3/9KsW?=
 =?us-ascii?Q?C2Tx0SjYveBORqyslBPG9szkSBGw35vPToKWFY8HAxEN76YKXO/ErMO9B+5p?=
 =?us-ascii?Q?SBcIIe6oriCmTIZ52cakBUj9FM7T1e9PM55a+ApOBf+0dzEcqsY4RuJgHiJI?=
 =?us-ascii?Q?yJkRQ+529ALy22pymG4Xj6K1XGIl+Z51xOpMM3pQm2V3sKRk+DgpupZi2UjO?=
 =?us-ascii?Q?HKSarIRXLpLdDC1RVi+q5uHXnL3byR9RJb51dDG2K7Y+H6p1uEmxthvru7Am?=
 =?us-ascii?Q?WaixbnqrFBe5QvOmfsMNjQa+1P7WkfwgtPa/wkp5Pjk4gdBPTyhfwHDzcXKm?=
 =?us-ascii?Q?VA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	8S1P7bjXFCk/WDSsrAfUc73JyNqsabhKVillcMSthiaDOUFWQzaax/BZzoF4yA0PinKgC5MaEvTFJwTU1VedR5jRfIHhpvL2RWyBE8iMqAuLGUJPv2/GyDlrxJfrwa/3V+6M4L9nqMYQstfTy4BbgB+8b7YO7shwZlH3VaNQ3DJTqKiclHEteZglYnYGOgL3yXv8kRYuTzm2Bfu+aNhnLlIYfcjrTOVhb9gkkJq634HtUMtiBm4bCnXZtSL5VSHVL3Wktapj0yiqBqNcUBp1/3TMyqPXk/oi0Q+0OHUK75Cycp3wH/W+cnDdJnDPsM7Zlcxt6tcpCGIkmCiUdMFB6fbyIOSRJeXEWVtHFIRethF0Nuu4lkZhBLUoysEuSraBA6gDGDUru+GZfrHCrwjV1CJQteoT7sRkPV4F6A1DO+xyTcMMBuvhHggmQKz3qhy7nqWBrZpbbXXGcYJa+t6J2DgwG9cyZ5xEVTnqs+aC8fq39zO5lkTUAATMCLl785/tlSDkkvmhhy0kbr2ZrLzyExe85wbBzYNQUbkEPfSBQjbBhvHLkmwqMWtWE8mBU5L3NXq5LBGOlXNIFaIcSLL3hIIkCbdQc0JcE0TDCO88WdzwuRBzCJK2OMhstRLR6CfoTLo6YqfkILOxAD2E5jwagpOxJU3ArwPVZ/VdbWcAyaRyCghnPgoOzw3YiAHMJlAywEaSR68f2sjP4PmVqtTemuzL7RcPPnM36LYKCl9LJPS746QYWHV5Vt8NFgskAP70PIRYUoZUcfAq6Gl/C4Q1fMaCAbuA2Kqjncx3UAakFdgpAIuUElccaQ8kqr5KFQKg
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ba9e1164-4d87-4cc2-f716-08dbf4d9c904
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Dec 2023 15:00:42.2267
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TfrvGSkl7qO4B4csNUcpiq105kF2JR6WQlr/ioXoz1rPnxtzdIMNX67Jo9YZCqHqJFwcElo4rkncPq7tqVAPPg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR10MB5180
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-04_13,2023-12-04_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=655
 suspectscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311060000 definitions=main-2312040113
X-Proofpoint-ORIG-GUID: 1s6FYiEscnc2tKAyHoyyxhqoQ3oc3co0
X-Proofpoint-GUID: 1s6FYiEscnc2tKAyHoyyxhqoQ3oc3co0

On Mon, Dec 04, 2023 at 09:56:18AM -0500, Chuck Lever wrote:
> These patches are in preparation for more substantial changes to how
> Read chunks are managed by svcrdma. There are a lot of patches in
> this series, but each change is narrow and no external behavior
> changes are expected.
> 
> The main benefit of this series is that svc_rdma_read_info is no
> longer dynamically allocated.

Note that the full series is available in the svcrdma-next branch
in this repo:

  https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git


> ---
> 
> Chuck Lever (21):
>       svcrdma: Reduce size of struct svc_rdma_rw_ctxt
>       svcrdma: Acquire the svcxprt_rdma pointer from the CQ context
>       svcrdma: Explicitly pass the transport into Write chunk I/O paths
>       svcrdma: Explicitly pass the transport into Read chunk I/O paths
>       svcrdma: Explicitly pass the transport to svc_rdma_post_chunk_ctxt()
>       svcrdma: Pass a pointer to the transport to svc_rdma_cc_release()
>       svcrdma: Remove the svc_rdma_chunk_ctxt::cc_rdma field
>       svcrdma: Move struct svc_rdma_chunk_ctxt to svc_rdma.h
>       svcrdma: Start moving fields out of struct svc_rdma_read_info
>       svcrdma: Move svc_rdma_read_info::ri_pageno to struct svc_rdma_recv_ctxt
>       svcrdma: Move read_info::ri_pageoff into struct svc_rdma_recv_ctxt
>       svcrdma: Update synopsis of svc_rdma_build_read_segment()
>       svcrdma: Update synopsis of svc_rdma_build_read_chunk()
>       svcrdma: Update synopsis of svc_rdma_read_chunk_range()
>       svcrdma: Update the synopsis of svc_rdma_read_data_item()
>       svcrdma: Update synopsis of svc_rdma_copy_inline_range()
>       svcrdma: Update synopsis of svc_rdma_read_multiple_chunks()
>       svcrdma: Update the synopsis of svc_rdma_read_call_chunk()
>       svcrdma: Update the synopsis of svc_rdma_read_special()
>       svcrdma: Remove struct svc_rdma_read_info
>       svcrdma: Move the svc_rdma_cc_init() call
> 
> 
>  include/linux/sunrpc/svc_rdma.h         |  30 +++
>  net/sunrpc/xprtrdma/svc_rdma_recvfrom.c |   1 +
>  net/sunrpc/xprtrdma/svc_rdma_rw.c       | 310 +++++++++++-------------
>  3 files changed, 169 insertions(+), 172 deletions(-)
> 
> --
> Chuck Lever
> 
> 

-- 
Chuck Lever