Received: by 2002:a05:7412:b10a:b0:f3:1519:9f41 with SMTP id az10csp2964295rdb; Mon, 4 Dec 2023 12:25:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IE8HyB1phR6X2fbvuc+G2jwtcDQpW0ssRJvUfaSS6m+XcyHUrvLvikDId/gq3x9nXSRbgpp X-Received: by 2002:a17:902:c211:b0:1cf:c9ca:501e with SMTP id 17-20020a170902c21100b001cfc9ca501emr1789555pll.4.1701721515962; Mon, 04 Dec 2023 12:25:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701721515; cv=none; d=google.com; s=arc-20160816; b=Nihq64zF0VNNzeQhg0HaHA8VyWMuEmtX0ZkgLedBjSpa8+rMLCl0OsIx3jJjv00cpS VJwnwG6z2j/dlS/u7g0tbS1i8rGmyNjEwHpxPrY06uTTn0K2WmmIIBaCNO4y+/acdzYU mF4UVxuCayaIumtIPUyqI8Nfp/Xfa3gGz+9AyUR3DpCuW50Ik4Mj8NECvrAmOCgEx044 mpBWEfq57ockMpz0pnT//ZgO4lZuqr/4e1R1JWjS0Rwd6sg6lcVc9uGUejv34nRUnrYd 6ypMnsixOEEh/+/iS5DjBlHHS8Z7oqYL15bWHPBk6tCCERa8n7XpGlb7pRc3sKC/tgCd qJ5Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=oG6QlYoTJgCJwRhyDdru3eFjuks7F8YapFvC4UhMfIU=; fh=zrf3k9maC4LGn/MmcHhRkqh5cHnarsSKx/fWXfAmYNI=; b=aH7esr3fKhk6MfHhsnB6ehkYH7eoqzEmZcuQvAsEWNQ9ta65jbFCNDnheBjjrVwAbG EF8Inw8+pU7WpS3YCRpdeU9lF0tCJX7KIDXQEihWL0rbvRpqXTJDi/1fWsol88geNETm YrU3DVgKxYCzV4LHT87vs109NrAAreCwcpnyBbfC7ao7AePDOiJlpIPOqcRD3bPNK4QZ MTf4U0t7ONNo3poaDIrIvWT/jQNyW8cjZw4lkRDg6vd+zYQHm24IpYEgUQ6GqOLWz0/N M9aC8KuQbqzYu4bHl+6dk98FVrUg0IoI3kpvFfrfPHmV9G39/5wpOmRK75SPYnfXBKu4 Vc/g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BwKhTgFD; spf=pass (google.com: domain of linux-nfs+bounces-307-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-307-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id w4-20020a170902904400b001d056bdad56si5848351plz.166.2023.12.04.12.25.15 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Dec 2023 12:25:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-307-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BwKhTgFD; spf=pass (google.com: domain of linux-nfs+bounces-307-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-nfs+bounces-307-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 71C7E2811F8 for ; Mon, 4 Dec 2023 20:25:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 795A233CF5; Mon, 4 Dec 2023 20:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BwKhTgFD" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D66E30F92 for ; Mon, 4 Dec 2023 20:25:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CC0CBC433C7; Mon, 4 Dec 2023 20:25:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701721514; bh=jGaimABQR5t/c4BV2PeLWaX4aPh5s8kWXUeMbNBorQo=; h=From:To:Cc:Subject:Date:From; b=BwKhTgFDorqUo8TqYMbIuQRoDE8nErQLgruQskPd5kD3LREEoW0iyyHBCZBFWLJR3 77iJYoXuTlFNYWzCGNZdO1ILvdnnyasnmhmgOmTdlG9xjaA4Vw8bJmDXXr45e0n9BV dEXV6V2kIFDeP6MyXfvm64vuyj3f93igJiPE8W0CcO/KJ6E3DzSg26Mb1D7vkgXTSG dVUDqqcpZX6N8U/diKeuv21t+3yeSyUmnZuFozG9qxzW4G0JM17UQ039wBYhN+UjXv oaS0MjpCiKNaGkH6FjgjSEuP0fpyNoz6K20MHT5w9gdLoB85WM17KghgyLsHC+HOp5 UsBqd7O6w700Q== From: Anna Schumaker To: linux-nfs@vger.kernel.org, trond.myklebust@hammerspace.com Cc: anna@kernel.org Subject: [PATCH v2 0/4] SUNRPC: Various RCU fixes Date: Mon, 4 Dec 2023 15:25:08 -0500 Message-ID: <20231204202512.108047-1-anna@kernel.org> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Anna Schumaker These are various fixes that I found after turning on CONFIG_LOCKDEP, CONFIG_PROVE_RCU, and CONFIG_DEBUG_ATOMIC_SLEEP. I didn't hit any issues when testing against a Linux server, but running against Netapp with pNFS had several different lockdep & rcu related spews show up in my dmesg (and that's just from running cthon, not even xfstests). These patches fix all the issues that I found, and have a couple extra cleanups that I noticed along the way. Changes in v2: * Have rpc_xprt_switch_has_addr() unconditionally take the rcu_read_lock(), since we don't need to worry about this deadlocking if the lock is already held by the caller. Thoughts? Anna Anna Schumaker (4): SUNRPC: Clean up unused variable in rpc_xprt_probe_trunked() SUNRPC: Remove unused function rpc_clnt_xprt_switch_put() SUNRPC: Create a helper function for accessing the rpc_clnt's xprt_switch SUNRPC: Fix a suspicious RCU usage warning include/linux/sunrpc/clnt.h | 1 - net/sunrpc/clnt.c | 45 +++++++++++++++++-------------------- net/sunrpc/xprtmultipath.c | 17 ++++++++++++-- 3 files changed, 36 insertions(+), 27 deletions(-) -- 2.43.0