Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp345302rdb; Tue, 5 Dec 2023 07:06:15 -0800 (PST) X-Google-Smtp-Source: AGHT+IGD3fDusHQQzgkgHvVp5523LHCmmjt4GVq5J4LXWhuwqoGsKBxRhUVXXjRYpJ3spvLiHYUW X-Received: by 2002:a05:6512:202d:b0:50b:f486:88b2 with SMTP id s13-20020a056512202d00b0050bf48688b2mr1135769lfs.36.1701788774847; Tue, 05 Dec 2023 07:06:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701788773; cv=none; d=google.com; s=arc-20160816; b=GJAa2SDjpBqqHrSe6XvRV67rXGNnWqhR1OvgzZ5o550koqC6zVXmH+dLP+KWvM+a9H CEo1BlgWh46fKES8HMZQ2U7BumcwxWSW2i3dNdNLPKWBG2Wo8xt73EAS1xv2dqQwAbnA hxCmNHZujVjptUyjM4D9Ijein8khzWqF3Hbbk/KTBZC3Po6Jbu0IZCucOrUEOf/WIKxq 8TFVDLEYKqmDwXcoqvBT8A6336vS1UF1+//iTdSj5lw3vQPL1BchqSCb0GfJmJcCYkdV nOfwo5KDSBS/E4DElckfRNqttAt1V3QLyDJkj/LbOje9eCpxeYUpHV/5Lw/vzO7pQzaY Q9GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:message-id:date:subject:cc:to :from:dkim-signature; bh=Nt66F56XA5t43NX8e3OoyHZmlKICqSgfETfA16MUmbA=; fh=kMe8ipV+H2zZMCwplNV8b/uzUHICYp+b9TeU6KoaKrQ=; b=xrpKBv2kpVeZxoWktdbXfuZK4zgIP9VG9yp0caw8Ihw23HuPw4k/M11t6bF+E1zAtt E2TnHfnXdqLxT8/LWS4sx7bMe0iWTy+N3FpByPGRItBinMVPQRymg2hRbxE/zNxnioa4 ZZllVj4AJq9t5hgrcatFn6vIitfIYGX/YP9X5CSbjZqHzyRr3kgqOqaT21f+bXnncz6x U991jaYabTBd+ERA9flOyyMqssPxJHE4xQqfoTQWGO948B0smBzHzkhW6PFfkbie6EGc xiDXJ37dC5hadRK97ep8H2ArnDKLEbWkp++U7IlVNiNLdjNDFiEQkEID782n5XS0mJuT pW+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H+mI71uY; spf=pass (google.com: domain of linux-nfs+bounces-338-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-338-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id q8-20020a1709060e4800b00a00076109c5si5376341eji.399.2023.12.05.07.06.13 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 07:06:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-338-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=H+mI71uY; spf=pass (google.com: domain of linux-nfs+bounces-338-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-338-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id B40551F216E8 for ; Tue, 5 Dec 2023 15:06:13 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AA7E667E81; Tue, 5 Dec 2023 15:06:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="H+mI71uY" X-Original-To: linux-nfs@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 598D1A9 for ; Tue, 5 Dec 2023 07:06:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701788767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Nt66F56XA5t43NX8e3OoyHZmlKICqSgfETfA16MUmbA=; b=H+mI71uYyRL+3PyEhRL9Ca2Rs7x7rrqC83LOsUvyD92LNjzsjZ8ibt5B7KOCQoRrIWd5a9 PVClV0poLgYKyBGOUsR9uPAZs2LdebjjCDeodaQ081GqGXVqmHPtSBkqYDTPm8zd0XK3yr lm3+D8m6mp9FVJTJKUIxRbZ48V8fpz4= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-201-x-EtzTzjMY6N-pWXZRRtwA-1; Tue, 05 Dec 2023 10:05:04 -0500 X-MC-Unique: x-EtzTzjMY6N-pWXZRRtwA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7A8481859167; Tue, 5 Dec 2023 15:05:03 +0000 (UTC) Received: from bcodding.csb.redhat.com (unknown [10.22.48.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1784C1C060AF; Tue, 5 Dec 2023 15:05:02 +0000 (UTC) From: Benjamin Coddington To: trond.myklebust@hammerspace.com, anna@kernel.org Cc: linux-nfs@vger.kernel.org Subject: [PATCH 1/2] blocklayoutdriver: Fix reference leak of pnfs_device_node Date: Tue, 5 Dec 2023 10:05:01 -0500 Message-ID: <33e0ddfaad92ca5d6b0a4d1cc7541cf5a7480d7a.1701788600.git.bcodding@redhat.com> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 The error path for blocklayout's device lookup is missing a reference drop for the case where a lookup finds the device, but the device is marked with NFS_DEVICEID_UNAVAILABLE. Fixes: b3dce6a2f060 ("pnfs/blocklayout: handle transient devices") Signed-off-by: Benjamin Coddington --- fs/nfs/blocklayout/blocklayout.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fs/nfs/blocklayout/blocklayout.c b/fs/nfs/blocklayout/blocklayout.c index c1cc9fe93dd4..6be13e0ec170 100644 --- a/fs/nfs/blocklayout/blocklayout.c +++ b/fs/nfs/blocklayout/blocklayout.c @@ -580,6 +580,8 @@ bl_find_get_deviceid(struct nfs_server *server, nfs4_delete_deviceid(node->ld, node->nfs_client, id); goto retry; } + + nfs4_put_deviceid_node(node); return ERR_PTR(-ENODEV); } -- 2.43.0