Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp550092rdb; Tue, 5 Dec 2023 12:33:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEIPdLmL9YtfiSnRSUf2ndLD7ZLNCvnIh2k6KWrHJpkXPongXF+QZ0QZYX9xOr8ewDpmNJa X-Received: by 2002:ac2:548f:0:b0:50b:f486:88b3 with SMTP id t15-20020ac2548f000000b0050bf48688b3mr2357531lfk.106.1701808400563; Tue, 05 Dec 2023 12:33:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701808400; cv=none; d=google.com; s=arc-20160816; b=chQenTxjJYflA2z1NnX93rFStsO7cgXfKqLdhyYgJKZOs5U48KR1YfE5k5bm/xyiW2 ZYuxIMPQM6wcWZtAJyloTtFAZL8HYSnsxJVUCGX+1pxaKOPIVy6dllb3HNIOnfHRcJ/2 hl7YeoCPRwumt+AiLdxPDcxJ77UrdFvTZ48dMc7OysXOSDRtrRJK5sgpRTakeVcn5Ntt UYIsChWu6DdmEIscg0zfinx4hjMteWRKkSNK2Vd9LU81QtcM0tEtkslEntNyaicKMPxy 6Hls2pvfz4mLuQp1TiZ/k+UyEoxEQaihI3IImUHhHkfmgZ7+nXWkDxDxqcLN6qnkTqPs reHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=r6xs83q1VRGhKaEFi4pQN+W9GQsB4d9OPR2jWU2lW5U=; fh=ytDvhVXEt6P0j1UPLG2mxlF5BMmj+u7bueam7BMf2m0=; b=yisTLu1W2zXlVCZ/uflW5+uJ81DfUJnhJQIYrdtYCD+Ytks76jqDcGBdTvASI6IZ4I amWbJti6zpHYTcNaSxFfaJg069kF4ajcBYG+GGG3xDNi5ePPBHjRHURZvCdzKvPIT1SL +HRcpLb17Q6xY+hKUW+DBrggzKyuuQvB12Lx/unht/rICv2igFl68dh7Ri/Jr//MU8WA lt9gATt1HhgS0HXUaSydiV6ZjQg/kk9tik48Q/jrHOpD5KZniMvR3BQTnM4CF176Pewu rBe+scQlY7F8opb2MfIzYZ26GzoZe90DtQsZGbJKRzztpvIvvMm6BRdD19y6Io6BJATw qVgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VE20jbLb; spf=pass (google.com: domain of linux-nfs+bounces-342-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-342-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a35-20020a509ea6000000b0054cfd045e4esi1332558edf.363.2023.12.05.12.33.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Dec 2023 12:33:20 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-342-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VE20jbLb; spf=pass (google.com: domain of linux-nfs+bounces-342-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-nfs+bounces-342-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 052BF1F216C1 for ; Tue, 5 Dec 2023 20:33:20 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 6994668B8A; Tue, 5 Dec 2023 20:33:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="VE20jbLb" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 452EA3D98C; Tue, 5 Dec 2023 20:33:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C9D0C433C8; Tue, 5 Dec 2023 20:33:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701808397; bh=ct9NsTNEDirO8IhjablbfPQ/GBvefxGEDEkJ9VZbwD4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VE20jbLbAdpt1MC4bCEJdWA8Q5jrShzmQ+rAobBQIwZtv7+CCA//LFaw4pmN6Uzo6 pQXCosWg0Ghx5lfSFoqGd3fjbSt4k8UgDxF+LdJ4MG0+hJWY5sgSMC9wRK4KigBUr+ kleyc3JCu8ACQD3hSgNcZ4UguuMu6A+66vG+iAmK4GMJsirSrrlILoNLNqCWWffT0x jSW8nePOcRt/jde0bpqKC9t2C56YcoKJAuz5wVJKRTL/8hFSlpBnqFgQWCRiWPHTSd uYk6sDXoC4uxxIUf6n3atvMy7bdJujK51WRYGFQQvRyJ5w0j8M3zrBGjGIcVhAqCjG 2uECMLppd5cQQ== Date: Tue, 5 Dec 2023 20:33:12 +0000 From: Simon Horman To: Lorenzo Bianconi Cc: linux-nfs@vger.kernel.org, lorenzo.bianconi@redhat.com, neilb@suse.de, netdev@vger.kernel.org, jlayton@kernel.org, kuba@kernel.org Subject: Re: [PATCH v5 2/3] NFSD: convert write_version to netlink command Message-ID: <20231205203312.GV50400@kernel.org> References: <8b47d2e3f704066204149653fd1bd86a64188f61.1701277475.git.lorenzo@kernel.org> Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b47d2e3f704066204149653fd1bd86a64188f61.1701277475.git.lorenzo@kernel.org> On Wed, Nov 29, 2023 at 06:12:44PM +0100, Lorenzo Bianconi wrote: > Introduce write_version netlink command similar to the ones available > through the procfs. > > Signed-off-by: Lorenzo Bianconi ... > +/** > + * nfsd_nl_version_get_doit - Handle verion_get dumpit Hi Lorenzo, a minor nit: this function is nfsd_nl_version_get_dumpit > + * @skb: reply buffer > + * @cb: netlink metadata and command arguments > + * > + * Returns the size of the reply or a negative errno. > + */ > +int nfsd_nl_version_get_dumpit(struct sk_buff *skb, ...