Received-SPF: pass (google.com: domain of linux-nfs+bounces-356-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 5 Dec 2023 21:44:27 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: trond.myklebust@hammerspace.com, anna@kernel.org,
	linux-nfs@vger.kernel.org
Subject: Re: [PATCH 2/2] pnfs/blocklayout: Don't add zero-length
 pnfs_block_dev
Message-ID: <ZXAKOw9Q5EoOqsr4@infradead.org>
References: <33e0ddfaad92ca5d6b0a4d1cc7541cf5a7480d7a.1701788600.git.bcodding@redhat.com>
 <53e2ab90d83d4cdc15f1b48b2eb671ad26f54a6a.1701788600.git.bcodding@redhat.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53e2ab90d83d4cdc15f1b48b2eb671ad26f54a6a.1701788600.git.bcodding@redhat.com>

On Tue, Dec 05, 2023 at 10:05:02AM -0500, Benjamin Coddington wrote:
> We noticed a SCSI device that refused to allow READ CAPACITY when the
> device had a PR with exclusive access, registrants only.  The result of
> this situation is that the blocklayout driver adds a pnfs_block_dev of zero
> length which always fails the offset_in_map tests.  Instead of continuously
> trying to do pNFS for this case, just mark the device as unavailable which
> will allow the client to fallback to the MDS for the duration of
> PNFS_DEVICE_RETRY_TIMEOUT.

Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>