Received-SPF: pass (google.com: domain of linux-nfs+bounces-365-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <be8ead05-1ebd-45c8-84e7-78b6b0e7202b@benettiengineering.com>
Date: Wed, 6 Dec 2023 19:53:03 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h>
Content-Language: en-US
To: Petr Vorel <pvorel@suse.cz>, linux-nfs@vger.kernel.org
Cc: Petr Vorel <petr.vorel@gmail.com>, Steve Dickson <steved@redhat.com>
References: <20231205223543.31443-1-pvorel@suse.cz>
 <20231205223543.31443-2-pvorel@suse.cz>
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
In-Reply-To: <20231205223543.31443-2-pvorel@suse.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Petr,

On 05/12/23 23:35, Petr Vorel wrote:
> From: Petr Vorel <petr.vorel@gmail.com>
> 
> This fixes build on systems which actually needs getrandom()
> (to get SYS_getrandom).
> 
> Fixes: f92fd6ca ("support/backend_sqlite.c: Add getrandom() fallback")
> Fixes: http://autobuild.buildroot.net/results/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/
> Reported-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

thank you for fixing. I've tested this and the other patch with
Buildroot's test-pkg and built fine for many toolchain/arch/libc
combinations.

Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Best regards
-- 
Giulio Benetti
CEO&CTO@Benetti Engineering sas


> ---
> Changes v1->v2:
> * New commit
> 
> I'm sorry for these errors.
> 
>   support/reexport/backend_sqlite.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/support/reexport/backend_sqlite.c b/support/reexport/backend_sqlite.c
> index 0eb5ea37..54dfe447 100644
> --- a/support/reexport/backend_sqlite.c
> +++ b/support/reexport/backend_sqlite.c
> @@ -7,6 +7,7 @@
>   #include <stdio.h>
>   #include <stdlib.h>
>   #include <string.h>
> +#include <sys/syscall.h>
>   #include <unistd.h>
>   
>   #ifdef HAVE_GETRANDOM