Received-SPF: pass (google.com: domain of linux-nfs+bounces-366-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <e99577a3-b36d-4ef0-a330-88502d3193df@benettiengineering.com>
Date: Wed, 6 Dec 2023 19:53:04 +0100
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2] reexport/{fsidd,reexport}.c: Re-add missing includes
Content-Language: en-US
To: Petr Vorel <pvorel@suse.cz>, linux-nfs@vger.kernel.org
Cc: Steve Dickson <steved@redhat.com>
References: <20231205223543.31443-1-pvorel@suse.cz>
From: Giulio Benetti <giulio.benetti@benettiengineering.com>
In-Reply-To: <20231205223543.31443-1-pvorel@suse.cz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Petr,

On 05/12/23 23:35, Petr Vorel wrote:
> Older uClibc-ng requires <unistd.h> for close(2), unlink(2) and write(2),
> <sys/un.h> for struct sockaddr_un.
> 
> Fixes: 1a4edb2a ("reexport/fsidd.c: Remove unused headers")
> Fixes: bdc79f02 ("support/reexport.c: Remove unused headers")
> Signed-off-by: Petr Vorel <pvorel@suse.cz>

Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>

Best regards
-- 
Giulio Benetti
CEO&CTO@Benetti Engineering sas

> ---
> Changes v1->v2:
> * Add also <sys/un.h>
> 
>   support/reexport/fsidd.c    | 2 ++
>   support/reexport/reexport.c | 1 +
>   2 files changed, 3 insertions(+)
> 
> diff --git a/support/reexport/fsidd.c b/support/reexport/fsidd.c
> index 8a70b78f..51750ea3 100644
> --- a/support/reexport/fsidd.c
> +++ b/support/reexport/fsidd.c
> @@ -7,6 +7,8 @@
>   #include <dlfcn.h>
>   #endif
>   #include <event2/event.h>
> +#include <sys/un.h>
> +#include <unistd.h>
>   
>   #include "conffile.h"
>   #include "reexport_backend.h"
> diff --git a/support/reexport/reexport.c b/support/reexport/reexport.c
> index 0fb49a46..c7bff6a3 100644
> --- a/support/reexport/reexport.c
> +++ b/support/reexport/reexport.c
> @@ -7,6 +7,7 @@
>   #endif
>   #include <sys/types.h>
>   #include <sys/vfs.h>
> +#include <unistd.h>
>   #include <errno.h>
>   
>   #include "nfsd_path.h"