Received-SPF: pass (google.com: domain of linux-nfs+bounces-367-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 6 Dec 2023 20:42:20 +0100
From: Petr Vorel <pvorel@suse.cz>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: linux-nfs@vger.kernel.org, Petr Vorel <petr.vorel@gmail.com>,
	Steve Dickson <steved@redhat.com>
Subject: Re: [PATCH v2] support/backend_sqlite.c: Add missing <sys/syscall.h>
Message-ID: <20231206194220.GA159824@pevik>
Reply-To: Petr Vorel <pvorel@suse.cz>
References: <20231205223543.31443-1-pvorel@suse.cz>
 <20231205223543.31443-2-pvorel@suse.cz>
 <be8ead05-1ebd-45c8-84e7-78b6b0e7202b@benettiengineering.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <be8ead05-1ebd-45c8-84e7-78b6b0e7202b@benettiengineering.com>

Hi Giulio,

> Hi Petr,

> On 05/12/23 23:35, Petr Vorel wrote:
> > From: Petr Vorel <petr.vorel@gmail.com>

> > This fixes build on systems which actually needs getrandom()
> > (to get SYS_getrandom).

> > Fixes: f92fd6ca ("support/backend_sqlite.c: Add getrandom() fallback")
> > Fixes: http://autobuild.buildroot.net/results/c5fde6099a8b228a8bdc3154d1e47dfa192e94ed/
> > Reported-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> > Signed-off-by: Petr Vorel <pvorel@suse.cz>

> thank you for fixing. I've tested this and the other patch with
> Buildroot's test-pkg and built fine for many toolchain/arch/libc
> combinations.

Thank you for extensive testing! I test only the basic 6 tests (the default
test-pkg).  I suppose you run test-pkg also with -a (these 45 arch
combinations).

> Reviewed-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Maybe you can add your Tested-by: ?

Kind regards,
Petr


> Best regards