Received-SPF: pass (google.com: domain of linux-nfs+bounces-383-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 7 Dec 2023 09:44:28 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: steved@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 6/6] configure: check for rpc_gss_seccreate
Message-ID: <ZXHaTIvFruYfycsm@tissot.1015granger.net>
References: <20231206213332.55565-1-olga.kornievskaia@gmail.com>
 <20231206213332.55565-7-olga.kornievskaia@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231206213332.55565-7-olga.kornievskaia@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?hHX+zixxBI29u+tZTSwpn9pJyoBdlC2pFJbfuUpNd1BCy0f4QKnlzSXUXrDd?=
 =?us-ascii?Q?9LbJYYTVc1BVMuyMR8npcO2KlbqqkRVtfI2kwQJzPJkBEffyymYPJhmIOzLP?=
 =?us-ascii?Q?Bvc1YDjzBXOlnHNoTfFGpF7awCPWZqVPBfNzzs3bMPLEfNsgTlB+CzUJwUN0?=
 =?us-ascii?Q?t7vx8Q24O2AwqEhB+F5AMMImGFf0bSz1isZlsctSj7LTfSDerXc8AlpBU/Hm?=
 =?us-ascii?Q?1AtYkqJ9WlxNKCIxcRB3oJtS7hgH6XNjCnMfCZDgbyehlp1lopijsa+dMZbi?=
 =?us-ascii?Q?7Bbtke2r3nt6rvzQtzz1WUBg48aXjbMtJnkvRGPK6+rihE6Oa24HeOKW5sSp?=
 =?us-ascii?Q?SNSBAZRIV++piIVXD5tTcvsVkprQcoqMHFcEerrNTAlv7JYADY3320edW4DU?=
 =?us-ascii?Q?PTKkL3HGqiB7PPD1tPKERX4zslhn+SPQX8J+Sca0UDusN/P6a0r63W9sshp3?=
 =?us-ascii?Q?lQ6883+4C/aSgHMW7CriS9axyVskzrtYblKGWNCX0m25S8pYCw0/k9fMYyKr?=
 =?us-ascii?Q?8FFG1d+mnUnbU76337ae3mzcHmL4CAB4Wd/QsEk/SayCG3zHUKygzIStCtFC?=
 =?us-ascii?Q?xsY4RvTD6YL+vRVSiPopqE5EUxxpRDwx0T8XgTMchJx3SLSiJ8jCNT0SGjHB?=
 =?us-ascii?Q?b/BDa23gl2/69x0eSt7n1KBaZNUdcwpkmjCmUJrCPB2UYrTO4yNXFTGUJN+p?=
 =?us-ascii?Q?Y2kzLBmDc+Vb+lN/k6hI6vkbrGfxquBvk0g61Fcw55Sj10/UuCHhiixtilnb?=
 =?us-ascii?Q?eL7EGrfLO7SpGV65SmHaZo8EqRT/X5Xg+gjo8Q7bWfjNpLdtO73Jwby5FUyc?=
 =?us-ascii?Q?AO/Xt9NEyJba00unqfJe+pkapcegYLrUCTkS66CL7ol3YIeYoam+ZoU3m1sH?=
 =?us-ascii?Q?ee/dm0Q0x4Pgzme58YIIJ4dkXsq1bY/9tI78UiBfvDUU7im6VTaUgv6PATmd?=
 =?us-ascii?Q?8HH94ZSrAdtQnr9hjr8wXCeI1pkgVmEICR8chVRnIMWbuqWB+2FMVlPuBgQQ?=
 =?us-ascii?Q?X1cRW/6Cts62SFhwG5x6SFsa6SrnXABKF0G21TYAlNflyEhmpuflsScenK+e?=
 =?us-ascii?Q?bdcaSS3aQDnVrpfrRS8Ua9IZYLClP3s6CYxHQw3aeQfbAAadXi9yQpNwWHSg?=
 =?us-ascii?Q?c/Q36XcOIBRof5zxdv5NmQd1TcH2y3CBZUosbclNZMvUgVFRJnpXaCYAtT+c?=
 =?us-ascii?Q?HoYgCYUcCAoIaVTPrdqdy4vOK5y8t7kvsqvA5TyZtujSm4DET3RBlCIAuzmm?=
 =?us-ascii?Q?L2s9V/QShLcukSpMgsm2Vo3SN3mn3ExqlikY+SzkhFdU9hwGYTUub0E9+ILw?=
 =?us-ascii?Q?M2JokqJpg8MPWcNNDL8Lr4Zie7oVqjxHvhBp278sZNP1YYQvRviY+XAADK9z?=
 =?us-ascii?Q?ILBo8TOjdB0NOpW9g6/Ek7iA2otXKtXE+vMibQSaxrBhu44oa3Tsz8rEqDHQ?=
 =?us-ascii?Q?PZ+2q8ZPHZag7CVBtcDBxn4q5WJ+kB7/gv379XBGITNfDDjLttu7NG8ZAwcc?=
 =?us-ascii?Q?L/alH0O8h56lQ4M695+18ZYCOvXqmXIAynSAHK+JeaRSDLgQW73m0j/75O8V?=
 =?us-ascii?Q?tR/fnaEKpcZ2MfUuoSg3Y+3QHyAdlHcxLYtPkqWd7/EiS20tigoLijvqi8n7?=
 =?us-ascii?Q?3Q=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	IqPwiYHhbLx4vamIfo1P9/ID9cyCxPJ2ebzkV54fUceYuFDwUYo1uo+pcpVSdfjAnR6P+1HgwOWQvy6+Y3cpRpsF7jCndku4PDMuyY6lQvgKMOjOAdsFzx+4rzrO4XHtsr3MH9yPOI9Y1dkIGA0OdAZ00gk/Dus9BI+NUgdsnx7CnrkvMwgQidwV7dEhXMP3arj7jKz4Q1wSRMbOFGhN+iD2Owh9GquJ2GOpoRSCS4HOXNpBCNaXpe7qPJUa89Ba2NNdR1PkDth8mlaBTgnzg7RUSrs0tG16rWDYK+Ttm9w91NNJNM5PNbPlOcF/gP4Rbo09RRm0oPvfzmWSS/SEJA6dvrdcxeyaYyTVM7ttR2I9HcdRtnExGkzdUDrMuPORdzyp3euNNQ8fttWBc9rn0wyvx1itRDrvJ0j5TsebRjS4Ge+scUqytExVFUffggANgVUCeIEKdKS4jUtShQqAxukN4iaeTCYxXB0GOxh0/EhPTSV9UZxwbFc6fKGsE7m+XATCXqQ4KArVhj7XEwW0UvGxk1dtgXqJU+rkaHfyB3h7luVKMsNDGuCXnxpzs6v4VEsMkih1yEdBd58hHWZlSxrvhMLIsfxXbqfeuZu/JRJI0HxxyexzTTTJLXwNf1Ifr3pbS98SIqfqhUUNLo6+WKqNquBj+6flefC5h4FQweWiNYP0RfR6QF1z8w371hfRNYKpieFW9bQZwOah/9vn8ckjg/TCcP8NTl6gtseDOYXW1VTZcabfRbtLnQZHLuqgxg7vIMbwAleuT5BXz1nd0Mma7sr8uJQI1sUhyk8lmxSiYXhXZnmFrI5OVTLOMUDo
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a1ab50b6-57ce-45f4-2892-08dbf73305b8
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 14:44:31.6803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: aNgGs1VTfnmUqFxJa21xIG21q60hcTsET5XRTA3HimspWlJ9kQuzYoPgrZY8BIhGYtn7qhjL/9gOGuMmbGQbcA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB5000
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-07_12,2023-12-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 spamscore=0 phishscore=0
 bulkscore=0 adultscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312070121
X-Proofpoint-GUID: cGRWe_I-IKEffypP-PNkosN549_aFQtE
X-Proofpoint-ORIG-GUID: cGRWe_I-IKEffypP-PNkosN549_aFQtE

On Wed, Dec 06, 2023 at 04:33:32PM -0500, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> If we have rpc_gss_sccreate in tirpc library define
> HAVE_TIRPC_GSS_SECCREATE, which would allow us to handle bad_integrity
> errors.
> 
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
>  aclocal/libtirpc.m4 | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/aclocal/libtirpc.m4 b/aclocal/libtirpc.m4
> index bddae022..ef48a2ae 100644
> --- a/aclocal/libtirpc.m4
> +++ b/aclocal/libtirpc.m4
> @@ -26,6 +26,11 @@ AC_DEFUN([AC_LIBTIRPC], [
>                                      [Define to 1 if your tirpc library provides libtirpc_set_debug])],,
>                           [${LIBS}])])
>  
> +     AS_IF([test -n "${LIBTIRPC}"],
> +           [AC_CHECK_LIB([tirpc], [rpc_gss_seccreate],
> +                         [AC_DEFINE([HAVE_TIRPC_GSS_SECCREATE], [1],
> +                                    [Define to 1 if your tirpc library provides rpc_gss_seccreate])],,
> +                         [${LIBS}])])
>    AC_SUBST([AM_CPPFLAGS])
>    AC_SUBST(LIBTIRPC)

It would be better for distributors if this checked that the local
version of libtirpc has the rpc_gss_seccreate fix that you sent.
The PKG_CHECK_MODULES macro should work for that, once you know the
version number of libtirpc that will have that fix.

Also, this patch should come either before "gssd: switch to using
rpc_gss_seccreate()" or this change should be squashed into that
patch, IMO.


-- 
Chuck Lever