Received-SPF: pass (google.com: domain of linux-nfs+bounces-384-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 7 Dec 2023 09:50:47 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: steved@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/6] nfs-utils: handle BAD_INTEGRITY ERROR
Message-ID: <ZXHbx1/j8VMfxVTa@tissot.1015granger.net>
References: <20231206213332.55565-1-olga.kornievskaia@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231206213332.55565-1-olga.kornievskaia@gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?+SyqmTBspBQGbplwGTuwnip25W6PUuuf11IBSxDRrETn9Gk+l/Q4BAxBbu9i?=
 =?us-ascii?Q?eSTAcCEZDd4Bx9Rt8gkBDru8CRKAelx9N9uJrHBGr4//E7iL81wAK127yjXB?=
 =?us-ascii?Q?iOpJs7PQvbSvj6iHs/Y40WdpmMZavBJ5Bo6/JOps8Exjf6XNWsA3q4/dq6LM?=
 =?us-ascii?Q?MzPChjbpFJ4vLEDaTO74uo+sVSfqhvVrXK6Am5pT/toEaZeH03pG461vh9OY?=
 =?us-ascii?Q?f+tBKB3Y/E44h83fFeYO6mVVQyCGUo75F13iWyjbeDN3rsPy/sYIQYz6GKFH?=
 =?us-ascii?Q?9/n04jeXMMy3GUcRCVXAAm4soBh1lFPsAx6Oz/XgbiqB6vD/hYh6cvAQaEva?=
 =?us-ascii?Q?1TkGhfAK/zurRWowrSoD0imuh6UN6is5UFkT5JJy9rG3tjg13huqalLovWQk?=
 =?us-ascii?Q?mlxida0aolkEeWV9TgqozKZ44AT+ILfL/+WQ+hO0ILr1g7B7kbJbcZ9aqrn8?=
 =?us-ascii?Q?uK99VTJb00r7yzsRD2DytQTaPrGWLg1ojsaT65BnVkW77qa9miHC27hhe0Nu?=
 =?us-ascii?Q?JdQfihoemwBwORpvC0HIDtA879v+9v/6rXpAO5hezJCzK5J8oWGlloVeJ/oI?=
 =?us-ascii?Q?VS2yJ52ULTepiKbN0OmJjkOyam0bmvvECRnZca4VZJzVwmqArCeD8yUAwCN6?=
 =?us-ascii?Q?L+QykfzPLsVfyghxSl8QvnkjtCKs/1x9opYATp8NWluCSWc0iZKm4jfh2lqi?=
 =?us-ascii?Q?MYpQ0MVEzXNVm/uVPBufeD3I3qRjtSzYJzAnova/3Umxunu3iBg4iYsti3aW?=
 =?us-ascii?Q?hRlyKUfQgSwyjYzQ+v5DEqwCsTjd0YzgnG746S91x8J9+djKsJl+kQzzWPmB?=
 =?us-ascii?Q?NaywWJTDNWB5HFeUQ4f62ImxgJu+Bwrw9o3nX+3REbyM1oee+tntqlt+bITf?=
 =?us-ascii?Q?QNYtMpPTbCPlFc4Yi/dNJKmk+oa/0hoZW2jpyqx69Ii0Mflr5x0ogv1P3WQn?=
 =?us-ascii?Q?bYN26rLGUVam+8CvO/YKT7EX8OS4jTZm5cm0ITnPN+IN0j7/FZZ4UwQuiS3x?=
 =?us-ascii?Q?CP+DMO3gJsOAEYAkH0fHNxV4BAx74c3XUNeooIvtEYUF62KIUvqwYIZTSxcK?=
 =?us-ascii?Q?EbTiDTdMULpUsVNnp1t9p+CM3lXTJaCSgvvP77YjYyX/KDgmfYH/2ui9j6/b?=
 =?us-ascii?Q?bCucR8hKNAfus5QUJn51/9ImsSXfn+bdnYoCuOcxa4CoPRFl7J9n/9USSqiy?=
 =?us-ascii?Q?pWBgzzLSy10JS79N8NTT44M1Vq51bn5YJm62VO4HIAn+WGXyc7B8D1EU+aQc?=
 =?us-ascii?Q?uXfNuQDNmg5jYmbTiQb8xcM+Cy13MUL4DiW69WhKefxTvdBbYPQ2/Y+evTUd?=
 =?us-ascii?Q?cNsCLbiW6CJTX/DNUw1rlSGt0h4tf8lrAE2Qnw/+td0c1SANTHnfuKl5akif?=
 =?us-ascii?Q?vK2ahcp1n9RRWl7DSSXDzRYBS+ZmpOWdHuEsFHPFRT8T0t2xELlFWmdzSTSA?=
 =?us-ascii?Q?ZvAMc1dRbfIx6ObkGp7YcaQxpkszN0m2CM8/yBptV2plpFv/qt6zfa4sPTuX?=
 =?us-ascii?Q?tjglhmsKrcjVtRVXWE0ygp+Nmh4e9Wj8em88qdN9MrCHB2JkPZ3UOR50mFBv?=
 =?us-ascii?Q?oLqRiZApjMFpmBhXTAKRLnAPDyFWES/IuRDPhZC1PyWFBsqC/uO11Uvv+HST?=
 =?us-ascii?Q?VA=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	PRWBctKNCxFg50IfB5DvUdS3fAVpxpeseB1L7B3F+UsJnMGFAy13nay8oNQC7MI4oeR2IEFlxtnIQ288jqx4XxPEpyuKHbSZdW+L6Mxp+V7vLFMUCVxhATTsPGuFJFRwGwluyduKhvAlMBW86sV49k3cBfk5yB5fZhDbVLDwyB8ulYEEr5gd7lS2FvoHsD9tC7mfBrK16jxhlTWuS4+ysDb01bTL06FVyQKHhydEnIecy2M7QyAFvcFqFTh3DzL8q2qA9G33rfmrPbCQvzofNgi4WmcpgxA+IsZ4ssYeSaBGWgXcYQlqGZgHdduzQRILo1+n1whNifOkttjzdvw/afalMXUyQLgqUA7b/4gwoL99mMJQocbW+ES9jI9U8mqsk16BMcNlI893lekDgpE+AIyIEAfurulJhCTkD2Z9vrCaWMT9MvXRSjlVYZ87zW+SFzZ3KHP0B8SbsGPCIojVQ7rUFPj43BCL9JoUeC7zz+7XZv5cnMu7S/gSC0ECvPlhQZT2NDfOe8I7TqICcYMBo45wEE4PUn6jjNhiEM+0FwWLaA/C5x3i/vqm2alAzaNxJSP1pPR/HyPwl28KJrMDIQI7XuJI1ouEV8PsV8NJQo97PX0tihElgwsvECOInIJsupyl9wcDlnLRlCxPdx77RpRa15WyfkQzjeq0D/0zriH60jfX8LqSpobz4ur/0oa5uG/LmTzls4m9qqM9SsVkVYIyfyroO9fmM6fmBb8bII88E6UvZvokiFFn+XgtRo5KJObCvek/KD4XWELyM4wRKu7BTtN/53jwIncTawZKDzD7QqGCw+D8YfyQ91RuWUxV
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f192b67a-0c6a-431c-32ac-08dbf733e705
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 14:50:49.5315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: W1GnY24KnxzI749ucM03KMLySKaCDGyJttuhcIYlaCfqRcdcrrQ8eLxYh6aDrOJRPK7qkQPBftkHbiZcGjb4oQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR10MB6758
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-07_12,2023-12-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0
 mlxlogscore=999 suspectscore=0 adultscore=0 malwarescore=0 mlxscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2312070122
X-Proofpoint-GUID: Qs4HolqCel4gKp5Id_C-1ZmsZslm88xU
X-Proofpoint-ORIG-GUID: Qs4HolqCel4gKp5Id_C-1ZmsZslm88xU

On Wed, Dec 06, 2023 at 04:33:26PM -0500, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> This patch series is re-work of the previous patch series that handles
> gss error for bad integrity. In this version, gssd is changed to use
> rpc_gss_seccreate() function in tirpc which exposes the gss errors to
> the caller. This functionality is further checked with configure for the
> presence of this function in the tirpc library.
> 
> Note that the current libtirpc (1.3.4 version) needs a fix to
> rpc_gss_seccreate() to work correctly for the gssd that passes in
> credentials to be used for the gss context establishement.
> 
> Olga Kornievskaia (6):
>   gssd: revert commit a5f3b7ccb01c
>   gssd: revert commit 513630d720bd
>   gssd: switch to using rpc_gss_seccreate()
>   gssd: handle KRB5_AP_ERR_BAD_INTEGRITY for machine credentials
>   gssd: handle KRB5_AP_ERR_BAD_INTEGRITY for user credentials
>   configure: check for rpc_gss_seccreate
> 
>  aclocal/libtirpc.m4    |  5 +++++
>  utils/gssd/gssd_proc.c | 26 +++++++++++++++++++++++---
>  2 files changed, 28 insertions(+), 3 deletions(-)

The added error reporting is very nice. I'm glad we could make it
work.

Reviewed-by: Chuck Lever <chuck.lever@oracle.com>

-- 
Chuck Lever