Received-SPF: pass (google.com: domain of linux-nfs+bounces-388-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <2c9be16b-012e-4438-a396-fd1050284310@redhat.com>
Date: Thu, 7 Dec 2023 14:42:45 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] autoconf: don't build nfsdcltrack by default
Content-Language: en-US
To: Jeff Layton <jlayton@kernel.org>
Cc: linux-nfs@vger.kernel.org
References: <20231127-master-v1-1-5786ec1c6d38@kernel.org>
From: Steve Dickson <steved@redhat.com>
In-Reply-To: <20231127-master-v1-1-5786ec1c6d38@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hey Jeff!

On 11/27/23 10:18 AM, Jeff Layton wrote:
> Now that we've started the process to remove legacy v4 client tracking
> methods, let's stop building nfsdcltrack by default.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>   configure.ac | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 93a1202807ea..62c833cc2409 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -248,9 +248,9 @@ AC_ARG_ENABLE(nfsrahead,
>   	fi
>   
>   AC_ARG_ENABLE(nfsdcltrack,
> -	[AS_HELP_STRING([--disable-nfsdcltrack],[disable NFSv4 clientid tracking programs @<:@default=no@:>@])],
> +	[AS_HELP_STRING([--enable-nfsdcltrack],[enable NFSv4 clientid tracking programs @<:@default=no@:>@])],
>   	enable_nfsdcltrack=$enableval,
> -	enable_nfsdcltrack="yes")
> +	enable_nfsdcltrack="no")
>   
>   AC_ARG_ENABLE(nfsv4server,
>   	[AS_HELP_STRING([--enable-nfsv4server],[enable support for NFSv4 only server  @<:@default=no@:>@])],
> 
> ---
> base-commit: cc5cccbb9f24a2324f50a5cb4c29d83fdf6b1f90
> change-id: 20231127-master-5ef1c15da9c4
> 
> Best regards,
Quick Question... Should we remove the code or just
turn off the building as this patch does?

stesved.