Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp1961643rdb; Thu, 7 Dec 2023 13:58:10 -0800 (PST) X-Google-Smtp-Source: AGHT+IG5z9e9AUBbq+vpJnmZi7R0WDyBf7OENcj9fLxHL83AiIjJJnWHr7Rr1IjnPJcCyZIR+eH7 X-Received: by 2002:a05:6a20:7484:b0:18f:97c:824d with SMTP id p4-20020a056a20748400b0018f097c824dmr3291713pzd.87.1701986290430; Thu, 07 Dec 2023 13:58:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1701986290; cv=none; d=google.com; s=arc-20160816; b=RLVflGKJSeMy4ycKF77LDMieMRXi78cuOS1bPFa1MfzEiFXmF9QfJmuLeG0O4lttho is4J3wB752dtoRGufk3SuHDbCkJTUBdG/UUIVr6idIecwqVXCWrgDK+F8jBalewBYkCF IenkaIHHGb0nuTkRdeSOMP9Kj77tPH2tf20jPkPDzLBv2paXZ/FFCjWeTMLwm/+GNVBn qESQoLjdJbY/ywojhgz+PVLzn0+aJwzxcWT/kNQG3pe/X5zENTcVb54V698urxQcIwDE eaWlMPFepfkyT86SexnVwQiPYh7BAsm644teaDeEzaKKJoemFFA+vDwn+BdLJwIOTYg8 MkVA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:content-id:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:subject:cc:to:references :in-reply-to:from:organization:dkim-signature; bh=2gpuqenBf/seLQmhrTte/4HdPOyV33jxxLbSCYkPyeM=; fh=yIDznifpxrrvsjZy3g+jijG4g7ja0E5j5HJqf3Ctp6k=; b=llhNHC3Y+xQGx/qGBEmIkRhXEDMAiYkVGmNmtSWycGCp3xJCMYMrw1GHVt0XGG8noD N2qhSORR8zqROu57U+dnb62E+jl/MWmM3iJyUyxorOIF54nCCZFb9dfFI7MlLAOZUd6e og52Gs5iOTelk0eqlQTmUHOjAOrAKoKq80PAitLo8BNu0ocJYfPSX8zZyQU4caG9ihPI kNDSFyURxFf5IPFsiXN/09apk1oMf2FYS/MJVcKMosB6DaqAms3AUdhSADw7z4hHCsSY xhXz2E2bUhfmlyvdX9QA5lBmgVJUxyQa8YEu/9hQ6y7HT4HPNz791QTK0D84XW6zz568 rRZg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zn4BRdw5; spf=pass (google.com: domain of linux-nfs+bounces-452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id y19-20020a056a00191300b006cddefd2031si364639pfi.37.2023.12.07.13.58.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Dec 2023 13:58:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zn4BRdw5; spf=pass (google.com: domain of linux-nfs+bounces-452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-452-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 965F8281EFE for ; Thu, 7 Dec 2023 21:58:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 82087840CC; Thu, 7 Dec 2023 21:58:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Zn4BRdw5" X-Original-To: linux-nfs@vger.kernel.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E11621737 for ; Thu, 7 Dec 2023 13:58:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1701986281; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2gpuqenBf/seLQmhrTte/4HdPOyV33jxxLbSCYkPyeM=; b=Zn4BRdw5e9GjbQlK/IzkyGHo2P2snQ9aVjyzHl7CBGCn0Ug/azInrjBWraSxiqU6lLvDvt Upc4q8kY9wUuP1rRG0Ey4tcGouk/mzkKkmOzf9Vk9Ajf+AF0jerdG9jj6htXGO7Xo+SHhb ssmpxCkT0UKGx21cgU8rmIUBI7T4Gmg= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-494-3pxRZfFcM5CBFUREWELNAA-1; Thu, 07 Dec 2023 16:57:57 -0500 X-MC-Unique: 3pxRZfFcM5CBFUREWELNAA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7B64C1C0BB50; Thu, 7 Dec 2023 21:57:56 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.161]) by smtp.corp.redhat.com (Postfix) with ESMTP id E59971C060AF; Thu, 7 Dec 2023 21:57:53 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20231207212206.1379128-1-dhowells@redhat.com> <20231207212206.1379128-60-dhowells@redhat.com> To: Matthew Wilcox Cc: dhowells@redhat.com, Jeff Layton , Steve French , Marc Dionne , Paulo Alcantara , Shyam Prasad N , Tom Talpey , Dominique Martinet , Eric Van Hensbergen , Ilya Dryomov , Christian Brauner , linux-cachefs@redhat.com, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org, v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 59/59] netfs: Eliminate PG_fscache by setting folio->private and marking dirty Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1451125.1701986273.1@warthog.procyon.org.uk> Date: Thu, 07 Dec 2023 21:57:53 +0000 Message-ID: <1451127.1701986273@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.7 Matthew Wilcox wrote: > On Thu, Dec 07, 2023 at 09:22:06PM +0000, David Howells wrote: > > With this, PG_fscache is no longer required. > > ... for filesystems that use netfslib, right? ie we can't delete > folio_wait_private_2_killable() and friends because nfs still uses it? Yeah. Though I have my eye on NFS too ;-) David