Received-SPF: pass (google.com: domain of linux-nfs+bounces-454-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 7 Dec 2023 17:27:39 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: Olga Kornievskaia <olga.kornievskaia@gmail.com>
Cc: steved@redhat.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 6/6] configure: check for rpc_gss_seccreate
Message-ID: <ZXJG2xyFUs9pzHlq@tissot.1015granger.net>
References: <20231206213332.55565-1-olga.kornievskaia@gmail.com>
 <20231206213332.55565-7-olga.kornievskaia@gmail.com>
 <ZXHaTIvFruYfycsm@tissot.1015granger.net>
 <CAN-5tyFr7-eRP_wjrv_zOmsVC6ft1f1c+fNovbOXr0CVrtzfRw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAN-5tyFr7-eRP_wjrv_zOmsVC6ft1f1c+fNovbOXr0CVrtzfRw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?K1p4L3UzRUlaWnd0MElHcFRCaGVxazFFNEl3MWZRLzB2Ym5RbTFJT0pTRSt1?=
 =?utf-8?B?RU9UaGlPRzExdXRIb0w0OHNVRnAwOThzVWJod20veDBVb1RpVm5YbkhjL0Ns?=
 =?utf-8?B?cWVRS0xmYTRYend0SUF1R2hWQUZidncyOTdlUnNORCtsaUlwWXJadWg3RmRI?=
 =?utf-8?B?dUt6WVF4dERUa1AxNmpUNUZRaVpmdHlTamh2MmxzaTFtWGtub0hSV1NpZ1hy?=
 =?utf-8?B?aFk5TnFEVGxtTWYzMXQ5SzhiSkhVcFpjc2tES2ZPOE1EcDhxdlRicWNIeFR2?=
 =?utf-8?B?bXNubVc3ZVFrN0ViNlNoWEJ2K00rVkNlU0J0QWtCemxrKzZGZHE4ZngzZU5G?=
 =?utf-8?B?NEFzSmNkMGk4UzFFS1dZNzJZb1JnYUFMKzNZOHgzWlNzdlpRaXN0RElseVFW?=
 =?utf-8?B?Q0VraHdLVlBwV0xPbnJLdUFnbE1UdTBXcTFNVEo2dkU5MXRWQlV3VzFGV0Fq?=
 =?utf-8?B?REpyRlZCbWI4b3RTRUgzbytlM25WbTA2MkJLYlJrSGRORVBPL1NEcFMwZUlp?=
 =?utf-8?B?T0lpWkxjVVBaMngrelVCSDVuQjNPQUlCcWNJbDdxRGIzMDFkVEtCSzZ1Slk3?=
 =?utf-8?B?Qyt3WFJSTk5hdnNDNHorMmhHK2dibmVVTG1GVzI0UDBmV3dTL1FSVHRzSURC?=
 =?utf-8?B?K3VCbldhcjY1UWtBS08zaThaMFY0TFhOMm16V2cyMUdqTzRRc3gwamx2RzF2?=
 =?utf-8?B?SWR4eHNnUnVCTWpPeFQzRm5YNFZOWVhBcE9WUlI2bmdQbmdGK0FUaXQ5ZWhi?=
 =?utf-8?B?cHo3NWN6WVp5OXQzc1liMkZ1R0tCWDJBb2IzWkVSNTZOdnA0UHM4Wm9mK3d6?=
 =?utf-8?B?N3ZqTzlnOUxVUWxuVm5HTVNxMGhMZ3J3N1ZaNmVxM05tOFg5ekNOSDRCSGh5?=
 =?utf-8?B?dG03WHBSc3hDV1U3TGpzVGVrWFF5bUgwcWJRVmovR1IzWmFwNTNFdDkxTC9I?=
 =?utf-8?B?NE5Rb2FGMzhUcEhlVjY3TGZOOHY0SVZHa2padTJVdmNWMXpic2dKc2ZxR2wy?=
 =?utf-8?B?VWJhNjgwcTViQzc4M1BjMGlQOGZndi93V3lNaFBYd215aTA5UnRDQzdjZTcy?=
 =?utf-8?B?Z2FyV2FWL3pTU2lteXVOeXFMaFZmT3JIN1VMcFljbjk2RjYyTjVsbXhlbHpy?=
 =?utf-8?B?VHR1U3BIVVVYc3ZOL0o4Z1RSaERxQ2hkQkN5U3E0dG1iZ2pySGh3NWxiYlUz?=
 =?utf-8?B?SUZhUmxYU3hDbEp4bmVWWk5GTFdqN28wTUtwUGp0cGhuWWg1SFZ5bmhMNWd3?=
 =?utf-8?B?ejdmMHlBNTJ0cERCN1NrTTV2UzcyUUtyRThYWjRwaUd2aTQrZ090TDZsT2M4?=
 =?utf-8?B?eXlmN3N6VGVSS0RWMHhXWmIvdzBFejcwcjJVcEIwQ1NqYTFLS1BaR0xjSUVq?=
 =?utf-8?B?WkhmSEs5UEE0R0NadGQwRGdqZ00rcndFOEI1aXFnc1pHdG1EWmNTckU5WkxK?=
 =?utf-8?B?R09sYmdVTHpDOEs3VmJVRW14MGprS3pxWlRUR0IyRnBqWGhqclVjM0d2aXAr?=
 =?utf-8?B?Mm0wYzhCcnZuSVdWR3JncnBwNVhPQ296b3FTZ3psc2FQNWdjdUtNNVVydU5z?=
 =?utf-8?B?UU5LU3VCNnhkQnVINDVYdUcxWlZWVzllS2tVSWJKOG5LVVRRa3pPV2lMckpP?=
 =?utf-8?B?bk5BM2ZOYWVLTm9aTWlTaGhLdmhBTFRKKzdtTkZjaStPMm5WdlhFZEJJOFFi?=
 =?utf-8?B?Zmc4ZGFIeTExU285azZSZE1UbEpsazkzelZFRi9jcDF3V0V2M25SakJhbG1E?=
 =?utf-8?B?c2U4Vks0c0VMQ3djRGVzYnRKWEE5ZDk1dEhnSlpQZm9kUjlWWVZpK1Uzc0ZE?=
 =?utf-8?B?L0pxUlFuYjQzMnhuUlBzRHJvdmliMW1iZ0RybU9LbmF1WjU4eW43MU5qaUxW?=
 =?utf-8?B?alNzN1cxWnlDU2cwdHRseGYvOVMvUHBBRUYxQUk1QTRkbGtteXloNkVyQ1Na?=
 =?utf-8?B?bkJDUXRwWGpkQ2FrUTB5TlFrZjZVcU1KTTlNaTV0RXhVSmdaaU5wRWptaTlL?=
 =?utf-8?B?MzBpdUM3TkRUZzJ6WjgrQnA3UXVweHNvRFk2SGExekUxaGVEK3RRemwwZFlo?=
 =?utf-8?B?YzJxcXNhV1lpNnJpU0dwTXdTSUV2UkpjYlpNNUFwMnhWN0NHa0x0WGNndTNl?=
 =?utf-8?B?dU43aVdNUUgydUZOWi9HMGZFYTlQR0I0VUlhZ1h6V2ZRL3U4Z0NFVWwrVkJk?=
 =?utf-8?B?VFE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	22UMMzCfSsRPbwmBGd7MEC/aCYsZcT5I8h591Mq6PLTQfdw1haYFQukXnKmGuolpnexzr2/8cRKcP2TwZy0LAd82NBjYK1ToNcAO/veSjyyizzW5G7YEWKx5fL6mvEVUVmKdAC7sUbwVWFPonm5QexgBNh7O+Rsnyijv437gwrB4Ww9Yw2ZkPZ6joFDU6XxBgsAsSduNaQJ7V2tGBFf7IKSiqm2UxzJe9Ej3COwQVnERxVcB+k2w5BiJvd3e1n/kIy7EivJkiF+KSsy9cgZgUOzgaqRV9ni6/JH7Olt2rezUcX2TQX0VzAVxHuvwb71ovlodsQ3Nb3v+gDN2lVikVgMZUJ3Ge5NrOTn5te2BXKTzTOUvk/2J6jmgeR0KmRhL268hg05AchPT1unx4RZUsOCM9khJpU1zFXHfzf9+lS4+gwMzvk5R+ucmXu1mXpyIx+MzfqeBanaA/hSP2NauUYkQQlDg94Ai+LlmzTh1VEDt0wjDxWw53O6xAghjQcSxoYOLJi+dOAqjW7nhoI4m4Y63EVr+SKrJtP9iLqIvN0jyIJCDpOvj3vJKDg7ta9pHnB+PlO8PqiW8TrdDqRzHTu9KbjLpkCSCh4CKAAxnfEtYXNY7XhKoiXAqbQkRz+EvCoYEvr6dxvJ6Ac1faID5vTPXra7DEkyiApEdKuRKun8ywxh5eh4vbDiLSp+z8fwRJBKidEpGUvpaY746zwQwioAYRHdNH2ytBzuyDihSp5e0v136Ko3VrMjtQvRXzyxwYfCgc8ubIXQkqAT3Q7W4Jfq/1nvSxtH2rqvbisIOs2ncx+6THAQKk02fo4rBUMSn
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 07fff5a9-9af7-4293-f49a-08dbf773b9da
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Dec 2023 22:27:41.5744
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BOMMlxwGnjydq6MPRrQT/xIiCa7kyEcBgmqFipKkO2PM5+2XeUC2SRDqYyxhL/LfFRW3QDMKsH0dUH3xI/4HBA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR10MB7245
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-07_17,2023-12-07_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 phishscore=0
 bulkscore=0 adultscore=0 spamscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312070189
X-Proofpoint-GUID: pvgUjkBRy902V3k08g07TYVKOwC9MAHW
X-Proofpoint-ORIG-GUID: pvgUjkBRy902V3k08g07TYVKOwC9MAHW

On Thu, Dec 07, 2023 at 05:21:50PM -0500, Olga Kornievskaia wrote:
> On Thu, Dec 7, 2023 at 9:44 AM Chuck Lever <chuck.lever@oracle.com> wrote:
> >
> > On Wed, Dec 06, 2023 at 04:33:32PM -0500, Olga Kornievskaia wrote:
> > > From: Olga Kornievskaia <kolga@netapp.com>
> > >
> > > If we have rpc_gss_sccreate in tirpc library define
> > > HAVE_TIRPC_GSS_SECCREATE, which would allow us to handle bad_integrity
> > > errors.
> > >
> > > Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> > > ---
> > >  aclocal/libtirpc.m4 | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/aclocal/libtirpc.m4 b/aclocal/libtirpc.m4
> > > index bddae022..ef48a2ae 100644
> > > --- a/aclocal/libtirpc.m4
> > > +++ b/aclocal/libtirpc.m4
> > > @@ -26,6 +26,11 @@ AC_DEFUN([AC_LIBTIRPC], [
> > >                                      [Define to 1 if your tirpc library provides libtirpc_set_debug])],,
> > >                           [${LIBS}])])
> > >
> > > +     AS_IF([test -n "${LIBTIRPC}"],
> > > +           [AC_CHECK_LIB([tirpc], [rpc_gss_seccreate],
> > > +                         [AC_DEFINE([HAVE_TIRPC_GSS_SECCREATE], [1],
> > > +                                    [Define to 1 if your tirpc library provides rpc_gss_seccreate])],,
> > > +                         [${LIBS}])])
> > >    AC_SUBST([AM_CPPFLAGS])
> > >    AC_SUBST(LIBTIRPC)
> >
> > It would be better for distributors if this checked that the local
> > version of libtirpc has the rpc_gss_seccreate fix that you sent.
> > The PKG_CHECK_MODULES macro should work for that, once you know the
> > version number of libtirpc that will have that fix.
> >
> > Also, this patch should come either before "gssd: switch to using
> > rpc_gss_seccreate()" or this change should be squashed into that
> > patch, IMO.
> 
> I can certainly re-arrange the order (if Steve wants me to re-send an
> ordered list).  I attempted to address your comment to  check for
> existence of the function or fallback to the old way.

A comment that I made when I thought no changes to rpc_gss_seccreate(3t)
would be needed.... But you found and fixed a bug there.


> I'm not sure I'm
> capable of producing something that depends on distro versioning (or
> am I supposed to be)?

I think this series truly needs to check the libtirpc version.
Otherwise the build will complete successfully, gssd will use
rpc_gss_seccreate(), but it will be broken.

Grep for PKG_CHECK_MODULES in the other files in aclocal/ and you
should find a pattern to use.


> I think this goes back to me hoping that a
> distro would create matching set of libtirpc and nfs-utils rpms...

IME distros don't work that way.


-- 
Chuck Lever