Received-SPF: pass (google.com: domain of linux-nfs+bounces-464-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <815dd284-14c7-4990-9ef7-41bd7087b724@kernel.dk>
Date: Fri, 8 Dec 2023 07:33:00 -0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 0/3] nfsd: fully close all files in the nfsd threads
Content-Language: en-US
To: NeilBrown <neilb@suse.de>, Al Viro <viro@zeniv.linux.org.uk>,
 Christian Brauner <brauner@kernel.org>, Oleg Nesterov <oleg@redhat.com>,
 Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-nfs@vger.kernel.org
References: <20231208033006.5546-1-neilb@suse.de>
From: Jens Axboe <axboe@kernel.dk>
In-Reply-To: <20231208033006.5546-1-neilb@suse.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 12/7/23 8:27 PM, NeilBrown wrote:
> This is a new version of my patches to address a rare problem with nfsd
> closing files faster than __fput() can complete the close in a different
> thread.
> 
> This time I'm simply switching to __fput_sync().  I cannot see any
> reason that this would be a problem, but if any else does and can show
> me what I'm missing, I'd appreciate it.

Much better than the previous attempts, imho.

Reviewed-by: Jens Axboe <axboe@kernel.dk>

-- 
Jens Axboe