Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp4043719rdb; Mon, 11 Dec 2023 07:24:29 -0800 (PST) X-Google-Smtp-Source: AGHT+IGgU5zqMPmsKK4sGwKu6Z4A7kpKxdwFr7PaPy1Hc7WipC2cYzfclxvHVfk+dffloVsfpDb3 X-Received: by 2002:a17:902:c1ca:b0:1d0:aeda:9acf with SMTP id c10-20020a170902c1ca00b001d0aeda9acfmr1815160plc.18.1702308269623; Mon, 11 Dec 2023 07:24:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702308269; cv=none; d=google.com; s=arc-20160816; b=rPGxscamBW3PCS+DhN4C0sJZK/u+6OXu+3KXa6qChSrqFknsb1pa08CXLs11Cy8+7c 1QmZfmfH5cTtmtRJjZ3PcyiNUyB6A74UA8+jBWPb3fejvomyks17uVloCCA/cnLBQAGs uRgQ1DwxGtK+iGEcCukTR9SeWwSRs8T/I+RzbNHN4ir+J6nJdaK4fE+e3I3iCtQ9ey1k sLEjkpbC+TJq5AIqgrtRzwQPWRbODozF355dhCB0WFKuh2F3Mqo7qeI/+AZ/m5QhkXHs 8BCDm6OxlmqH8KVyt3LNoMS9TPRkFjx4Un3gRqC1R1oMS50AXMtpLOMu9PeVrJf3D87C GqgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:user-agent:references:in-reply-to :message-id:date:cc:to:from:subject:dkim-signature; bh=Tmb0qiQk2TbEOQZIlWg0oMr4BkPo2MD7nGHUlj6JvoI=; fh=WfGVbliYpqgzl5GprTVUBQR8rnRPHqjfX8LKlqDYYGk=; b=GSWaRFBGGruoGwonnp324O14ymLrxBI7F3IBRWeveWn1ehEwFjcDrOvS2O7kbsDnf0 Ev6CF27e9NOhiGHnE4J+N+OF3Px0r6GyYra46kaWSHwPY5SJqtapuq7gcUnVpByR5Cwx m34nmZCwHRk5B454iK5AN17ixp1SyKklqXD7g38J1DWmBTmE8lCwH8u4ERc++WNAuRcb Aer2PEynjKSPTXHHa5s0FNvTHP/dYS4qB1UryjvjjjLPPxsyZg+mb0PKMHdX2VC4biXa dkzPVfmddXSK5fM8vEmBpyQNOaDW4Ytmy0hosLVTRPo11ZGBniSZ6Rq7Yk5ZlEAhNu8L g0HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qOX7TxX8; spf=pass (google.com: domain of linux-nfs+bounces-485-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-485-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id w4-20020a170902e88400b001d08bbcf772si6436392plg.362.2023.12.11.07.24.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 07:24:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-485-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qOX7TxX8; spf=pass (google.com: domain of linux-nfs+bounces-485-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-nfs+bounces-485-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 56F78B21427 for ; Mon, 11 Dec 2023 15:24:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 252604AF9A; Mon, 11 Dec 2023 15:24:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qOX7TxX8" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 050593B184; Mon, 11 Dec 2023 15:24:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 925E3C433C8; Mon, 11 Dec 2023 15:24:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702308262; bh=w4I9suP34OK/T9wqgSV5LFh9uj8Gkgnu9+/UaxfsYwU=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=qOX7TxX8tbbI5Gqvq7zJAKcvkyThMAgKUwwtCSD1c5g61NdbVI10gJvbKK0GQJHIp dcchV8c21R5aoYEQ7ZnSPtVg1t/ftdkAX6NU1Nau3TElWuuOjmIUEMdm7zdIPkAggL Ue7JI2L95xLODC4gcFWL5qwzp0W+8M0g91v1IF7M3nLn9pGPvnsTIqnCCfpbM2Hf2k PCnGomzkkyODz2N7Z06PHrO3eilD9rQ+vU/p06jnIU8fxYxCv+o7j9TYK20cLbU8xE I8MYtSkm2Reztc+yIbFb5sI2upjatwNFu2nLHPCc0fKTebMQ2RP09Cbk1Qf1+AtvOp J4PTqXIO6T4vg== Subject: [PATCH v1 3/8] svcrdma: Remove pointer addresses shown in dprintk() From: Chuck Lever To: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org Cc: tom@talpey.com Date: Mon, 11 Dec 2023 10:24:21 -0500 Message-ID: <170230826159.90242.7084253882158192266.stgit@bazille.1015granger.net> In-Reply-To: <170230788373.90242.9421368360904462120.stgit@bazille.1015granger.net> References: <170230788373.90242.9421368360904462120.stgit@bazille.1015granger.net> User-Agent: StGit/1.5 Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit From: Chuck Lever There are a couple of dprintk() call sites in svc_rdma_accept() that show pointer addresses. These days, displayed pointer addresses are hashed and thus have little or no diagnostic value, especially for site administrators. Signed-off-by: Chuck Lever --- net/sunrpc/xprtrdma/svc_rdma_transport.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c index 3826da1c15f3..451814eb12b9 100644 --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c @@ -457,8 +457,6 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) qp_attr.qp_type = IB_QPT_RC; qp_attr.send_cq = newxprt->sc_sq_cq; qp_attr.recv_cq = newxprt->sc_rq_cq; - dprintk("svcrdma: newxprt->sc_cm_id=%p, newxprt->sc_pd=%p\n", - newxprt->sc_cm_id, newxprt->sc_pd); dprintk(" cap.max_send_wr = %d, cap.max_recv_wr = %d\n", qp_attr.cap.max_send_wr, qp_attr.cap.max_recv_wr); dprintk(" cap.max_send_sge = %d, cap.max_recv_sge = %d\n", @@ -512,7 +510,7 @@ static struct svc_xprt *svc_rdma_accept(struct svc_xprt *xprt) } #if IS_ENABLED(CONFIG_SUNRPC_DEBUG) - dprintk("svcrdma: new connection %p accepted:\n", newxprt); + dprintk("svcrdma: new connection accepted on device %s:\n", dev->name); sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.src_addr; dprintk(" local address : %pIS:%u\n", sap, rpc_get_port(sap)); sap = (struct sockaddr *)&newxprt->sc_cm_id->route.addr.dst_addr;