Received: by 2002:a05:7412:8d10:b0:f3:1519:9f41 with SMTP id bj16csp5351222rdb; Wed, 13 Dec 2023 06:26:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IEjrUX+i7LvSO7/4BGG/duOsu1PVNA6iX4WWQOZsxzkGGPIo/UwEOcfmzAN0CKPvAxvCsFF X-Received: by 2002:a05:6a20:a107:b0:18f:e2c9:9751 with SMTP id q7-20020a056a20a10700b0018fe2c99751mr11926067pzk.19.1702477601467; Wed, 13 Dec 2023 06:26:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1702477601; cv=none; d=google.com; s=arc-20160816; b=0dHMhOVSvavs50pxe1XFuQc/7HMmGJy7m0Q5RrBTdtCQoG9kOar0TtgbvwautsFKAA zR2i6zU4EqMZoByxLWXD3DsyPnpPuFStMef24yivuZOjckNYaeNRGAY9Jf0BLXZw4b2n R0biuODXcPMUJaqHLaR9bK/ICz/NyTVTwT+3icOg9jKm5RO447RoVokN53cHnsDcpbN9 VpJWZ1TRI687zygkQLiQX2Z5MrmzM9hr8qZj5GEWUkVP1FT1COlgTU53Ctg5AN1niYZJ MG8PucZnYAmBrF94TGKgd2WiqKlg0QfHD44outBomgKozZSroag3yhJPJrJCWi0rvSde L5vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :user-agent:content-transfer-encoding:autocrypt:references :in-reply-to:date:cc:to:from:subject:message-id:dkim-signature; bh=8Ba2CzgDViLKVdv2/Y6wxQtRFhe8MTSo3FqCrkP2mvY=; fh=yymzW1toUYdmcHA+lXTXaG9P+ArGYP4UJGp5e/VtTnw=; b=TpXrr1aQwN6q5klYctgS75UGjPew4tQurn77rN0d+OMItU0EzbC5yNMDlomj6usVDO zgB0WF1lWMdIMSifZlvc8/I4h0CppzunvdFtruYq4Ynks2cEXG5oq2VN+zHlRfDanM9B 3TF1oU/fexlfvBt0+luqtVsFrXEi0CIKEZiQeXUqGMxQzdapKNZKDgGizPVHmTneiCTK O3pw+wfGMb8jg0JSxswYSHCpmfB0Bhs2vmQhaY0UXQV6MSf3FjjmF6qOgQHnxn+Y1mDW Xz1J4OaVQjyZ5uR0bfjuxsY/M6B6rkCKkxQvaK3tbyxPxW3OCWOXZyGCqLt0DrFEZsxe uCUQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oWPJduSM; spf=pass (google.com: domain of linux-nfs+bounces-511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-nfs+bounces-511-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id a16-20020a656410000000b005b106cd44casi9548958pgv.145.2023.12.13.06.26.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 06:26:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-nfs+bounces-511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oWPJduSM; spf=pass (google.com: domain of linux-nfs+bounces-511-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-nfs+bounces-511-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 2CAE8B20C21 for ; Wed, 13 Dec 2023 14:26:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 01D0D2E848; Wed, 13 Dec 2023 14:26:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oWPJduSM" X-Original-To: linux-nfs@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D73B02E3FF for ; Wed, 13 Dec 2023 14:26:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9918EC433C7; Wed, 13 Dec 2023 14:26:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702477595; bh=dofaZavQ5QSZZHVwo5tenL/YgmVS+tUEXqYK0QeC6EI=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=oWPJduSM7WxMLTCX4Ss9dCQiw2YOk/XyVAz7imZtndzb7bsiteWrYmSgqF8yzOv7j bi8ACrQ96nE3aa+OtxaA8CsPTgvMGoGBXvKjIcXPU/3pz5gLO95kZqADAWOhemiaEv qUts8/gB5NCG67/2XAziyCz1S7LO5bnrex5nhuTlnpdxTywXIx0XKClMqdre+3vElZ WAaKs4jkNnedc4JnP/twucvHh4lj63Ab7WyIx+vpKrcNvbr9k2vmwM+O5HJv+rYZcv pivpbSfy0JuLbze/lCPZ3aYxXqU4rS2OW/7DKzXuL2ritx9oUZJXti0bS46Y1cw2o9 k7MwY10Jq5cFQ== Message-ID: <3bada85ea59a20e68367f8ea98355dc76f31e42f.camel@kernel.org> Subject: Re: [PATCH] nfsd: properly tear down server when write_ports fails From: Jeff Layton To: NeilBrown , Chuck Lever Cc: Olga Kornievskaia , Dai Ngo , Tom Talpey , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org, Zhi Li Date: Wed, 13 Dec 2023 09:26:33 -0500 In-Reply-To: <170243914810.12910.1721447953189600231@noble.neil.brown.name> References: <20231211-nfsd-fixes-v1-1-c87a802f4977@kernel.org> , <170233558429.12910.17902271117186364002@noble.neil.brown.name> , , , <170243914810.12910.1721447953189600231@noble.neil.brown.name> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxwn8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1WvegyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqVT2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtVYrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8snVluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQcDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQfCBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sELZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/ r0kmR/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2BrQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRIONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZWf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQOlDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7RjiR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27XiQQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBMYXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9qLqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoac8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3FLpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx 3bri75n1TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y+jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5dHxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBMBAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4hN9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPepnaQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQRERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8EewP8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0XzhaKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyA nLqRgDgR+wTQT6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7hdMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjruymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItuAXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfDFOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbosZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDvqrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51asjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qGIcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbLUO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0 b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSUapy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5ddhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7eflPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7BAKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuac BOTtmOdz4ZN2tdvNgozzuxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9JDfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRDCHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1gYy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVVAaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJOaEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhpf8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+mQZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65ke5Ag0ETpXRPAEQAJkVmzCmF+IEenf9a2nZRXMluJohnfl2wCMmw5qNzyk0f+mYuTwTCpw7BE2H0yXk4ZfAuA+xdj14K0A1Dj52j/fKRuDqoNAhQe0b6ipo85Sz98G+XnmQOMeFVp5G1Z7r/QP/nus3mXvtFsu9lLSjMA0cam2NLDt7vx3l9kUYlQBhyIE7/DkKg+3fdqRg7qJoMHNcODtQY+n3hMyaVpplJ/l0DdQDbRSZi5AzDM3DWZEShhuP6/E2LN4O3xWnZukEiz688d1ppl7vBZO9wBql6Ft9Og74diZrTN6lXGGjEWRvO55h6ijMsLCLNDRAVehPhZvSlPldtUuvhZLAjdWpwmzbRIwgoQcO51aWeKthpcpj8feDdKdlVjvJO9fgFD5kqZ QiErRVPpB7VzA/pYV5Mdy7GMbPjmO0IpoL0tVZ8JvUzUZXB3ErS/dJflvboAAQeLpLCkQjqZiQ/DCmgJCrBJst9Xc7YsKKS379Tc3GU33HNSpaOxs2NwfzoesyjKU+P35czvXWTtj7KVVSj3SgzzFk+gLx8y2Nvt9iESdZ1Ustv8tipDsGcvIZ43MQwqU9YbLg8k4V9ch+Mo8SE+C0jyZYDCE2ZGf3OztvtSYMsTnF6/luzVyej1AFVYjKHORzNoTwdHUeC+9/07GO0bMYTPXYvJ/vxBFm3oniXyhgb5FtABEBAAGJAh8EGAECAAkFAk6V0TwCGwwACgkQAA5oQRlWghXhZRAAyycZ2DDyXh2bMYvI8uHgCbeXfL3QCvcw2XoZTH2l2umPiTzrCsDJhgwZfG9BDyOHaYhPasd5qgrUBtjjUiNKjVM+Cx1DnieR0dZWafnqGv682avPblfi70XXr2juRE/fSZoZkyZhm+nsLuIcXTnzY4D572JGrpRMTpNpGmitBdh1l/9O7Fb64uLOtA5Qj5jcHHOjL0DZpjmFWYKlSAHmURHrE8M0qRryQXvlhoQxlJR4nvQrjOPMsqWD5F9mcRyowOzr8amasLv43w92rD2nHoBK6rbFE/qC7AAjABEsZq8+TQmueN0maIXUQu7TBzejsEbV0i29z+kkrjU2NmK5pcxgAtehVxpZJ14LqmN6E0suTtzjNT1eMoqOPrMSx+6vOCIuvJ/MVYnQgHhjtPPnU86mebTY5Loy9YfJAC2EVpxtcCbx2KiwErTndEyWL+GL53LuScUD7tW8vYbGIp4RlnUgPLbqpgssq2gwYO9m75FGuKuB2+2bCGajqalid5nzeq9v7cYLLRgArJfOIBWZrHy2m0C+pFu9DSuV6SNr2dvMQUv1V58h0FaSOxHVQnJdnoHn13g/CKKvyg2EMrMt/EfcXgvDwQbnG9we4xJiWOIOcsvrWcB6C6lWBDA+In7w7SXnnok kZWuOsJdJQdmwlWC5L5ln9xgfr/4mOY38B0U= Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.50.2 (3.50.2-1.fc39) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2023-12-13 at 14:45 +1100, NeilBrown wrote: > On Wed, 13 Dec 2023, Chuck Lever wrote: > > On Tue, Dec 12, 2023 at 08:50:46AM -0500, Chuck Lever wrote: > > > On Mon, Dec 11, 2023 at 06:11:04PM -0500, Jeff Layton wrote: > > > > On Tue, 2023-12-12 at 09:59 +1100, NeilBrown wrote: > > > > > On Tue, 12 Dec 2023, Jeff Layton wrote: > > > > > > When the initial write to the "portlist" file fails, we'll curr= ently put > > > > > > the reference to the nn->nfsd_serv, but leave the pointer intac= t. This > > > > > > leads to a UAF if someone tries to write to "portlist" again. > > > > > >=20 > > > > > > Simple reproducer, from a host with nfsd shut down: > > > > > >=20 > > > > > > # echo "foo 2049" > /proc/fs/nfsd/portlist > > > > > > # echo "foo 2049" > /proc/fs/nfsd/portlist > > > > > >=20 > > > > > > The kernel will oops on the second one when it trips over the d= angling > > > > > > nn->nfsd_serv pointer. There is a similar bug in __write_ports_= addfd. > > > > > >=20 > > > > > > This patch fixes it by adding some extra logic to nfsd_put to e= nsure > > > > > > that nfsd_last_thread is called prior to putting the reference = when the > > > > > > conditions are right. > > > > > >=20 > > > > > > Fixes: 9f28a971ee9f ("nfsd: separate nfsd_last_thread() from nf= sd_put()") > > > > > > Closes: https://issues.redhat.com/browse/RHEL-19081 > > > > > > Reported-by: Zhi Li > > > > > > Signed-off-by: Jeff Layton > > > > > > --- > > > > > > This should probably go to stable, but we'll need to backport f= or v6.6 > > > > > > since older kernels don't have nfsd_nl_rpc_status_get_done. We = should > > > > > > just be able to drop that hunk though. > > > > > > --- > > > > > > fs/nfsd/nfsctl.c | 32 ++++++++++++++++++++++++++++---- > > > > > > fs/nfsd/nfsd.h | 8 +------- > > > > > > fs/nfsd/nfssvc.c | 2 +- > > > > > > 3 files changed, 30 insertions(+), 12 deletions(-) > > > > >=20 > > > > > This is much the same as > > > > >=20 > > > > > https://lore.kernel.org/linux-nfs/20231030011247.9794-2-neilb@sus= e.de/ > > > > >=20 > > > > > It seems that didn't land. Maybe I dropped the ball... > > > >=20 > > > > Indeed it is. I thought the problem seemed familiar. Your set is > > > > considerably more comprehensive. Looks like I even sent some Review= ed- > > > > bys when you sent it. > > > >=20 > > > > Chuck, can we get these in or was there a problem with them? > > >=20 > > > Offhand, I'd say either I was waiting for some review comments > > > to be addressed or the mail got lost (vger or Exchange or I > > > accidentally deleted the series). I'll go take a look. > >=20 > > I reviewed the thread: > >=20 > > https://lore.kernel.org/linux-nfs/20231030011247.9794-1-neilb@suse.de/ > >=20 > > From the looks of it, I was expecting Neil to address a couple of > > review comments and repost. These are the two comments that stand > > out to me now: > >=20 > > On 1/5: > >=20 > > > > Then let's add > > > >=20 > > > > Fixes: ec52361df99b ("SUNRPC: stop using ->sv_nrthreads as a refcou= nt") > > > >=20 > > > > to this one, since it addresses a crasher seen in the wild. > > >=20 > > > Sounds good. > > >=20 > > > > > but it won't fix the hinky error cleanup in nfsd_svc. It looks li= ke that > > > > > does get fixed in patch #4 though, so I'm not too concerned. > > > >=20 > > > > Does that fix also need to be backported? > > >=20 > > > I think so, but we might want to split that out into a more targeted > > > patch and apply it ahead of the rest of the series. Our QA folks seem= to > > > be able to hit the problem somehow, so it's likely to be triggered by > > > people in the field too. > >=20 > > This last paragraph requests a bit of reorganization to enable an > > easier backport. >=20 > I think the "error cleanup" was addressed in a different series. Maybe > it hasn't landed either. >=20 > >=20 > > And on 2/5: > >=20 > > > > > > +struct pool_private { > > > > > > + struct svc_serv *(*get_serv)(struct seq_file *, bool); > > > > >=20 > > > > > This bool is pretty ugly. I think I'd rather see two operations h= ere > > > > > (get_serv/put_serv). Also, this could use a kerneldoc comment. > > > >=20 > > > > I agree that bool is ugly, but two function pointers as function ar= gs > > > > seemed ugly, and stashing them in 'struct svc_serv' seemed ugly. > > > > So I picked one. I'd be keen to find an approach that didn't requi= re a > > > > function pointer. > > > >=20 > > > > Maybe sunrpc could declare > > > >=20 > > > > struct svc_ref { > > > > struct mutex mutex; > > > > struct svc_serv *serv; > > > > } > > > >=20 > > > > and nfsd could use one of those instead of nfsd_mutex and nfsd_serv= , and > > > > pass a pointer to it to the open function. > > > >=20 > > > > But then the mutex would have to be in the per-net structure. And = maybe > > > > that isn't a bad idea, but it is a change... > > > >=20 > > > > I guess I could pass pointers to nfsd_mutex and nn->nfsd_serv to th= e > > > > open function.... > > > >=20 > > > > Any other ideas? > > >=20 > > > I think just passing two function pointers to svc_pool_stats_open, an= d > > > storing them both in the serv is the best solution (for now). Like yo= u > > > said, there are no clean options here. That function only has one cal= ler > > > though, so at least the nastiness will be confined to that. > > >=20 >=20 > We can't store the function pointers in the serv because the purpose of > the first function is to find the serv. >=20 Sorry, I didn't mean the serv there. You had this in the patch: +struct pool_private { + struct svc_serv *(*get_serv)(struct seq_file *, bool); + struct svc_serv *serv; +}; Let's just make that: +struct pool_private { + struct svc_serv *(*get_serv)(struct seq_file *); + struct svc_serv *(*put_serv)(struct seq_file *); + struct svc_serv *serv; +}; ...and then just have svc_pool_stats_open take 2 function pointers. It's not pretty but it should be fine. We have other functions that take multiple function pointers in the kernel, so I don't see it as that bad. > I guess I should just repost everything again.... but it isn't a good > time for year for sustained debates. >=20 >=20 That would be good. I'm hoping this is close to merge ready. > > > Moving the mutex to be per-net does make a lot of sense, but I think > > > that's a separate project. If you decide to do that and it allows you= to > > > make a simpler interface for handling the get/put_serv pointers, then > > > the interface can be reworked at that point. > >=20 > > The other requests I see in that thread have already been answered > > adequately. > >=20 > >=20 > > --=20 > > Chuck Lever > >=20 >=20 --=20 Jeff Layton