Received-SPF: pass (google.com: domain of linux-nfs+bounces-625-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 15 Dec 2023 22:29:43 +0900
From: Dominique Martinet <asmadeus@codewreck.org>
To: Christian Brauner <brauner@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>, Steve French <smfrench@gmail.com>,
	David Howells <dhowells@redhat.com>,
	Matthew Wilcox <willy@infradead.org>,
	Marc Dionne <marc.dionne@auristor.com>,
	Paulo Alcantara <pc@manguebit.com>,
	Shyam Prasad N <sprasad@microsoft.com>, Tom Talpey <tom@talpey.com>,
	Eric Van Hensbergen <ericvh@kernel.org>,
	Ilya Dryomov <idryomov@gmail.com>, linux-cachefs@redhat.com,
	linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org,
	linux-nfs@vger.kernel.org, ceph-devel@vger.kernel.org,
	v9fs@lists.linux.dev, linux-fsdevel@vger.kernel.org,
	linux-mm@kvack.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 00/39] netfs, afs, 9p: Delegate high-level I/O to
 netfslib
Message-ID: <ZXxUx_nh4HNTaDJx@codewreck.org>
References: <20231213152350.431591-1-dhowells@redhat.com>
 <20231215-einziehen-landen-94a63dd17637@brauner>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20231215-einziehen-landen-94a63dd17637@brauner>

Christian Brauner wrote on Fri, Dec 15, 2023 at 01:03:14PM +0100:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
> branch: vfs.netfs

This doesn't seem to build:
-------
  CC [M]  fs/netfs/buffered_write.o
fs/netfs/buffered_write.c: In function ‘netfs_kill_pages’:
fs/netfs/buffered_write.c:569:17: error: implicit declaration of function ‘generic_error_remove_folio’; did you mean ‘generic_error_remove_page’? [-Werror=implicit-function-declaration]
  569 |                 generic_error_remove_folio(mapping, folio);
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~
      |                 generic_error_remove_page
cc1: some warnings being treated as errors
-------

This helper is present in -next as commit af7628d6ec19 ("fs: convert
error_remove_page to error_remove_folio") (as of now's next), apparently
from akpm's mm-stable:
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm mm-stable

(which obviously have some conflict in afs when trying to merge...)


I'll go back to dhowell's tree to finally test 9p a bit,
sorry for lack of involvement just low on time all around.


Good luck (?),
-- 
Dominique Martinet | Asmadeus