Received-SPF: pass (google.com: domain of linux-nfs+bounces-631-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Fri, 15 Dec 2023 10:52:26 -0500
From: Chuck Lever <chuck.lever@oracle.com>
To: NeilBrown <neilb@suse.de>
Cc: Jeff Layton <jlayton@kernel.org>, linux-nfs@vger.kernel.org,
        Olga Kornievskaia <kolga@netapp.com>, Dai Ngo <Dai.Ngo@oracle.com>,
        Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 0/2 v2] nfsd: fully close files in the nfsd threads
Message-ID: <ZXx2Oklp51L+fIXp@tissot.1015granger.net>
References: <20231215012059.30857-1-neilb@suse.de>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20231215012059.30857-1-neilb@suse.de>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?SqocZ/D88AURcrW5RqI03FwTEDeDIhU0YS8z2dw6cMZfwXWag/SXphoS+CQ1?=
 =?us-ascii?Q?2LknNAOTE9MBH/LynZZTymMBmfzp1EjQ4vHItJs8mWxTRnTxSQ0b5ltnO7Lm?=
 =?us-ascii?Q?LYlq5SQeRqSgDq+TUToMNb5yw9LE2TFky6H+byuCw8BuZ7zMgNghdmuOc2o4?=
 =?us-ascii?Q?r+bnyaRY5wZmBx+pM1Gw9eXJN+VicbSjpfKHJ2jhouTVzOm6uC/UZnsvpyhV?=
 =?us-ascii?Q?0eUqshsKovYJGmnuqWDqzVKy0vprOr2wH3tB5zQ7uS/5VUzhqy0uOIrPMfFM?=
 =?us-ascii?Q?bOUnKtwC2k+ggoFm5Fp0301OH5H3AdlN5RykGp73qrLTQn4zmcZ6RVLjKeQl?=
 =?us-ascii?Q?UrgvDAnaf4d1Z8Pr1fJS9Sc0XwMWyySAefFPbIbCJKIOst1rj4kMjf0NpDYX?=
 =?us-ascii?Q?ZeeZ8uxKReOf/HDPgHHuKWBddoCrfCywXGR08G2gPQDUFyjVM0hriZOQA3r3?=
 =?us-ascii?Q?rWYf6aUxNgbaVSeR8rKq1M61sP/LMfSMfoP5JWtQYYWBSqnUEB/2IIItjFpT?=
 =?us-ascii?Q?ZX3dyI1TKdheW1Qt/Q6SlC1DBnpxnbqJVbL7l576qJoqr70Qays2XH6Tm3QK?=
 =?us-ascii?Q?/d/p882+JB4v4csFiCWZ2eWKb1z50TJqw1k2LGSX3BNfTnDBE5zYt1vU56Ky?=
 =?us-ascii?Q?qMDEjqNDiX3uEQXHFY5N5ibfVPrj64MzJ7kYFwfisHIiofdX82+k/dfVF/7X?=
 =?us-ascii?Q?/s3d3LUzLBpU8wCo2uoihi4rAoklBczl4S/EEXAVkBH02dv3RfXpo+0T/CiP?=
 =?us-ascii?Q?34IXb7URevnl3ng4Jr4Sheestt9uUS0tvzkfkvlPD/13+CekaHU9DJKK4gcV?=
 =?us-ascii?Q?byFZ1Gvacn5lyVrQnj3dd6vp/5VRcqN6ZiCW3VwrsGopFTkHDF86UyQEv0YE?=
 =?us-ascii?Q?Lym0imCRmRwt4SMai5MAfwAc1ejKYyCmrLHE7I6wbFC6fZ2cNsO4HyYVLCYR?=
 =?us-ascii?Q?cueTwvXuh7yjlq1iagKkiemyynRQs0qnGiJn8WBrAIa9O+RxWEH1UpA5JfpV?=
 =?us-ascii?Q?ONB/DHmsk3eE/qbDrhcN9M6spoS0LeYBaNcKKUAwv3F7qwOC+8EFqlfv7cCD?=
 =?us-ascii?Q?1Xe8KDs2J89T/D6JFbO1CfO9cwxp3S2+cZUlH+b7mBMsCf2GSVtNmyH3JfRl?=
 =?us-ascii?Q?517Z4d7PQSMAC4BoQXvb5X9mOtVgEiIrm+Mjwq0PInpU8Yxyekq337bUfYa5?=
 =?us-ascii?Q?At7EtGaOEvtzy2+5rDUhPEnDESyjfT/ffvmlXUs6kYB65PD39lP0Dx/FTzx0?=
 =?us-ascii?Q?0E/n+DoNtJbIv84LWuKjDRxMqDVibhQYyCr/dQ5jex0WhBx1ccfO348QSXgS?=
 =?us-ascii?Q?qkjGo20q3YJHvo6dWgBgTbpd0Mo3FrqXNSfpSHYMLadI+717osJ7p7OOHwaM?=
 =?us-ascii?Q?D/it9PVgzQ+CW4Vaaj+88su5/KnPgn44ptkYjetnZ6HsbSPI2itgXe6K5jGi?=
 =?us-ascii?Q?t5q8TWRW8qAcDLmy6rSy4hDbRcgfZytClK5WXSZBfs0KA9fXhQW+mvYqdEjW?=
 =?us-ascii?Q?9n329VQ4nq1etTKL448fCj6hUHB/7PGt2yyAWNj4o4d7sjmJc59TdCyVYjm4?=
 =?us-ascii?Q?7h9xmfyrSxri4813Y/Kxy5TnvseXLeDic68TS9a6VpUFpjZh+r02nS4vv2Mw?=
 =?us-ascii?Q?Wg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	h9/MmL/QsGiAs2AplP5tkMguY0VDjGU8trhHEs7sSXmXqsMTYHJWlcPNyJiKbrBWfrZQ2deMYZ7TUsc5YvpUA5rp3voAVTsz+m3g0ZczguloFdOU48YeirLzMAjSv+A6u2rvf59PgDZScLvY1tJJHjlEdA4rMj2tkuTIPp/6QJZbBVDkZr+YllXnbCIXe5lEWVmDYZ34SHVPQOQQXuFHFgWTeyZlxxLYp3Ul3c31sBo7NWR/JKhbpmtuPLRKoKDuuy0nT6GtLJ8bqkZn8p3N9UWhcWKGLc68hTdXOT5hU+iPdAUtMYnaMyi3sm2WgcU+M+PIKZh4A6hSLlaQJ2y3ngDuWokXgBdocTTbvIuaqu3qVsSKaX0sTDAADy6efIJG56sZuvJgYMWHhvj1G1tmRtGP/JOgjmr6yriG5LViNWum/LxKGdn1n9BeAMZunonBiBq32e4Wd3M7jNPfIMNMC0SLlo3TMIqMetusEqgMZqNCGKkb9zHfZwk5Vp2emlb5EUXbJSn7NCk/wAeeuLEKu/Q0FSYKF6O0Hiix4mZU9SkVSub1NmpiMkqVj8HUZ3EY/ia//p+77zVzSzh96EsOdHQiNQH41UARPKG5WIpWeps=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d31a4eb8-5d68-47f7-d867-08dbfd85d7ea
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Dec 2023 15:52:29.9746
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: lMf/VYWShNnPgjKY9gq2fKm3jKg5nEsK86ZixFs8Z0WTT5liYsVtz4k8ToEE6T2uQ39M/mHyXKmFAydyu5Ejig==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5793
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-15_10,2023-12-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=861 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2312150109
X-Proofpoint-GUID: QMvpTHdn8eNO4LxC357TlOtL8dpQOSeN
X-Proofpoint-ORIG-GUID: QMvpTHdn8eNO4LxC357TlOtL8dpQOSeN

On Fri, Dec 15, 2023 at 12:18:29PM +1100, NeilBrown wrote:
> This is a revised version of my recent series to have nfs close files
> directly and not leave work to an async work queue.
> 
> This version takes a more cautious approach and only using __fput_sync()
> where there is a reasonable case that it could make a practical
> difference.

Hi Neil, thanks for the revisions and documentation.

Jeff and I would like to see this set spend some time in linux-next
before getting merged. We're just about on the cusp of closing out
nfsd-next for v6.8, so my plan is to apply these to nfsd-next just
as soon as v6.9 opens to give testers and bots plenty of time to
exercise them.


-- 
Chuck Lever