Received-SPF: pass (google.com: domain of linux-nfs+bounces-668-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0
From: "NeilBrown" <neilb@suse.de>
To: Ahelenia =?utf-8?q?Ziemia=C5=84ska?= <nabijaczleweli@nabijaczleweli.xyz>
Cc: "Trond Myklebust" <trond.myklebust@hammerspace.com>,
 "Anna Schumaker" <anna@kernel.org>, "Chuck Lever" <chuck.lever@oracle.com>,
 "Jeff Layton" <jlayton@kernel.org>, "Olga Kornievskaia" <kolga@netapp.com>,
 "Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
 "David S. Miller" <davem@davemloft.net>, "Eric Dumazet" <edumazet@google.com>,
 "Jakub Kicinski" <kuba@kernel.org>, "Paolo Abeni" <pabeni@redhat.com>,
 linux-nfs@vger.kernel.org, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sunrpc: sizeof('\0') is 4, not 1
In-reply-to:
 <4zlmy3qwneijnrsbygfr2wbsnvdvcgvjyvudqnuxq5zvwmyaof@tarta.nabijaczleweli.xyz>
References:
 <4zlmy3qwneijnrsbygfr2wbsnvdvcgvjyvudqnuxq5zvwmyaof@tarta.nabijaczleweli.xyz>
Date: Sat, 16 Dec 2023 15:27:16 +1100
Message-id: <170270083607.12910.2219100479356858889@noble.neil.brown.name>

On Sat, 16 Dec 2023, Ahelenia Ziemia=C5=84ska wrote:
> To make it self-documenting, the referenced commit added the space
> for the null terminator as sizeof('\0'). The message elaborates on
> why only one byte is needed, so this is clearly a mistake.
> Spell it as 1 /* NUL */ instead.
>=20
> This is the only result for git grep "sizeof.'" in the tree.
>=20
> Fixes: commit 1e360a60b24a ("SUNRPC: Address  buffer overrun in
>  rpc_uaddr2sockaddr()")

It isn't clear to me that "Fixes" is appropriate as that patch isn't
harmful, just confused and sub-optimal.
But it probably doesn't mattter.

Reviewed-by: NeilBrown <neilb@suse.de>

Thanks,
NeilBrown


> Signed-off-by: Ahelenia Ziemia=C5=84ska <nabijaczleweli@nabijaczleweli.xyz>
> ---
>  net/sunrpc/addr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/net/sunrpc/addr.c b/net/sunrpc/addr.c
> index d435bffc6199..c4ba342f6866 100644
> --- a/net/sunrpc/addr.c
> +++ b/net/sunrpc/addr.c
> @@ -311,7 +311,7 @@ size_t rpc_uaddr2sockaddr(struct net *net, const char *=
uaddr,
>  			  const size_t uaddr_len, struct sockaddr *sap,
>  			  const size_t salen)
>  {
> -	char *c, buf[RPCBIND_MAXUADDRLEN + sizeof('\0')];
> +	char *c, buf[RPCBIND_MAXUADDRLEN + 1 /* NUL */];
>  	u8 portlo, porthi;
>  	unsigned short port;
> =20
>=20
> base-commit: 26aff849438cebcd05f1a647390c4aa700d5c0f1
> --=20
> 2.39.2
>=20