Received-SPF: pass (google.com: domain of linux-nfs+bounces-669-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 16 Dec 2023 06:43:09 +0100
From: 
	Ahelenia =?utf-8?Q?Ziemia=C5=84ska?= <nabijaczleweli@nabijaczleweli.xyz>
To: NeilBrown <neilb@suse.de>
Cc: Trond Myklebust <trond.myklebust@hammerspace.com>, 
	Anna Schumaker <anna@kernel.org>, Chuck Lever <chuck.lever@oracle.com>, 
	Jeff Layton <jlayton@kernel.org>, Olga Kornievskaia <kolga@netapp.com>, 
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>, 
	"David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, 
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, linux-nfs@vger.kernel.org, 
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sunrpc: sizeof('\0') is 4, not 1
Message-ID: <ikgsiev777wvypqueii5mcshrdeftme22stfvztonxbvcrf35l@tarta.nabijaczleweli.xyz>
References: <4zlmy3qwneijnrsbygfr2wbsnvdvcgvjyvudqnuxq5zvwmyaof@tarta.nabijaczleweli.xyz>
 <170270083607.12910.2219100479356858889@noble.neil.brown.name>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="ur233i3m2n556z64"
Content-Disposition: inline
In-Reply-To: <170270083607.12910.2219100479356858889@noble.neil.brown.name>
User-Agent: NeoMutt/20231103-116-3b855e-dirty


--ur233i3m2n556z64
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Dec 16, 2023 at 03:27:16PM +1100, NeilBrown wrote:
> On Sat, 16 Dec 2023, Ahelenia Ziemia=C5=84ska wrote:
> > To make it self-documenting, the referenced commit added the space
> > for the null terminator as sizeof('\0'). The message elaborates on
> > why only one byte is needed, so this is clearly a mistake.
> > Spell it as 1 /* NUL */ instead.
> >=20
> > Fixes: commit 1e360a60b24a ("SUNRPC: Address  buffer overrun in
> >  rpc_uaddr2sockaddr()")
> It isn't clear to me that "Fixes" is appropriate as that patch isn't
> harmful, just confused and sub-optimal.
I definitely agree, I don't like Fixes here at all,
but I don't really see another trailer in the documentation
or in the log that could be used for this.

--ur233i3m2n556z64
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEfWlHToQCjFzAxEFjvP0LAY0mWPEFAmV9OO0ACgkQvP0LAY0m
WPE42RAAuE2y/k1eIQefSd7rFtGSFVgZvFcRmrN8GquoYGeXs596QNnq8tAwSroo
6MB9avhWDwLI6opEuELRalbuFS30kddoRWPZxt/spkrU4hDcagWrU2wkgCb3lFAV
Xk0Q5m17j/7aKhOygEI5HlDQVvQu0lz6+8KBzUKGUWqznNZQJPOF0IL3CYO+NmbP
Jakn57ZSoT6hTWHsg6vfApSe3sZQiBbBfuxKLVfUMTdAmLl2JZj2UU0w/KXUeteW
vI7g7uigw+TXJVqcrAN6bEV4i96zQB523JGmYkhnA0/n03yTQg/mHWGqTsK7iFfC
IAakkDCWSJs+dXCnK5WJcBl/MpEGMsR9w0Nswua4CWTZAWFVW5rhKlcwyvagIH9p
FVR6osRtVRhYPHYtRXnYyuhmEDaFuLfgFc9YhuJ2JjXmRLOo1l3hITW5Al7/RC0G
o3W31S+7d/f+JB4f9WvJ7oo/3SvpzuUzqrpwpP6TR9RNyJ6nrs4Mxu5xk4dXz+vH
/v1SecxG/GUV/D005A96AfhkKpmuOClIRSpR5bOCkayoxalS1r1o2Cbj4VGgaDq3
kqYbRZ4uVcdC8EEmfYDwCZXG7ND961SYlEUDnE0EBqup4BptIoYwJudiODuKlNdb
o+JaEE4qV4S/QSxrL0tPgvfNqYpKBCdpBnQ9YLEq7fPg7ENw2QU=
=gDvI
-----END PGP SIGNATURE-----

--ur233i3m2n556z64--